First off, thank you for this fantastic module.

I notice one minor glitch after upgrading from 7.1.x to 7.2.1 : on the site I'm currently developing we deinstalled the comments module. After upgrading search_autocomplete it did not work on any form, throwing a PDO exception that it could not find the comments table. In the module config, the "Add comment titles" display option was enabled and greyed out, hence could not be disabled.
re-installing the comments module solved the problem and gave back access to the option; but it might be wise to include a check if the comments module is installed in future versions (and disable the "Add comments titles" option if not).

CommentFileSizeAuthor
#4 installation.patch1.48 KBdom.

Comments

dom.’s picture

dom. commented

Hi!

Thanks for reporting this bug. I can see you have solved it for your case, so that cool!

If I want to reproduce the procedure is:
- install version 7.x-1.0
- uninstall comment (or taxonomy for instance)
- upgrade module to 7.x-.2.1

And to solve:
- Add a module installation check on installation and update procedure to unable the suggestion type before it is greyed.

Is that all correct?

Thanks for using this module,
Miro.

bbbo’s picture

bbbo commented

Exactly. I'm not sure if I uninstalled comments before or after I started using search_autocomplete, but I don't think that matters since the problem only appeared after upgrading.

Apart from that little glitch, 7.2.1 so far works great for me.

dom.’s picture

dom. commented

Nice !

dom.’s picture

dom. commented
Status: Active » Patch (to be ported)
StatusFileSize
new installation.patch1.48 KB

Hi!

Here is a patch for your installation problem.
However, if you disable a dependant module (for instance comment or taxonomy) after Search Autocomplete was installed, the problem will still occur. It would take to change a module (comment or taxonomy) as dependent of Search Autocomplete, as soon as a suggestion type uses it. However, I can't find how to do that in Drupal doc.

Miro.

bbbo’s picture

bbbo commented

I'd say updating the documentation to clarify this issue would help; most installs will have comments and taxonomy enabled, to the problem only touches a certain percentage of installs.

dom.’s picture

dom. commented

Added here:
http://projects.axiomcafe.fr/search-autocomplete/installing-module

dom.’s picture

dom. commented
Status: Patch (to be ported) » Fixed

Should be fixed in 7.x-2.3 !
Miro.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.