Disable/Enable module results in error [#1418084]

If you disable and then immediately re-enable the API module, the hook_enable() code gives you this error:

User warning: Duplicate entry 'php-php' for key 'project_name' query: INSERT INTO api_branch (branch_name, project, type, data, status, title, project_title, weight) VALUES ('php', 'php', 'php', 'a:2:{s:7:\"summary\";s:67:\"http://svn.php.net/repository/phpdoc/doc-base/trunk/funcsummary.txt\";s:4:\"path\";s:24:\"http://php.net/!function\";}', 0, 'PHP functions', 'php', 0) in _db_query() (line 134 of /opt/www/apisite/includes/database.mysqli.inc).

Comment	File	Size	Author
#1	1418084.patch	664 bytes	jhodgdon

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 27 January 2012 at 22:49

Priority:	Normal	» Minor
Status:	Active	» Reviewed & tested by the community

File	Size
1418084.patch	664 bytes

Ah. The problem is here in api_enable():

  $names = api_get_branch_names();
  if (!isset($names['php'])) {
    // Save PHP branch
...

api_get_branch_names() only returns the names of branches whose status is 1. But the PHP branches have status=0, so this isset() is always returning FALSE, even though the branch exists.

So I think we just need to do our own query here for a branch with name 'php' instead of calling api_get_branch_names().

Here's a patch... it appears to work both for disable/enable on an existing API site, and for enabling the API module for the first time.

I plan to commit it after the next release (in a week or two).