Coder upgrade looks like it takes out the $from and $count parameters entirely instead of putting them between the $query and $args. It gave me this:

@@ -538,7 +641,7 @@ function chanadv_product_record_changes(
     return;
   }
 
-  $status = db_result(db_query_range("SELECT status FROM {chanadv_listings} WHERE model = '%s' ORDER BY queued DESC, status DESC", $node->model, 0, 1));
+  $status = db_query_range("SELECT status FROM {chanadv_listings} WHERE model = :model ORDER BY queued DESC, status DESC", array(':model' => $node->model))->fetchField();
   // Don't overwrite previous status changes. However, price updates could be
   // upgraded to full syncs.
   if ($status != CHANADV_SYNCHED && $status != CHANADV_UPDATE_PRICE) {

I am happy that it took care of db_result() correctly, though.

Comments

klausi’s picture

Issue summary: View changes
Status: Active » Closed (won't fix)

Coder 7.x-1.x is frozen now and will not receive any updates. Coder 8.x-2.x can be used to check code for any Drupal version, Coder 8.x-2.x also supports the phpcbf command to automatically fix conding standard errors. Please check if this issue is still relevant and reopen against that version if necessary.