Strict warning: Only variables should be passed by reference in workflow_tab_page()

I would like to second this report. When I click the Workflow tab of a node, I get the same error.

Just looked at the code, and I'm confused, because it doesn't look like anything is getting passed by reference:

$output .= drupal_render(drupal_get_form('workflow_tab_form', $node, $workflow->wid, $states, $current));

*shrug*

This forum discussion might be useful in figuring out how to fix the bug:

http://drupal.org/node/1064792

Hello, All!
Problem is that Drupal needs a variable to render. So the combination drupal_render(drupal_get_form(...)) is bad.
There are two files to edit:
workflow.pages.inc (line 26)

  $output .= drupal_render(drupal_get_form('workflow_tab_form', $node, $workflow->wid, $states, $current));

change to:

  $form = drupal_get_form('workflow_tab_form', $node, $workflow->wid, $states, $current);
  $output .= drupal_render($form);

and workflow_admin_ui/workflow_admin_ui.module (line 756)

    $output .= drupal_render(drupal_get_form('workflow_admin_ui_types_form'));

change to:

    $form = drupal_get_form('workflow_admin_ui_types_form');
    $output .= drupal_render($form);

I can confirm this has worked for us.

#5 worked for me too. Here's a patch.

Looks like you ran your diff from the modules folder, not the workflow folder Morten. I've tweaked the patch for that directory difference. Otherwise, looks good and has been committed on 7.x-1.x-dev branch.

Thanks all :)

Good work Firewolf :)

Worked for me, thank you.

I also was getting the same issue, while rendering user menu. My code is -

Before -
$tree = menu_tree_all_data('user-menu');
$html = drupal_render(menu_tree_output($tree));

After making these to :
$tree = menu_tree_all_data('user-menu');
$menu = menu_tree_output($tree);
$html = render($menu);

it worked perfectly.

Thanks All.

#5 is worked fine for me. Thanks

#5 worked for me.

#5 worked for me.

@bisw, are you still at version 1.0?