Got this notice in the latest version.

Notice: Undefined variable: conditions in uc_recurring_subscription_ca_condition() (line 22 of uc_recurring_subscription.ca.inc)

It is caused by the variable $conditions not being initialized (instead $condition is initialized) This is a typo.

The attached patch should be an easy review, please review it so it can be committed.
Thanks!

CommentFileSizeAuthor
#10 fix-typo-uc_recurring_subscriptions-1418316-10.patch572 bytesshaundychko
#9 uc_recurring-undefined_variable_notice-1418316-9.patch4.64 KBvmi
#7 uc_recurring_subscription.admin_.inc_.TXT32.71 KBvmi
#6 uc_recurring_subscription.admin_.inc_.TXT32.72 KBvmi
#5 uc_recurring_subscription.admin_.inc_.txt32.53 KBvmi
#1 uc_recurring_subscription.ca_.inc_.patch411 byteswestwesterson
uc_recurring_subscription.ca_.inc_.patch657 byteswestwesterson

Comments

westwesterson’s picture

westwesterson commented
StatusFileSize
new uc_recurring_subscription.ca_.inc_.patch411 bytes

Better patch file; same exact patch

westwesterson’s picture

westwesterson commented
Status: Active » Needs review

also, it is ready for review

vmi’s picture

vmi commented
Status: Needs review » Needs work

While using uc_recurring_subscription under PHP v5.3.9 and D6 Pressflow clean install, I receive the following errors when I browse to /admin/store/subscriptions/create

I've applied the above patch and cleared cache/reinstalled module but I'm still experiencing problems. Please advise.
Thank you.

Notice: Undefined variable: node in uc_recurring_subscription_product_form() (line 116 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Trying to get property of non-object in uc_recurring_subscription_product_form() (line 116 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Undefined variable: node in uc_recurring_subscription_product_form() (line 121 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Trying to get property of non-object in uc_recurring_subscription_product_form() (line 121 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Undefined variable: node in uc_recurring_subscription_product_form() (line 138 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Trying to get property of non-object in uc_recurring_subscription_product_form() (line 138 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Trying to get property of non-object in uc_recurring_subscription_product_form() (line 138 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Undefined variable: node in uc_recurring_subscription_product_form() (line 139 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Trying to get property of non-object in uc_recurring_subscription_product_form() (line 139 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Trying to get property of non-object in uc_recurring_subscription_product_form() (line 139 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Trying to get property of non-object in uc_recurring_subscription_product_form() (line 139 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Undefined variable: trial_product in uc_recurring_subscription_product_form() (line 164 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Trying to get property of non-object in uc_recurring_subscription_product_form() (line 164 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Undefined variable: trial_product in uc_recurring_subscription_product_form() (line 177 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Trying to get property of non-object in uc_recurring_subscription_product_form() (line 177 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Undefined variable: default_options in uc_recurring_subscription_product_form() (line 224 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Undefined variable: node in uc_recurring_subscription_product_form() (line 262 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Trying to get property of non-object in uc_recurring_subscription_product_form() (line 262 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Trying to get property of non-object in uc_recurring_subscription_product_form() (line 262 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Undefined variable: node in uc_recurring_subscription_product_form() (line 270 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Trying to get property of non-object in uc_recurring_subscription_product_form() (line 270 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Trying to get property of non-object in uc_recurring_subscription_product_form() (line 270 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Undefined variable: node in uc_recurring_subscription_product_form() (line 278 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Trying to get property of non-object in uc_recurring_subscription_product_form() (line 278 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Trying to get property of non-object in uc_recurring_subscription_product_form() (line 278 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
Notice: Undefined variable: rows in theme_uc_recurring_subscription_item() (line 807 of /srv/bindings/a2f7fcddc6e84d848f9b10beebf63c82/code/sites/all/modules/uc_recurring/modules/uc_recurring_subscription/uc_recurring_subscription.admin.inc).
vmi’s picture

vmi commented

Also does the Role module under ubercart - core (optional) need to be listed as a dependency for this module?

vmi’s picture

vmi commented
StatusFileSize
new uc_recurring_subscription.admin_.inc_.txt32.53 KB

Not sure if this was the best way to deal with this or if it'll break something but I've gone back to all the variables on lines which were producing the error notice and assigned them to NULL if they're not set.

I've also attached my uc_recurring_subscription.admin.inc file with the changes in case someone can review and issue a patch.

Please use the most current file listed below instead.

See patch below.

Thanks.

vmi’s picture

vmi commented
StatusFileSize
new uc_recurring_subscription.admin_.inc_.TXT32.72 KB

Please ignore the above file and this one -- instead please use the latest to review and create a patch
See patch below.

vmi’s picture

vmi commented
StatusFileSize
new uc_recurring_subscription.admin_.inc_.TXT32.71 KB

There were a few more variables I addressed in this file.
Perhaps it could be merged with the original patch from above?

To recap the changes I've made were on or near the following lines:
116, 121, 138, 139, 164, 177, 224, 262, 270, 278, 807

Also I've added .TXT to the end of the filename so drupal.org would accept the upload.

See patch below.

westwesterson’s picture

westwesterson commented
Title: uc_recurring undefined variable notice casued by typo. » uc_recurring undefined variable notice

its really hard to see the differences without a patch;
i originally only fixed one instance of a notice generated by the uc_recurring module.

I am open to expanding it to fix multiple notices.

Heres how to create a patch via git:
http://drupal.org/node/707484

might be a day or two before i can look at this

vmi’s picture

vmi commented
StatusFileSize
new uc_recurring-undefined_variable_notice-1418316-9.patch4.64 KB

Here's the patch.

shaundychko’s picture

shaundychko
Location Vancouver, Canada
commented
StatusFileSize
new fix-typo-uc_recurring_subscriptions-1418316-10.patch572 bytes

Re-rolled patch in #1 with git, and renamed. (not sure if patch in #9 is better... I'm not actually seeing this error notice, but the fix in #1 is obviously needed)