Hi

This is a module to integrate Drupal and SAP Enterprise Services specifically SAP HR (HCM) services. The modules takes 2 scenario - 1) Get each employee information (including direct reports, vacation balance, manager, etc) from the backend SAP and the 2) Apply for vacation and the manager can approve the vacation request.

The module is available for Drupal 6, and going forward would also be available for Drupal 7. The code is installed and running at http://www.10jumps.com/demo/sap_drupal/, all the use cases available as links at the top.

The project page http://drupal.org/sandbox/bpadhu/1333838 explains in detail about the installation, what to expect and the roadmap for this module.
Module name: SAP HR Integration
Target Version: Drupal 6

Thanks and best regards
Padhu

CommentFileSizeAuthor
#8 bpadhu_errors.txt205.57 KBnovalnet

Comments

patrickd’s picture

Category: feature » task
Status: Active » Needs review

If you want to get reviewed you have to set "needs review" status.

eugene.ilyin’s picture

Hello. I spent manual review of your module.

  • // Container for employee information webservice: inline comments must end by dot. Check other places also.
  • version = "6.x-0.1" - remove this tag. Drupal.org add it automatically.
  • t() is not necessarily be used to hook_menu in title and description. You use t() for some lines, but not for other lines. It looks weird.
  • " * Calls 3 webservices: Employee Information, ManageInformation and Vacation Balance Information." - max string length recomended is 80 chars . In other places also.
  • return t('

    No Leave Requests

    '); - don't put tags in t() function. Use concat.

  • drupal_set_message(check_plain(t('<h2>Error!</h2>'<pre>!msg</pre>', array('!msg' => 'Not configured properly'))), 'error');
  • You put tags into check_plain? Why?
  • sap_hr_integration.info Why is this file?
  • $form['#submit'][] = 'sap_hr_create_leave_request_user_submit';:
    If you have functions with names sap_hr_create_leave_request_user and sap_hr_create_leave_request_user_submit, this line is not need. Form API call it automatically.
eugene.ilyin’s picture

Status: Needs review » Needs work
bpadhu’s picture

Status: Needs work » Needs review

Hi

I have fixed all the issues based on your review. Please continue the review and let me know if I need to do any more changes.

Thanks and best regards
Padhu

eugene.ilyin’s picture

Review by pareview script. You have many errors.

See http://ventral.org/pareview/httpgitdrupalorgsandboxbpadhu1333838git.

patrickd’s picture

@ilyin.eugene
please use <code> tags, and attach such large reports as txt file in future

eugene.ilyin’s picture

Sorry. Fixed.

novalnet’s picture

Status: Needs review » Needs work
StatusFileSize
new205.57 KB

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

  • README.txt is missing, see the guidelines for in-project documentation.
  • Remove "project" from the info file, it will be added by drupal.org packaging automatically.
  • The "?>" PHP delimiter at the end of files is discouraged, see http://drupal.org/node/318#phptags
    ./modules/sap_soapclient/AES128.php
    
  • ./sap_hr.user.inc: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
    function soapclient_invoke_submit_leave_request($sap_employee_id, $wsdl_protocol, $wsdl_url, $soap_action, $org_request_xml, $start_date, $end_date, $category) {
    
  • ./modules/sap_soapclient/sap_soapclient.install: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
    function sap_soapclient_install() {
    function sap_soapclient_uninstall() {
    
  • ./modules/sap_soapclient/sap_soapclient.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
    function sap_soapclient_init() {
    function sap_soapclient_exit($destination = NULL) {
    function sap_soapclient_menu() {
    function sap_soapclient_admin_settings() {
    function sap_soapclient_init_client($endpoint, $username = '', $password = '', $use_wsdl = TRUE, $options = array()) {
    function sap_soapclient_encrypt($plain, $key, $iv = 'password') {
    function sap_soapclient_decrypt($cipher, $key, $iv = 'password') {
    function sap_xml_parser_string_to_array($str) {
    function xml_serialize($tagname, $data) {
    
  • ./sap_hr.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
    function sapuser_view($sap_employee_id = '') {
    function sapmanager_view($sap_employee_id) {
    function sapmanager_view_leaverequests($sap_employee_id) {
    function sapdirect_report_view($sap_employee_id) {
    function sapmanager_approve_request($leave_request_id) {
    function approveLeaveRequest($leave_request_id) {
    function getEmployeeInformation($sap_employee_id) {
    function getDirectReports($sap_employee_id) {
    function getLeaveRequests($sap_employee_id) {
    function getManagerInformation($sap_employee_id) {
    function getVacationBalanceInformation($sap_employee_id) {
    function soapclient_invoke_get_emp_info($sap_employee_id, $wsdl_protocol, $wsdl_url, $soap_action, $org_request_xml) {
    function soapclient_invoke_approve_leave_request($leave_request_id, $wsdl_protocol, $wsdl_url, $soap_action, $org_request_xml) {
    
  • Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting
    ./sap_hr.info:                                   ASCII text, with CRLF, LF line terminators
    ./modules/sap_soapclient/sap_soapclient.info:    ASCII text, with CRLF, LF line terminators
    modules/sap_soapclient/sap_soapclient.info
    sap_hr.info
    sap_hr.install
    
  • Run coder to check your style, some issues were found (please check the Drupal coding standards). See attachment.
  • Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards

sites/all/modules/pareview_temp/./test_candidate/sap_hr.user.inc:
 +53: [minor] When labelling buttons, make it clear what the button does, "Submit" is too generic.
 +65: [minor] in most cases, replace the string function with the drupal_ equivalent string functions
 +66: [minor] in most cases, replace the string function with the drupal_ equivalent string functions
 +90: [minor] in most cases, replace the string function with the drupal_ equivalent string functions
 +91: [minor] in most cases, replace the string function with the drupal_ equivalent string functions
 +95: [minor] in most cases, replace the string function with the drupal_ equivalent string functions
 +99: [minor] in most cases, replace the string function with the drupal_ equivalent string functions
 +103: [minor] in most cases, replace the string function with the drupal_ equivalent string functions

sites/all/modules/pareview_temp/./test_candidate/sap_hr.install:
 +21: [minor] use lowercase html tags to comply with XHTML
 +22: [minor] use lowercase html tags to comply with XHTML
 +24: [minor] use lowercase html tags to comply with XHTML
 +25: [minor] use lowercase html tags to comply with XHTML
 +37: [minor] use lowercase html tags to comply with XHTML
 +38: [minor] use lowercase html tags to comply with XHTML
 +40: [minor] use lowercase html tags to comply with XHTML
 +41: [minor] use lowercase html tags to comply with XHTML
 +53: [minor] use lowercase html tags to comply with XHTML
 +54: [minor] use lowercase html tags to comply with XHTML
 +56: [minor] use lowercase html tags to comply with XHTML
 +57: [minor] use lowercase html tags to comply with XHTML
 +59: [minor] use lowercase html tags to comply with XHTML
 +60: [minor] use lowercase html tags to comply with XHTML
 +61: [minor] use lowercase html tags to comply with XHTML
 +62: [minor] use lowercase html tags to comply with XHTML
 +64: [minor] use lowercase html tags to comply with XHTML
 +65: [minor] use lowercase html tags to comply with XHTML
 +66: [minor] use lowercase html tags to comply with XHTML
 +68: [minor] use lowercase html tags to comply with XHTML
 +69: [minor] use lowercase html tags to comply with XHTML
 +70: [minor] use lowercase html tags to comply with XHTML
 +71: [minor] use lowercase html tags to comply with XHTML
 +72: [minor] use lowercase html tags to comply with XHTML
 +73: [minor] use lowercase html tags to comply with XHTML
 +74: [minor] use lowercase html tags to comply with XHTML
 +89: [minor] use lowercase html tags to comply with XHTML
 +90: [minor] use lowercase html tags to comply with XHTML
 +92: [minor] use lowercase html tags to comply with XHTML
 +93: [minor] use lowercase html tags to comply with XHTML
 +105: [minor] use lowercase html tags to comply with XHTML
 +106: [minor] use lowercase html tags to comply with XHTML
 +108: [minor] use lowercase html tags to comply with XHTML
 +109: [minor] use lowercase html tags to comply with XHTML
 +121: [minor] use lowercase html tags to comply with XHTML
 +122: [minor] use lowercase html tags to comply with XHTML
 +124: [minor] use lowercase html tags to comply with XHTML
 +125: [minor] use lowercase html tags to comply with XHTML
 +126: [minor] use lowercase html tags to comply with XHTML
 +127: [minor] use lowercase html tags to comply with XHTML
 +128: [minor] use lowercase html tags to comply with XHTML
 +141: [minor] use lowercase html tags to comply with XHTML
 +142: [minor] use lowercase html tags to comply with XHTML
 +144: [minor] use lowercase html tags to comply with XHTML
 +145: [minor] use lowercase html tags to comply with XHTML
 +146: [minor] use lowercase html tags to comply with XHTML

Status Messages:
 Coder found 6 projects, 6 files, 54 minor warnings, 0 warnings were flagged to be ignored

FILE: .../modules/pareview_temp/test_candidate/modules/sap_soapclient/AES128.php
--------------------------------------------------------------------------------
FOUND 874 ERROR(S) AND 11 WARNING(S) AFFECTING 418 LINE(S)
--------------------------------------------------------------------------------
   4 | ERROR   | The second line in the file doc comment must be " * @file"
   5 | ERROR   | The third line in the file doc comment must contain a
     |         | description and must not be indented
  23 | ERROR   | Whitespace found at end of line
  32 | ERROR   | More than 2 empty lines are not allowed
  33 | ERROR   | More than 2 empty lines are not allowed
  34 | ERROR   | More than 2 empty lines are not allowed
  37 | ERROR   | Whitespace found at end of line
  41 | ERROR   | Whitespace found at end of line
  43 | ERROR   | The PHP 4-style "var" declaration must not be used.
  45 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  45 | ERROR   | Array indentation error, expected 6 spaces but found 2
  45 | ERROR   | Whitespace found at end of line
  47 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  47 | ERROR   | Array indentation error, expected 6 spaces but found 2
  47 | ERROR   | Whitespace found at end of line
  49 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  49 | ERROR   | Array indentation error, expected 6 spaces but found 2
  49 | ERROR   | Whitespace found at end of line
  51 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  51 | ERROR   | Array indentation error, expected 6 spaces but found 2
  51 | ERROR   | Whitespace found at end of line
  53 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  53 | ERROR   | Array indentation error, expected 6 spaces but found 2
  55 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  55 | ERROR   | Array indentation error, expected 6 spaces but found 2
  57 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  57 | ERROR   | Array indentation error, expected 6 spaces but found 2
  59 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  59 | ERROR   | Array indentation error, expected 6 spaces but found 2
  59 | ERROR   | Whitespace found at end of line
  61 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  61 | ERROR   | Array indentation error, expected 6 spaces but found 2
  63 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  63 | ERROR   | Array indentation error, expected 6 spaces but found 2
  65 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  65 | ERROR   | Array indentation error, expected 6 spaces but found 2
  67 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  67 | ERROR   | Array indentation error, expected 6 spaces but found 2
  69 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  69 | ERROR   | Array indentation error, expected 6 spaces but found 2
  71 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  71 | ERROR   | Array indentation error, expected 6 spaces but found 2
  73 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  73 | ERROR   | Array indentation error, expected 6 spaces but found 2
  75 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  75 | ERROR   | Array indentation error, expected 6 spaces but found 2
  77 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  77 | ERROR   | Array indentation error, expected 6 spaces but found 5
  79 | ERROR   | Whitespace found at end of line
  83 | ERROR   | The PHP 4-style "var" declaration must not be used.
  85 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  85 | ERROR   | Array indentation error, expected 6 spaces but found 2
  87 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  87 | ERROR   | Array indentation error, expected 6 spaces but found 2
  89 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  89 | ERROR   | Array indentation error, expected 6 spaces but found 2
  91 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  91 | ERROR   | Array indentation error, expected 6 spaces but found 2
  93 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  93 | ERROR   | Array indentation error, expected 6 spaces but found 2
  95 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  95 | ERROR   | Array indentation error, expected 6 spaces but found 5
  97 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  97 | ERROR   | Array indentation error, expected 6 spaces but found 2
  99 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  99 | ERROR   | Array indentation error, expected 6 spaces but found 2
 101 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 101 | ERROR   | Array indentation error, expected 6 spaces but found 2
 103 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 103 | ERROR   | Array indentation error, expected 6 spaces but found 2
 105 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 105 | ERROR   | Array indentation error, expected 6 spaces but found 2
 107 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 107 | ERROR   | Array indentation error, expected 6 spaces but found 5
 109 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 109 | ERROR   | Array indentation error, expected 6 spaces but found 2
 111 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 111 | ERROR   | Array indentation error, expected 6 spaces but found 2
 113 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 113 | ERROR   | Array indentation error, expected 6 spaces but found 2
 115 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 115 | ERROR   | Array indentation error, expected 6 spaces but found 2
 117 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 117 | ERROR   | Array indentation error, expected 6 spaces but found 2
 119 | ERROR   | Whitespace found at end of line
 123 | ERROR   | The PHP 4-style "var" declaration must not be used.
 123 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 125 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 125 | ERROR   | Array indentation error, expected 6 spaces but found 2
 127 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 127 | ERROR   | Array indentation error, expected 6 spaces but found 5
 129 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 129 | ERROR   | Array indentation error, expected 6 spaces but found 5
 131 | ERROR   | Whitespace found at end of line
 135 | ERROR   | The PHP 4-style "var" declaration must not be used.
 135 | ERROR   | Whitespace found at end of line
 137 | ERROR   | Array indentation error, expected 6 spaces but found 8
 137 | ERROR   | Whitespace found at end of line
 139 | ERROR   | Array indentation error, expected 6 spaces but found 8
 139 | ERROR   | Whitespace found at end of line
 141 | ERROR   | Array indentation error, expected 6 spaces but found 8
 141 | ERROR   | Whitespace found at end of line
 143 | ERROR   | Array indentation error, expected 6 spaces but found 8
 143 | ERROR   | Whitespace found at end of line
 145 | ERROR   | Array indentation error, expected 6 spaces but found 8
 145 | ERROR   | Whitespace found at end of line
 147 | ERROR   | Array indentation error, expected 6 spaces but found 8
 147 | ERROR   | Whitespace found at end of line
 149 | ERROR   | Array indentation error, expected 6 spaces but found 8
 149 | ERROR   | Whitespace found at end of line
 151 | ERROR   | Array indentation error, expected 6 spaces but found 8
 151 | ERROR   | Whitespace found at end of line
 153 | ERROR   | Array indentation error, expected 6 spaces but found 8
 153 | ERROR   | Whitespace found at end of line
 155 | ERROR   | Array indentation error, expected 6 spaces but found 8
 155 | ERROR   | Whitespace found at end of line
 157 | ERROR   | Array indentation error, expected 6 spaces but found 8
 157 | ERROR   | Whitespace found at end of line
 159 | ERROR   | Array indentation error, expected 6 spaces but found 8
 159 | ERROR   | Whitespace found at end of line
 161 | ERROR   | Array indentation error, expected 6 spaces but found 8
 161 | ERROR   | Whitespace found at end of line
 163 | ERROR   | Array indentation error, expected 6 spaces but found 8
 163 | ERROR   | Whitespace found at end of line
 165 | ERROR   | Array indentation error, expected 6 spaces but found 8
 165 | ERROR   | Whitespace found at end of line
 167 | ERROR   | Array indentation error, expected 6 spaces but found 8
 167 | ERROR   | Whitespace found at end of line
 169 | ERROR   | Array indentation error, expected 6 spaces but found 8
 171 | ERROR   | Whitespace found at end of line
 175 | ERROR   | The PHP 4-style "var" declaration must not be used.
 175 | ERROR   | Whitespace found at end of line
 177 | ERROR   | Array indentation error, expected 6 spaces but found 8
 177 | ERROR   | Whitespace found at end of line
 179 | ERROR   | Array indentation error, expected 6 spaces but found 8
 179 | ERROR   | Whitespace found at end of line
 181 | ERROR   | Array indentation error, expected 6 spaces but found 8
 181 | ERROR   | Whitespace found at end of line
 183 | ERROR   | Array indentation error, expected 6 spaces but found 8
 183 | ERROR   | Whitespace found at end of line
 185 | ERROR   | Array indentation error, expected 6 spaces but found 8
 185 | ERROR   | Whitespace found at end of line
 187 | ERROR   | Array indentation error, expected 6 spaces but found 8
 187 | ERROR   | Whitespace found at end of line
 189 | ERROR   | Array indentation error, expected 6 spaces but found 8
 189 | ERROR   | Whitespace found at end of line
 191 | ERROR   | Array indentation error, expected 6 spaces but found 8
 191 | ERROR   | Whitespace found at end of line
 193 | ERROR   | Array indentation error, expected 6 spaces but found 8
 193 | ERROR   | Whitespace found at end of line
 195 | ERROR   | Array indentation error, expected 6 spaces but found 8
 195 | ERROR   | Whitespace found at end of line
 197 | ERROR   | Array indentation error, expected 6 spaces but found 8
 197 | ERROR   | Whitespace found at end of line
 199 | ERROR   | Array indentation error, expected 6 spaces but found 8
 199 | ERROR   | Whitespace found at end of line
 201 | ERROR   | Array indentation error, expected 6 spaces but found 8
 201 | ERROR   | Whitespace found at end of line
 203 | ERROR   | Array indentation error, expected 6 spaces but found 8
 203 | ERROR   | Whitespace found at end of line
 205 | ERROR   | Array indentation error, expected 6 spaces but found 8
 205 | ERROR   | Whitespace found at end of line
 207 | ERROR   | Array indentation error, expected 6 spaces but found 8
 207 | ERROR   | Whitespace found at end of line
 209 | ERROR   | Array indentation error, expected 6 spaces but found 8
 211 | ERROR   | Whitespace found at end of line
 215 | ERROR   | The PHP 4-style "var" declaration must not be used.
 215 | ERROR   | Whitespace found at end of line
 217 | ERROR   | Array indentation error, expected 6 spaces but found 8
 217 | ERROR   | Whitespace found at end of line
 219 | ERROR   | Array indentation error, expected 6 spaces but found 8
 219 | ERROR   | Whitespace found at end of line
 221 | ERROR   | Array indentation error, expected 6 spaces but found 8
 221 | ERROR   | Whitespace found at end of line
 223 | ERROR   | Array indentation error, expected 6 spaces but found 8
 223 | ERROR   | Whitespace found at end of line
 225 | ERROR   | Array indentation error, expected 6 spaces but found 8
 225 | ERROR   | Whitespace found at end of line
 227 | ERROR   | Array indentation error, expected 6 spaces but found 8
 227 | ERROR   | Whitespace found at end of line
 229 | ERROR   | Array indentation error, expected 6 spaces but found 8
 229 | ERROR   | Whitespace found at end of line
 231 | ERROR   | Array indentation error, expected 6 spaces but found 8
 231 | ERROR   | Whitespace found at end of line
 233 | ERROR   | Array indentation error, expected 6 spaces but found 8
 233 | ERROR   | Whitespace found at end of line
 235 | ERROR   | Array indentation error, expected 6 spaces but found 8
 235 | ERROR   | Whitespace found at end of line
 237 | ERROR   | Array indentation error, expected 6 spaces but found 8
 237 | ERROR   | Whitespace found at end of line
 239 | ERROR   | Array indentation error, expected 6 spaces but found 8
 239 | ERROR   | Whitespace found at end of line
 241 | ERROR   | Array indentation error, expected 6 spaces but found 8
 241 | ERROR   | Whitespace found at end of line
 243 | ERROR   | Array indentation error, expected 6 spaces but found 8
 243 | ERROR   | Whitespace found at end of line
 245 | ERROR   | Array indentation error, expected 6 spaces but found 8
 245 | ERROR   | Whitespace found at end of line
 247 | ERROR   | Array indentation error, expected 6 spaces but found 8
 247 | ERROR   | Whitespace found at end of line
 249 | ERROR   | Array indentation error, expected 6 spaces but found 8
 251 | ERROR   | Whitespace found at end of line
 255 | ERROR   | The PHP 4-style "var" declaration must not be used.
 255 | ERROR   | Whitespace found at end of line
 257 | ERROR   | Array indentation error, expected 6 spaces but found 8
 257 | ERROR   | Whitespace found at end of line
 259 | ERROR   | Array indentation error, expected 6 spaces but found 8
 259 | ERROR   | Whitespace found at end of line
 261 | ERROR   | Array indentation error, expected 6 spaces but found 8
 261 | ERROR   | Whitespace found at end of line
 263 | ERROR   | Array indentation error, expected 6 spaces but found 8
 263 | ERROR   | Whitespace found at end of line
 265 | ERROR   | Array indentation error, expected 6 spaces but found 8
 265 | ERROR   | Whitespace found at end of line
 267 | ERROR   | Array indentation error, expected 6 spaces but found 8
 267 | ERROR   | Whitespace found at end of line
 269 | ERROR   | Array indentation error, expected 6 spaces but found 8
 269 | ERROR   | Whitespace found at end of line
 271 | ERROR   | Array indentation error, expected 6 spaces but found 8
 271 | ERROR   | Whitespace found at end of line
 273 | ERROR   | Array indentation error, expected 6 spaces but found 8
 273 | ERROR   | Whitespace found at end of line
 275 | ERROR   | Array indentation error, expected 6 spaces but found 8
 275 | ERROR   | Whitespace found at end of line
 277 | ERROR   | Array indentation error, expected 6 spaces but found 8
 277 | ERROR   | Whitespace found at end of line
 279 | ERROR   | Array indentation error, expected 6 spaces but found 8
 279 | ERROR   | Whitespace found at end of line
 281 | ERROR   | Array indentation error, expected 6 spaces but found 8
 281 | ERROR   | Whitespace found at end of line
 283 | ERROR   | Array indentation error, expected 6 spaces but found 8
 283 | ERROR   | Whitespace found at end of line
 285 | ERROR   | Array indentation error, expected 6 spaces but found 8
 285 | ERROR   | Whitespace found at end of line
 287 | ERROR   | Array indentation error, expected 6 spaces but found 8
 287 | ERROR   | Whitespace found at end of line
 289 | ERROR   | Array indentation error, expected 6 spaces but found 8
 291 | ERROR   | Whitespace found at end of line
 295 | ERROR   | The PHP 4-style "var" declaration must not be used.
 295 | ERROR   | Whitespace found at end of line
 297 | ERROR   | Array indentation error, expected 6 spaces but found 8
 297 | ERROR   | Whitespace found at end of line
 299 | ERROR   | Array indentation error, expected 6 spaces but found 8
 299 | ERROR   | Whitespace found at end of line
 301 | ERROR   | Array indentation error, expected 6 spaces but found 8
 301 | ERROR   | Whitespace found at end of line
 303 | ERROR   | Array indentation error, expected 6 spaces but found 8
 303 | ERROR   | Whitespace found at end of line
 305 | ERROR   | Array indentation error, expected 6 spaces but found 8
 305 | ERROR   | Whitespace found at end of line
 307 | ERROR   | Array indentation error, expected 6 spaces but found 8
 307 | ERROR   | Whitespace found at end of line
 309 | ERROR   | Array indentation error, expected 6 spaces but found 8
 309 | ERROR   | Whitespace found at end of line
 311 | ERROR   | Array indentation error, expected 6 spaces but found 8
 311 | ERROR   | Whitespace found at end of line
 313 | ERROR   | Array indentation error, expected 6 spaces but found 8
 313 | ERROR   | Whitespace found at end of line
 315 | ERROR   | Array indentation error, expected 6 spaces but found 8
 315 | ERROR   | Whitespace found at end of line
 317 | ERROR   | Array indentation error, expected 6 spaces but found 8
 317 | ERROR   | Whitespace found at end of line
 319 | ERROR   | Array indentation error, expected 6 spaces but found 8
 319 | ERROR   | Whitespace found at end of line
 321 | ERROR   | Array indentation error, expected 6 spaces but found 8
 321 | ERROR   | Whitespace found at end of line
 323 | ERROR   | Array indentation error, expected 6 spaces but found 8
 323 | ERROR   | Whitespace found at end of line
 325 | ERROR   | Array indentation error, expected 6 spaces but found 8
 325 | ERROR   | Whitespace found at end of line
 327 | ERROR   | Array indentation error, expected 6 spaces but found 8
 327 | ERROR   | Whitespace found at end of line
 329 | ERROR   | Array indentation error, expected 6 spaces but found 8
 331 | ERROR   | Whitespace found at end of line
 335 | ERROR   | The PHP 4-style "var" declaration must not be used.
 335 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 335 | ERROR   | Whitespace found at end of line
 337 | ERROR   | Array indentation error, expected 6 spaces but found 8
 337 | ERROR   | Whitespace found at end of line
 339 | ERROR   | Array indentation error, expected 6 spaces but found 8
 339 | ERROR   | Whitespace found at end of line
 341 | ERROR   | Array indentation error, expected 6 spaces but found 8
 341 | ERROR   | Whitespace found at end of line
 343 | ERROR   | Array indentation error, expected 6 spaces but found 8
 343 | ERROR   | Whitespace found at end of line
 345 | ERROR   | Array indentation error, expected 6 spaces but found 8
 345 | ERROR   | Whitespace found at end of line
 347 | ERROR   | Array indentation error, expected 6 spaces but found 8
 347 | ERROR   | Whitespace found at end of line
 349 | ERROR   | Array indentation error, expected 6 spaces but found 8
 349 | ERROR   | Whitespace found at end of line
 351 | ERROR   | Array indentation error, expected 6 spaces but found 8
 351 | ERROR   | Whitespace found at end of line
 353 | ERROR   | Array indentation error, expected 6 spaces but found 8
 353 | ERROR   | Whitespace found at end of line
 355 | ERROR   | Array indentation error, expected 6 spaces but found 8
 355 | ERROR   | Whitespace found at end of line
 357 | ERROR   | Array indentation error, expected 6 spaces but found 8
 357 | ERROR   | Whitespace found at end of line
 359 | ERROR   | Array indentation error, expected 6 spaces but found 8
 359 | ERROR   | Whitespace found at end of line
 361 | ERROR   | Array indentation error, expected 6 spaces but found 8
 361 | ERROR   | Whitespace found at end of line
 363 | ERROR   | Array indentation error, expected 6 spaces but found 8
 363 | ERROR   | Whitespace found at end of line
 365 | ERROR   | Array indentation error, expected 6 spaces but found 8
 365 | ERROR   | Whitespace found at end of line
 367 | ERROR   | Array indentation error, expected 6 spaces but found 8
 367 | ERROR   | Whitespace found at end of line
 369 | ERROR   | Array indentation error, expected 6 spaces but found 8
 371 | ERROR   | Whitespace found at end of line
 373 | ERROR   | The PHP 4-style "var" declaration must not be used.
 373 | ERROR   | An operator statement must be followed by a single space
 373 | ERROR   | There must be a single space before an operator statement
 373 | ERROR   | No space before comment text; expected "// N�mero de rondas
     |         | 128b=>10" but found "//N�mero de rondas 128b=>10"
 373 | ERROR   | There must be no blank line following an inline comment
 373 | ERROR   | Comments may not appear after statements.
 375 | ERROR   | The PHP 4-style "var" declaration must not be used.
 375 | ERROR   | An operator statement must be followed by a single space
 375 | ERROR   | There must be a single space before an operator statement
 375 | ERROR   | No space before comment text; expected "// N�mero de
     |         | columnas en el state (siempre 4)" but found "//N�mero de
     |         | columnas en el state (siempre 4)"
 375 | ERROR   | There must be no blank line following an inline comment
 375 | ERROR   | Comments may not appear after statements.
 377 | ERROR   | The PHP 4-style "var" declaration must not be used.
 377 | ERROR   | An operator statement must be followed by a single space
 377 | ERROR   | There must be a single space before an operator statement
 377 | ERROR   | Whitespace found at end of line
 377 | ERROR   | No space before comment text; expected "// Longitud de la
     |         | clave 128b=>4" but found "//Longitud de la clave 128b=>4"
 377 | ERROR   | There must be no blank line following an inline comment
 377 | ERROR   | Comments may not appear after statements.
 379 | ERROR   | The PHP 4-style "var" declaration must not be used.
 379 | ERROR   | An operator statement must be followed by a single space
 379 | ERROR   | There must be a single space before an operator statement
 381 | ERROR   | The PHP 4-style "var" declaration must not be used.
 381 | ERROR   | Class property $shifts_r should use lowerCamel naming without
     |         | underscores
 381 | ERROR   | An operator statement must be followed by a single space
 381 | ERROR   | There must be a single space before an operator statement
 381 | ERROR   | If the line declaring an array spans longer than 80
     |         | characters, each element should be broken into its own line
 381 | ERROR   | If the line declaring an array spans longer than 80
     |         | characters, each element should be broken into its own line
 383 | ERROR   | The PHP 4-style "var" declaration must not be used.
 383 | ERROR   | Class property $shifts_l should use lowerCamel naming without
     |         | underscores
 383 | ERROR   | An operator statement must be followed by a single space
 383 | ERROR   | There must be a single space before an operator statement
 383 | ERROR   | If the line declaring an array spans longer than 80
     |         | characters, each element should be broken into its own line
 383 | ERROR   | If the line declaring an array spans longer than 80
     |         | characters, each element should be broken into its own line
 385 | ERROR   | The PHP 4-style "var" declaration must not be used.
 385 | ERROR   | An operator statement must be followed by a single space
 385 | ERROR   | There must be a single space before an operator statement
 385 | ERROR   | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
     |         | found "false"
 387 | ERROR   | The PHP 4-style "var" declaration must not be used.
 387 | ERROR   | An operator statement must be followed by a single space
 387 | ERROR   | There must be a single space before an operator statement
 387 | ERROR   | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
     |         | found "false"
 389 | ERROR   | Whitespace found at end of line
 391 | WARNING | Line exceeds 80 characters; contains 82 characters
 391 | ERROR   | No space before comment text; expected "//
     |         | ////////////////////////////////////////////////////////////////////////////"
     |         | but found
     |         | "//////////////////////////////////////////////////////////////////////////////"
 391 | ERROR   | There must be no blank line following an inline comment
 393 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 393 | ERROR   | There must be no blank line following an inline comment
 395 | WARNING | Line exceeds 80 characters; contains 81 characters
 395 | ERROR   | No space before comment text; expected "//
     |         | ///////////////////////////////////////////////////////////////////////////"
     |         | but found
     |         | "/////////////////////////////////////////////////////////////////////////////"
 395 | ERROR   | There must be no blank line following an inline comment
 397 | ERROR   | Whitespace found at end of line
 399 | ERROR   | Whitespace found at end of line
 402 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 404 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 404 | ERROR   | Doc comment for var Array does not match actual variable name
     |         | $rk at position 1
 404 | ERROR   | Parameter comment must be on the next line at position 1
 406 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 408 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 409 | ERROR   | Function doc comment must end on the line before the function
     |         | definition
 411 | WARNING | The use of private methods or properties is strongly
     |         | discouraged, use "protected" instead
 411 | ERROR   | Line indented incorrectly; expected 2 spaces, found 4
 413 | ERROR   | No space before comment text; expected "// Para cada ronda
     |         | hacemos una XOR entre Sbox[i][j] y rk[round][i][j]." but found
     |         | "//Para cada ronda hacemos una XOR entre Sbox[i][j] y
     |         | rk[round][i][j]."
 413 | ERROR   | There must be no blank line following an inline comment
 415 | ERROR   | Inline control structures are not allowed
 417 | ERROR   | Inline control structures are not allowed
 423 | ERROR   | Whitespace found at end of line
 426 | ERROR   | Expected 4 space(s) before asterisk; 0 found
 427 | ERROR   | Expected 4 space(s) before asterisk; 5 found
 428 | ERROR   | Expected 4 space(s) before asterisk; 0 found
 429 | ERROR   | Expected 4 space(s) before asterisk; 5 found
 430 | ERROR   | Expected 4 space(s) before asterisk; 0 found
 431 | ERROR   | Expected 4 space(s) before asterisk; 5 found
 431 | ERROR   | Function doc comment must end on the line before the function
     |         | definition
 431 | ERROR   | Whitespace found at end of line
 433 | WARNING | The use of private methods or properties is strongly
     |         | discouraged, use "protected" instead
 433 | ERROR   | Line indented incorrectly; expected 2 spaces, found 4
 433 | ERROR   | Expected 1 space between the closing parenthesis and the
     |         | opening brace; found 0
 435 | ERROR   | There must be a single space before an operator statement
 437 | ERROR   | Inline control structures are not allowed
 439 | ERROR   | Inline control structures are not allowed
 439 | ERROR   | Whitespace found at end of line
 441 | ERROR   | There must be a single space before an operator statement
 443 | ERROR   | An operator statement must be followed by a single space
 443 | ERROR   | There must be a single space before an operator statement
 447 | ERROR   | Whitespace found at end of line
 450 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 451 | WARNING | Line exceeds 80 characters; contains 84 characters
 452 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 452 | ERROR   | Doc comment for var Array does not match actual variable name
     |         | $rk at position 1
 452 | ERROR   | Parameter comment must be on the next line at position 1
 454 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 456 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 457 | ERROR   | Function doc comment must end on the line before the function
     |         | definition
 459 | WARNING | The use of private methods or properties is strongly
     |         | discouraged, use "protected" instead
 459 | ERROR   | Line indented incorrectly; expected 2 spaces, found 4
 459 | ERROR   | Expected 1 space between the closing parenthesis and the
     |         | opening brace; found 0
 461 | ERROR   | There must be a single space before an operator statement
 463 | ERROR   | Inline control structures are not allowed
 465 | ERROR   | Expected "for (...) {\n"; found "for(...){\n"
 465 | ERROR   | Line indented incorrectly; expected 4 spaces, found 12
 469 | ERROR   | An operator statement must be followed by a single space
 469 | ERROR   | There must be a single space before an operator statement
 477 | ERROR   | Whitespace found at end of line
 480 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 482 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 484 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 485 | ERROR   | Function doc comment must end on the line before the function
     |         | definition
 487 | WARNING | The use of private methods or properties is strongly
     |         | discouraged, use "protected" instead
 487 | ERROR   | Line indented incorrectly; expected 2 spaces, found 4
 489 | ERROR   | There must be a single space before an operator statement
 491 | ERROR   | Inline control structures are not allowed
 493 | ERROR   | Inline control structures are not allowed
 501 | ERROR   | Whitespace found at end of line
 504 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 506 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 508 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 509 | ERROR   | Function doc comment must end on the line before the function
     |         | definition
 509 | ERROR   | Whitespace found at end of line
 511 | WARNING | The use of private methods or properties is strongly
     |         | discouraged, use "protected" instead
 511 | ERROR   | Line indented incorrectly; expected 2 spaces, found 4
 511 | ERROR   | Expected 1 space between the closing parenthesis and the
     |         | opening brace; found 0
 511 | ERROR   | Whitespace found at end of line
 513 | ERROR   | There must be a single space before an operator statement
 515 | ERROR   | Inline control structures are not allowed
 517 | ERROR   | Inline control structures are not allowed
 519 | ERROR   | There must be a single space before an operator statement
 521 | ERROR   | An operator statement must be followed by a single space
 521 | ERROR   | There must be a single space before an operator statement
 523 | ERROR   | Whitespace found at end of line
 525 | ERROR   | Whitespace found at end of line
 527 | ERROR   | Whitespace found at end of line
 529 | ERROR   | No space before comment text; expected "//
     |         | ///////////////////////////////////////////////////////////////////////"
     |         | but found
     |         | "/////////////////////////////////////////////////////////////////////////"
 529 | ERROR   | There must be no blank line following an inline comment
 531 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 531 | ERROR   | There must be no blank line following an inline comment
 533 | ERROR   | No space before comment text; expected "//
     |         | ///////////////////////////////////////////////////////////////////////"
     |         | but found
     |         | "/////////////////////////////////////////////////////////////////////////"
 533 | ERROR   | There must be no blank line following an inline comment
 535 | ERROR   | Whitespace found at end of line
 538 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 540 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 540 | ERROR   | Doc comment for var Si does not match actual variable name
     |         | $hex at position 1
 540 | ERROR   | Parameter comment must be on the next line at position 1
 541 | ERROR   | Doc comment for var Si does not match actual variable name
     |         | $debug at position 2
 541 | ERROR   | Parameter comment must be on the next line at position 2
 542 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 544 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 546 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 547 | ERROR   | Function doc comment must end on the line before the function
     |         | definition
 549 | ERROR   | Line indented incorrectly; expected 2 spaces, found 4
 549 | ERROR   | An operator statement must be followed by a single space
 549 | ERROR   | There must be a single space before an operator statement
 549 | ERROR   | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
     |         | found "false"
 549 | ERROR   | An operator statement must be followed by a single space
 549 | ERROR   | There must be a single space before an operator statement
 549 | ERROR   | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
     |         | found "false"
 549 | ERROR   | Expected 1 space between the closing parenthesis and the
     |         | opening brace; found 0
 551 | ERROR   | An operator statement must be followed by a single space
 551 | ERROR   | There must be a single space before an operator statement
 553 | ERROR   | An operator statement must be followed by a single space
 553 | ERROR   | There must be a single space before an operator statement
 553 | ERROR   | Whitespace found at end of line
 555 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 555 | ERROR   | Closing brace indented incorrectly; expected 4 spaces, found 1
 557 | ERROR   | Whitespace found at end of line
 560 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 562 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 562 | ERROR   | Last parameter comment requires a blank newline after it
 562 | ERROR   | Doc comment for var Clave does not match actual variable name
     |         | $hash at position 1
 562 | ERROR   | Parameter comment must be on the next line at position 1
 563 | ERROR   | Return comment must be on the next line
 564 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 566 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 568 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 569 | ERROR   | Function doc comment must end on the line before the function
     |         | definition
 571 | ERROR   | Line indented incorrectly; expected 2 spaces, found 4
 571 | ERROR   | Expected 1 space between the closing parenthesis and the
     |         | opening brace; found 0
 575 | ERROR   | An operator statement must be followed by a single space
 575 | ERROR   | There must be a single space before an operator statement
 577 | ERROR   | An operator statement must be followed by a single space
 577 | ERROR   | There must be a single space before an operator statement
 579 | ERROR   | Inline control structures are not allowed
 581 | ERROR   | Inline control structures are not allowed
 583 | ERROR   | An operator statement must be followed by a single space
 583 | ERROR   | There must be a single space before an operator statement
 583 | ERROR   | An operator statement must be followed by a single space
 583 | ERROR   | There must be a single space before an operator statement
 583 | ERROR   | An operator statement must be followed by a single space
 583 | ERROR   | There must be a single space before an operator statement
 583 | ERROR   | An operator statement must be followed by a single space
 583 | ERROR   | There must be a single space before an operator statement
 583 | ERROR   | An operator statement must be followed by a single space
 583 | ERROR   | There must be a single space before an operator statement
 583 | ERROR   | An operator statement must be followed by a single space
 583 | ERROR   | There must be a single space before an operator statement
 583 | ERROR   | An operator statement must be followed by a single space
 583 | ERROR   | There must be a single space before an operator statement
 583 | ERROR   | An operator statement must be followed by a single space
 583 | ERROR   | There must be a single space before an operator statement
 587 | ERROR   | Whitespace found at end of line
 589 | ERROR   | Inline control structures are not allowed
 589 | ERROR   | An operator statement must be followed by a single space
 589 | ERROR   | There must be a single space before an operator statement
 589 | ERROR   | An operator statement must be followed by a single space
 589 | ERROR   | There must be a single space before an operator statement
 591 | ERROR   | Inline control structures are not allowed
 595 | ERROR   | Line indented incorrectly; expected 4 spaces, found 8
 595 | ERROR   | An operator statement must be followed by a single space
 595 | ERROR   | There must be a single space before an operator statement
 595 | ERROR   | An operator statement must be followed by a single space
 595 | ERROR   | There must be a single space before an operator statement
 597 | ERROR   | Whitespace found at end of line
 599 | ERROR   | Inline control structures are not allowed
 599 | ERROR   | Whitespace found at end of line
 601 | ERROR   | An operator statement must be followed by a single space
 601 | ERROR   | There must be a single space before an operator statement
 601 | ERROR   | An operator statement must be followed by a single space
 601 | ERROR   | There must be a single space before an operator statement
 601 | ERROR   | An operator statement must be followed by a single space
 601 | ERROR   | There must be a single space before an operator statement
 605 | ERROR   | Inline control structures are not allowed
 607 | ERROR   | Expected "for (...) {\n"; found "for(...){\n"
 607 | ERROR   | Line indented incorrectly; expected 6 spaces, found 16
 609 | ERROR   | An operator statement must be followed by a single space
 609 | ERROR   | There must be a single space before an operator statement
 613 | ERROR   | Inline control structures are not allowed
 613 | ERROR   | An operator statement must be followed by a single space
 613 | ERROR   | There must be a single space before an operator statement
 613 | ERROR   | An operator statement must be followed by a single space
 613 | ERROR   | There must be a single space before an operator statement
 615 | ERROR   | Expected "for (...) {\n"; found "for(...) {\n"
 615 | ERROR   | Line indented incorrectly; expected 6 spaces, found 16
 627 | ERROR   | Whitespace found at end of line
 630 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 632 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 632 | ERROR   | Doc comment for var Datos does not match actual variable name
     |         | $in at position 1
 632 | ERROR   | Parameter comment must be on the next line at position 1
 633 | ERROR   | Last parameter comment requires a blank newline after it
 633 | ERROR   | Doc comment for var Array does not match actual variable name
     |         | $key at position 2
 633 | ERROR   | Parameter comment must be on the next line at position 2
 634 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 634 | ERROR   | Return comment must be on the next line
 636 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 638 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 640 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 641 | ERROR   | Function doc comment must end on the line before the function
     |         | definition
 643 | ERROR   | Line indented incorrectly; expected 2 spaces, found 4
 643 | ERROR   | Expected 1 space between the closing parenthesis and the
     |         | opening brace; found 0
 645 | ERROR   | Whitespace found at end of line
 647 | ERROR   | Expected "for (...) {\n"; found "for (...){\n"
 647 | ERROR   | Line indented incorrectly; expected 4 spaces, found 8
 647 | ERROR   | An operator statement must be followed by a single space
 647 | ERROR   | There must be a single space before an operator statement
 647 | ERROR   | An operator statement must be followed by a single space
 647 | ERROR   | There must be a single space before an operator statement
 649 | ERROR   | Expected "for (...) {\n"; found "for (...){\n"
 649 | ERROR   | Line indented incorrectly; expected 6 spaces, found 12
 649 | ERROR   | An operator statement must be followed by a single space
 649 | ERROR   | There must be a single space before an operator statement
 649 | ERROR   | An operator statement must be followed by a single space
 649 | ERROR   | There must be a single space before an operator statement
 651 | ERROR   | An operator statement must be followed by a single space
 651 | ERROR   | There must be a single space before an operator statement
 651 | ERROR   | An operator statement must be followed by a single space
 651 | ERROR   | There must be a single space before an operator statement
 651 | ERROR   | An operator statement must be followed by a single space
 651 | ERROR   | There must be a single space before an operator statement
 663 | ERROR   | Expected "for (...) {\n"; found "for(...) {\n"
 663 | ERROR   | Line indented incorrectly; expected 4 spaces, found 8
 673 | ERROR   | Closing brace indented incorrectly; expected 8 spaces, found 9
 683 | ERROR   | An operator statement must be followed by a single space
 683 | ERROR   | There must be a single space before an operator statement
 685 | ERROR   | Inline control structures are not allowed
 685 | ERROR   | An operator statement must be followed by a single space
 685 | ERROR   | There must be a single space before an operator statement
 685 | ERROR   | An operator statement must be followed by a single space
 685 | ERROR   | There must be a single space before an operator statement
 687 | ERROR   | Inline control structures are not allowed
 687 | ERROR   | An operator statement must be followed by a single space
 687 | ERROR   | There must be a single space before an operator statement
 687 | ERROR   | An operator statement must be followed by a single space
 687 | ERROR   | There must be a single space before an operator statement
 689 | ERROR   | An operator statement must be followed by a single space
 689 | ERROR   | There must be a single space before an operator statement
 691 | ERROR   | Expected "if (...) {\n"; found "if(...){\n"
 691 | ERROR   | Line indented incorrectly; expected 4 spaces, found 8
 693 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 693 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 4
 693 | ERROR   | An operator statement must be followed by a single space
 693 | ERROR   | There must be a single space before an operator statement
 695 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 695 | ERROR   | Closing brace indented incorrectly; expected 8 spaces, found 2
 695 | ERROR   | Whitespace found at end of line
 701 | ERROR   | Whitespace found at end of line
 704 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 706 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 706 | ERROR   | Doc comment for var Datos does not match actual variable name
     |         | $in at position 1
 706 | ERROR   | Parameter comment must be on the next line at position 1
 707 | ERROR   | Last parameter comment requires a blank newline after it
 707 | ERROR   | Doc comment for var Array does not match actual variable name
     |         | $key at position 2
 707 | ERROR   | Parameter comment must be on the next line at position 2
 708 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 708 | ERROR   | Return comment must be on the next line
 710 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 712 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 714 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 715 | ERROR   | Function doc comment must end on the line before the function
     |         | definition
 717 | ERROR   | Line indented incorrectly; expected 2 spaces, found 4
 719 | ERROR   | Whitespace found at end of line
 721 | ERROR   | Expected "for (...) {\n"; found "for (...){\n"
 721 | ERROR   | Line indented incorrectly; expected 4 spaces, found 8
 721 | ERROR   | An operator statement must be followed by a single space
 721 | ERROR   | There must be a single space before an operator statement
 721 | ERROR   | An operator statement must be followed by a single space
 721 | ERROR   | There must be a single space before an operator statement
 723 | ERROR   | Expected "for (...) {\n"; found "for (...){\n"
 723 | ERROR   | Line indented incorrectly; expected 6 spaces, found 12
 723 | ERROR   | An operator statement must be followed by a single space
 723 | ERROR   | There must be a single space before an operator statement
 723 | ERROR   | An operator statement must be followed by a single space
 723 | ERROR   | There must be a single space before an operator statement
 725 | ERROR   | An operator statement must be followed by a single space
 725 | ERROR   | There must be a single space before an operator statement
 725 | ERROR   | An operator statement must be followed by a single space
 725 | ERROR   | There must be a single space before an operator statement
 725 | ERROR   | An operator statement must be followed by a single space
 725 | ERROR   | There must be a single space before an operator statement
 731 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 731 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 2
 731 | ERROR   | Whitespace found at end of line
 737 | ERROR   | Expected "for (...) {\n"; found "for(...) {\n"
 737 | ERROR   | Line indented incorrectly; expected 4 spaces, found 8
 737 | ERROR   | An operator statement must be followed by a single space
 737 | ERROR   | There must be a single space before an operator statement
 741 | ERROR   | Concat operator must be surrounded by spaces
 741 | ERROR   | Concat operator must be surrounded by spaces
 745 | ERROR   | Concat operator must be surrounded by spaces
 745 | ERROR   | Concat operator must be surrounded by spaces
 749 | ERROR   | Concat operator must be surrounded by spaces
 749 | ERROR   | Concat operator must be surrounded by spaces
 751 | ERROR   | Closing brace indented incorrectly; expected 8 spaces, found 9
 753 | ERROR   | Whitespace found at end of line
 755 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 755 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 2
 755 | ERROR   | Whitespace found at end of line
 761 | ERROR   | An operator statement must be followed by a single space
 761 | ERROR   | There must be a single space before an operator statement
 763 | ERROR   | Inline control structures are not allowed
 763 | ERROR   | An operator statement must be followed by a single space
 763 | ERROR   | There must be a single space before an operator statement
 763 | ERROR   | An operator statement must be followed by a single space
 763 | ERROR   | There must be a single space before an operator statement
 765 | ERROR   | Inline control structures are not allowed
 765 | ERROR   | An operator statement must be followed by a single space
 765 | ERROR   | There must be a single space before an operator statement
 765 | ERROR   | An operator statement must be followed by a single space
 765 | ERROR   | There must be a single space before an operator statement
 767 | ERROR   | An operator statement must be followed by a single space
 767 | ERROR   | There must be a single space before an operator statement
 767 | ERROR   | Whitespace found at end of line
 769 | ERROR   | Expected "if (...) {\n"; found "if(...){\n"
 769 | ERROR   | Line indented incorrectly; expected 4 spaces, found 8
 771 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 771 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 4
 771 | ERROR   | An operator statement must be followed by a single space
 771 | ERROR   | There must be a single space before an operator statement
 773 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 773 | ERROR   | Closing brace indented incorrectly; expected 8 spaces, found 2
 773 | ERROR   | Whitespace found at end of line
 779 | ERROR   | Whitespace found at end of line
 781 | ERROR   | Whitespace found at end of line
 783 | ERROR   | Whitespace found at end of line
 785 | ERROR   | No space before comment text; expected "//
     |         | //////////////////////////////////////////////////////////////////////"
     |         | but found
     |         | "////////////////////////////////////////////////////////////////////////"
 785 | ERROR   | There must be no blank line following an inline comment
 787 | ERROR   | No space before comment text; expected "// Funcion de test"
     |         | but found "//Funcion de test"
 787 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 787 | ERROR   | There must be no blank line following an inline comment
 789 | ERROR   | No space before comment text; expected "//
     |         | //////////////////////////////////////////////////////////////////////"
     |         | but found
     |         | "////////////////////////////////////////////////////////////////////////"
 789 | ERROR   | There must be no blank line following an inline comment
 791 | ERROR   | Whitespace found at end of line
 794 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 796 | ERROR   | Whitespace found at end of line
 797 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 799 | ERROR   | Expected 5 space(s) before asterisk; 0 found
 800 | ERROR   | Function doc comment must end on the line before the function
     |         | definition
 802 | ERROR   | Public method name "AES128::self_test" is not in lowerCamel
     |         | format, it must not contain underscores
 802 | ERROR   | Line indented incorrectly; expected 2 spaces, found 4
 802 | ERROR   | Expected 1 space between the closing parenthesis and the
     |         | opening brace; found 0
 804 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 804 | ERROR   | An operator statement must be followed by a single space
 804 | ERROR   | There must be a single space before an operator statement
 806 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 806 | ERROR   | An operator statement must be followed by a single space
 806 | ERROR   | There must be a single space before an operator statement
 808 | ERROR   | Expected "for (...) {\n"; found "for (...){\n"
 808 | ERROR   | Line indented incorrectly; expected 4 spaces, found 12
 811 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 811 | ERROR   | Closing brace indented incorrectly; expected 12 spaces, found
     |         | 5
 811 | ERROR   | Whitespace found at end of line
 814 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 815 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 816 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 817 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 818 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 819 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 820 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 821 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 822 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 823 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 824 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 825 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 826 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 827 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 828 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 830 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 834 | ERROR   | Concat operator must be surrounded by spaces
 834 | ERROR   | Concat operator must be surrounded by spaces
 836 | ERROR   | Concat operator must be surrounded by spaces
 836 | ERROR   | Concat operator must be surrounded by spaces
 838 | ERROR   | Whitespace found at end of line
 842 | ERROR   | An operator statement must be followed by a single space
 844 | ERROR   | Concat operator must be surrounded by spaces
 844 | ERROR   | Concat operator must be surrounded by spaces
 847 | ERROR   | More than 2 empty lines are not allowed
 850 | ERROR   | Concat operator must be surrounded by spaces
 850 | ERROR   | Concat operator must be surrounded by spaces
 852 | ERROR   | Expected "if (...) {\n"; found "if(...){\n"
 852 | ERROR   | Line indented incorrectly; expected 4 spaces, found 12
 852 | ERROR   | No space found after comma in function call
 853 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 853 | ERROR   | Expected "if (...) {\n"; found "if(...){\n"
 853 | ERROR   | Line indented incorrectly; expected 6 spaces, found 2
 855 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 855 | ERROR   | An operator statement must be followed by a single space
 855 | ERROR   | There must be a single space before an operator statement
 855 | ERROR   | TRUE, FALSE and NULL must be uppercase; expected "TRUE" but
     |         | found "true"
 855 | ERROR   | Whitespace found at end of line
 857 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 857 | ERROR   | Expected "for (...) {\n"; found "for(...){\n"
 857 | ERROR   | Line indented incorrectly; expected 8 spaces, found 14
 857 | ERROR   | An operator statement must be followed by a single space
 857 | ERROR   | There must be a single space before an operator statement
 857 | ERROR   | An operator statement must be followed by a single space
 857 | ERROR   | There must be a single space before an operator statement
 859 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 859 | ERROR   | An operator statement must be followed by a single space
 861 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 861 | ERROR   | Closing brace indented incorrectly; expected 14 spaces, found
     |         | 10
 863 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 863 | ERROR   | An operator statement must be followed by a single space
 863 | ERROR   | There must be a single space before an operator statement
 863 | ERROR   | TRUE, FALSE and NULL must be uppercase; expected "TRUE" but
     |         | found "true"
 863 | ERROR   | An operator statement must be followed by a single space
 863 | ERROR   | There must be a single space before an operator statement
 863 | ERROR   | An operator statement must be followed by a single space
 863 | ERROR   | There must be a single space before an operator statement
 865 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 865 | ERROR   | Concat operator must be surrounded by spaces
 865 | ERROR   | Concat operator must be surrounded by spaces
 866 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 868 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 870 | ERROR   | Inline control structures are not allowed
 870 | ERROR   | else must start on a new line
 872 | ERROR   | Closing brace indented incorrectly; expected 4 spaces, found 0
 874 | ERROR   | Whitespace found at end of line
 876 | ERROR   | No space before comment text; expected "//
     |         | /////////////////////////////////////////////////////////////////////"
     |         | but found
     |         | "///////////////////////////////////////////////////////////////////////"
 876 | ERROR   | There must be no blank line following an inline comment
 878 | ERROR   | No space before comment text; expected "// Funciones
     |         | auxiliares" but found "//Funciones auxiliares"
 878 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 878 | ERROR   | There must be no blank line following an inline comment
 880 | ERROR   | No space before comment text; expected "//
     |         | ////////////////////////////////////////////////////////////////////"
     |         | but found
     |         | "//////////////////////////////////////////////////////////////////////"
 880 | ERROR   | There must be no blank line following an inline comment
 882 | ERROR   | Whitespace found at end of line
 884 | WARNING | The use of private methods or properties is strongly
     |         | discouraged, use "protected" instead
 884 | ERROR   | You must use "/**" style comments for a function comment
 884 | ERROR   | Line indented incorrectly; expected 2 spaces, found 4
 886 | ERROR   | An operator statement must be followed by a single space
 886 | ERROR   | There must be a single space before an operator statement
 888 | ERROR   | Expected "for (...) {\n"; found "for (...){\n"
 888 | ERROR   | Line indented incorrectly; expected 4 spaces, found 6
 888 | ERROR   | An operator statement must be followed by a single space
 888 | ERROR   | There must be a single space before an operator statement
 888 | ERROR   | An operator statement must be followed by a single space
 888 | ERROR   | There must be a single space before an operator statement
 890 | ERROR   | An operator statement must be followed by a single space
 890 | ERROR   | There must be a single space before an operator statement
 890 | ERROR   | Whitespace found at end of line
 892 | ERROR   | Inline control structures are not allowed
 892 | ERROR   | There must be a single space before an operator statement
 892 | ERROR   | An operator statement must be followed by a single space
 892 | ERROR   | There must be a single space before an operator statement
 892 | ERROR   | Concat operator must be surrounded by spaces
 894 | ERROR   | An operator statement must be followed by a single space
 894 | ERROR   | There must be a single space before an operator statement
 896 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 896 | ERROR   | Closing brace indented incorrectly; expected 6 spaces, found 3
 898 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 898 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 3
 900 | ERROR   | Whitespace found at end of line
 902 | ERROR   | Whitespace found at end of line
 904 | WARNING | The use of private methods or properties is strongly
     |         | discouraged, use "protected" instead
 904 | ERROR   | Missing function doc comment
 904 | ERROR   | Line indented incorrectly; expected 2 spaces, found 4
 904 | ERROR   | Expected 1 space between the closing parenthesis and the
     |         | opening brace; found 0
 906 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 906 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 3
 906 | ERROR   | An operator statement must be followed by a single space
 906 | ERROR   | There must be a single space before an operator statement
 908 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 908 | ERROR   | Expected "for (...) {\n"; found "for(...){\n"
 908 | ERROR   | Line indented incorrectly; expected 4 spaces, found 3
 908 | ERROR   | An operator statement must be followed by a single space
 908 | ERROR   | There must be a single space before an operator statement
 908 | ERROR   | An operator statement must be followed by a single space
 908 | ERROR   | There must be a single space before an operator statement
 908 | ERROR   | An operator statement must be followed by a single space
 908 | ERROR   | There must be a single space before an operator statement
 908 | ERROR   | There must be a single space before an operator statement
 910 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 910 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 5
 910 | ERROR   | An operator statement must be followed by a single space
 910 | ERROR   | There must be a single space before an operator statement
 912 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 912 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 5
 912 | ERROR   | An operator statement must be followed by a single space
 912 | ERROR   | There must be a single space before an operator statement
 914 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 916 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 916 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 3
 918 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 918 | ERROR   | Closing brace indented incorrectly; expected 4 spaces, found 1
 920 | ERROR   | Whitespace found at end of line
 920 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 922 | ERROR   | Whitespace found at end of line
 922 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 924 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 924 | WARNING | The use of private methods or properties is strongly
     |         | discouraged, use "protected" instead
 924 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 924 | ERROR   | Missing function doc comment
 924 | ERROR   | Line indented incorrectly; expected 2 spaces, found 1
 924 | ERROR   | Expected 1 space between the closing parenthesis and the
     |         | opening brace; found 0
 926 | ERROR   | Expected "if (...) {\n"; found "if(...){\n"
 926 | ERROR   | Line indented incorrectly; expected 4 spaces, found 6
 928 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 928 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 3
 928 | ERROR   | Concat operator must be surrounded by spaces
 930 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 930 | ERROR   | Expected "for (...) {\n"; found "for(...){\n"
 930 | ERROR   | Line indented incorrectly; expected 6 spaces, found 3
 930 | ERROR   | An operator statement must be followed by a single space
 930 | ERROR   | There must be a single space before an operator statement
 930 | ERROR   | An operator statement must be followed by a single space
 930 | ERROR   | There must be a single space before an operator statement
 932 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 932 | ERROR   | Expected "for (...) {\n"; found "for(...){\n"
 932 | ERROR   | Line indented incorrectly; expected 8 spaces, found 5
 932 | ERROR   | An operator statement must be followed by a single space
 932 | ERROR   | There must be a single space before an operator statement
 932 | ERROR   | An operator statement must be followed by a single space
 932 | ERROR   | There must be a single space before an operator statement
 934 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 934 | ERROR   | Line indented incorrectly; expected at least 10 spaces, found
     |         | 4
 934 | ERROR   | Concat operator must be surrounded by spaces
 936 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 936 | ERROR   | Closing brace indented incorrectly; expected 5 spaces, found 2
 938 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 940 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 940 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 3
 942 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 942 | ERROR   | Closing brace indented incorrectly; expected 6 spaces, found 3
 944 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 944 | ERROR   | Whitespace found at end of line
 948 | ERROR   | Files must end in a single new line character
 948 | ERROR   | The final ?> should be omitted from all code files
--------------------------------------------------------------------------------


FILE: .../pareview_temp/test_candidate/modules/sap_soapclient/sap_soapclient.inc
--------------------------------------------------------------------------------
FOUND 46 ERROR(S) AND 3 WARNING(S) AFFECTING 31 LINE(S)
--------------------------------------------------------------------------------
 14 | ERROR   | Inline comments must start with a capital letter
 14 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
    |         | question marks
 15 | WARNING | The use of private methods or properties is strongly
    |         | discouraged, use "protected" instead
 16 | WARNING | The use of private methods or properties is strongly
    |         | discouraged, use "protected" instead
 17 | WARNING | The use of private methods or properties is strongly
    |         | discouraged, use "protected" instead
 18 | ERROR   | Whitespace found at end of line
 19 | ERROR   | You must use "/**" style comments for a function comment
 24 | ERROR   | Missing function doc comment
 24 | ERROR   | There should be no white space after an opening "{"
 24 | ERROR   | There should be no white space before a closing "}"
 27 | ERROR   | Expected 3 space(s) before asterisk; 2 found
 28 | ERROR   | Expected 3 space(s) before asterisk; 2 found
 29 | ERROR   | Expected 3 space(s) before asterisk; 2 found
 29 | ERROR   | Whitespace found at end of line
 30 | ERROR   | Expected 3 space(s) before asterisk; 2 found
 30 | ERROR   | Missing parameter type at position 1
 31 | ERROR   | Expected 3 space(s) before asterisk; 2 found
 32 | ERROR   | Expected 3 space(s) before asterisk; 2 found
 32 | ERROR   | Whitespace found at end of line
 33 | ERROR   | Expected 3 space(s) before asterisk; 2 found
 33 | ERROR   | Missing parameter type at position 2
 34 | ERROR   | Expected 3 space(s) before asterisk; 2 found
 35 | ERROR   | Expected 3 space(s) before asterisk; 2 found
 35 | ERROR   | Whitespace found at end of line
 36 | ERROR   | Expected 3 space(s) before asterisk; 2 found
 36 | ERROR   | Data type of return value is missing
 37 | ERROR   | Expected 3 space(s) before asterisk; 2 found
 38 | ERROR   | Expected 3 space(s) before asterisk; 2 found
 39 | ERROR   | Expected 3 space(s) before asterisk; 2 found
 40 | ERROR   | Expected 3 space(s) before asterisk; 2 found
 46 | ERROR   | Whitespace found at end of line
 47 | ERROR   | Inline comments must start with a capital letter
 47 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
    |         | question marks
 48 | ERROR   | There should be no white space after an opening "("
 48 | ERROR   | There should be no white space before a closing ")"
 52 | ERROR   | Whitespace found at end of line
 55 | ERROR   | There should be no white space after an opening "("
 55 | ERROR   | There should be no white space before a closing ")"
 60 | ERROR   | There should be no white space after an opening "("
 60 | ERROR   | There should be no white space before a closing ")"
 72 | ERROR   | There should be no white space after an opening "("
 72 | ERROR   | There should be no white space before a closing ")"
 73 | ERROR   | There should be no white space after an opening "("
 73 | ERROR   | There should be no white space before a closing ")"
 79 | ERROR   | There should be no white space after an opening "("
 79 | ERROR   | A unary operator statement must not be followed by a space
 79 | ERROR   | There should be no white space before a closing ")"
 85 | ERROR   | Inline comments must start with a capital letter
 85 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
    |         | question marks
--------------------------------------------------------------------------------


FILE: ...pareview_temp/test_candidate/modules/sap_soapclient/sap_soapclient.info
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 2 | ERROR | Use XHTML style <br /> tags instead of <br>
 6 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...eview_temp/test_candidate/modules/sap_soapclient/sap_soapclient.install
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AND 2 WARNING(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
  9 | WARNING | Format should be "* Implements hook_foo()." or "Implements
    |         | hook_foo_BAR_ID_bar() for xyz_bar()."
 16 | WARNING | Format should be "* Implements hook_foo()." or "Implements
    |         | hook_foo_BAR_ID_bar() for xyz_bar()."
 28 | ERROR   | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...review_temp/test_candidate/modules/sap_soapclient/sap_soapclient.module
--------------------------------------------------------------------------------
FOUND 194 ERROR(S) AND 9 WARNING(S) AFFECTING 129 LINE(S)
--------------------------------------------------------------------------------
  11 | WARNING | Format should be "* Implements hook_foo()." or "Implements
     |         | hook_foo_BAR_ID_bar() for xyz_bar()."
  20 | ERROR   | Whitespace found at end of line
  21 | ERROR   | There should be no white space after an opening "("
  21 | ERROR   | A unary operator statement must not be followed by a space
  21 | ERROR   | There should be no white space before a closing ")"
  22 | ERROR   | Inline comments must start with a capital letter
  22 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
  23 | ERROR   | There should be no white space after an opening "("
  23 | ERROR   | There should be no white space after an opening "("
  23 | ERROR   | There should be no white space before a closing ")"
  23 | ERROR   | There should be no white space before a closing ")"
  24 | ERROR   | There should be no white space after an opening "("
  24 | ERROR   | A unary operator statement must not be followed by a space
  24 | ERROR   | There should be no white space before a closing ")"
  25 | ERROR   | Inline comments must start with a capital letter
  26 | ERROR   | "require_once" is a statement not a function; no parentheses
     |         | are required
  31 | ERROR   | Whitespace found at end of line
  36 | WARNING | Format should be "* Implements hook_foo()." or "Implements
     |         | hook_foo_BAR_ID_bar() for xyz_bar()."
  40 | ERROR   | Whitespace found at end of line
  41 | ERROR   | There should be no white space after an opening "("
  41 | ERROR   | There should be no white space before a closing ")"
  48 | WARNING | Format should be "* Implements hook_foo()." or "Implements
     |         | hook_foo_BAR_ID_bar() for xyz_bar()."
  65 | ERROR   | Missing function doc comment
  66 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
  89 | ERROR   | Concatenating translatable strings is not allowed, use
     |         | placeholders instead and only one string literal
  89 | ERROR   | Concat operator must be surrounded by spaces
  99 | ERROR   | Concatenating translatable strings is not allowed, use
     |         | placeholders instead and only one string literal
  99 | ERROR   | Concat operator must be surrounded by spaces
 109 | ERROR   | Concatenating translatable strings is not allowed, use
     |         | placeholders instead and only one string literal
 109 | ERROR   | Concat operator must be surrounded by spaces
 119 | ERROR   | Concatenating translatable strings is not allowed, use
     |         | placeholders instead and only one string literal
 119 | ERROR   | Concat operator must be surrounded by spaces
 129 | ERROR   | Concatenating translatable strings is not allowed, use
     |         | placeholders instead and only one string literal
 129 | ERROR   | Concat operator must be surrounded by spaces
 130 | ERROR   | Concat operator must be surrounded by spaces
 140 | ERROR   | Concatenating translatable strings is not allowed, use
     |         | placeholders instead and only one string literal
 140 | ERROR   | Concat operator must be surrounded by spaces
 141 | ERROR   | Concat operator must be surrounded by spaces
 151 | WARNING | Avoid backslash escaping in translatable strings when
     |         | possible, use "" quotes instead
 151 | ERROR   | Concatenating translatable strings is not allowed, use
     |         | placeholders instead and only one string literal
 151 | ERROR   | Concat operator must be surrounded by spaces
 170 | ERROR   | Missing parameter type at position 1
 174 | ERROR   | Missing parameter type at position 2
 174 | ERROR   | Parameter comment must be on the next line at position 2
 177 | ERROR   | Doc comment for var $use_wsdl does not match actual variable
     |         | name $password at position 3
 177 | ERROR   | Missing parameter type at position 3
 181 | ERROR   | Doc comment for var $options does not match actual variable
     |         | name $use_wsdl at position 4
 181 | ERROR   | Missing parameter type at position 4
 204 | ERROR   | Data type of return value is missing
 213 | ERROR   | Whitespace found at end of line
 215 | ERROR   | Whitespace found at end of line
 216 | ERROR   | There should be no white space after an opening "("
 216 | ERROR   | There should be no white space before a closing ")"
 221 | ERROR   | Inline comments must start with a capital letter
 221 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 222 | ERROR   | There should be no white space after an opening "("
 222 | ERROR   | A unary operator statement must not be followed by a space
 222 | ERROR   | There should be no white space before a closing ")"
 226 | ERROR   | Whitespace found at end of line
 227 | ERROR   | There should be no white space after an opening "("
 227 | ERROR   | A unary operator statement must not be followed by a space
 227 | ERROR   | There should be no white space before a closing ")"
 233 | ERROR   | Whitespace found at end of line
 235 | ERROR   | Inline control structures are not allowed
 237 | ERROR   | Inline control structures are not allowed
 239 | ERROR   | Inline control structures are not allowed
 241 | ERROR   | Inline control structures are not allowed
 243 | ERROR   | No space before comment text; expected "// Checks for correct
     |         | nuSOAP configuration. Check if library is configured." but
     |         | found "//Checks for correct nuSOAP configuration. Check if
     |         | library is configured."
 245 | ERROR   | Constants must be uppercase; expected NUSOAP_LOCATION but
     |         | found nusoap_location
 245 | ERROR   | There should be no white space before a closing ")"
 250 | ERROR   | No space before comment text; expected "// Check if library is
     |         | really there" but found "//Check if library is really there"
 250 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 251 | ERROR   | There should be no white space after an opening "("
 251 | ERROR   | There should be no white space before a closing ")"
 252 | ERROR   | There should be no white space before a closing ")"
 256 | ERROR   | No space before comment text; expected "// Load required
     |         | library and cache classes." but found "//Load required library
     |         | and cache classes."
 257 | ERROR   | "require_once" is a statement not a function; no parentheses
     |         | are required
 258 | ERROR   | "require_once" is a statement not a function; no parentheses
     |         | are required
 260 | ERROR   | No space before comment text; expected "// prepare parameters
     |         | for initialisation" but found "//prepare parameters for
     |         | initialisation"
 260 | ERROR   | Inline comments must start with a capital letter
 260 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 264 | ERROR   | There should be no white space after an opening "("
 264 | ERROR   | There should be no white space before a closing ")"
 264 | ERROR   | Whitespace found at end of line
 265 | ERROR   | Inline comments must start with a capital letter
 265 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 269 | ERROR   | There should be no white space after an opening "("
 269 | ERROR   | There should be no white space before a closing ")"
 270 | ERROR   | Inline comments must start with a capital letter
 270 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 274 | ERROR   | Whitespace found at end of line
 278 | ERROR   | No space before comment text; expected "// Old style, using
     |         | modified nusoap client as up to" but found "//Old style, using
     |         | modified nusoap client as up to"
 278 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 283 | ERROR   | No space before comment text; expected "// This should be the
     |         | new nusoap client as downloaded from sf." but found "//This
     |         | should be the new nusoap client as downloaded from sf."
 288 | WARNING | Line exceeds 80 characters; contains 99 characters
 288 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 292 | ERROR   | There should be no white space after an opening "("
 292 | ERROR   | A unary operator statement must not be followed by a space
 292 | ERROR   | There should be no white space before a closing ")"
 296 | ERROR   | No space before comment text; expected "// Load the SoapClient
     |         | class definition" but found "//Load the SoapClient class
     |         | definition"
 296 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 299 | ERROR   | Whitespace found at end of line
 306 | ERROR   | Missing parameter type at position 1
 307 | ERROR   | Parameter comment indentation must be 2 additional spaces at
     |         | position 1
 309 | ERROR   | Missing parameter type at position 2
 310 | ERROR   | Parameter comment indentation must be 2 additional spaces at
     |         | position 2
 312 | ERROR   | Missing parameter type at position 3
 313 | ERROR   | Parameter comment indentation must be 2 additional spaces at
     |         | position 3
 316 | ERROR   | Data type of return value is missing
 317 | ERROR   | Return comment indentation must be 2 additional spaces
 322 | ERROR   | Whitespace found at end of line
 323 | ERROR   | There should be no white space after an opening "("
 323 | ERROR   | There should be no white space before a closing ")"
 326 | ERROR   | Whitespace found at end of line
 327 | ERROR   | There should be no white space after an opening "("
 327 | ERROR   | There should be no white space before a closing ")"
 333 | ERROR   | Whitespace found at end of line
 334 | WARNING | Line exceeds 80 characters; contains 103 characters
 334 | ERROR   | Inline comments must start with a capital letter
 334 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 334 | ERROR   | There must be no blank line following an inline comment
 334 | ERROR   | Comments may not appear after statements.
 335 | ERROR   | Whitespace found at end of line
 338 | ERROR   | Inline comments must start with a capital letter
 338 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 339 | ERROR   | There should be no white space after an opening "("
 339 | ERROR   | There should be no white space before a closing ")"
 342 | ERROR   | There should be no white space after an opening "("
 342 | ERROR   | There should be no white space before a closing ")"
 346 | ERROR   | Whitespace found at end of line
 347 | ERROR   | Whitespace found at end of line
 349 | ERROR   | Whitespace found at end of line
 351 | ERROR   | Whitespace found at end of line
 357 | ERROR   | Missing parameter type at position 1
 358 | ERROR   | Parameter comment indentation must be 2 additional spaces at
     |         | position 1
 360 | ERROR   | Missing parameter type at position 2
 361 | ERROR   | Parameter comment indentation must be 2 additional spaces at
     |         | position 2
 363 | ERROR   | Missing parameter type at position 3
 364 | ERROR   | Parameter comment indentation must be 2 additional spaces at
     |         | position 3
 367 | ERROR   | Data type of return value is missing
 368 | ERROR   | Return comment indentation must be 2 additional spaces
 373 | ERROR   | Whitespace found at end of line
 374 | ERROR   | There should be no white space after an opening "("
 374 | ERROR   | There should be no white space before a closing ")"
 377 | ERROR   | Whitespace found at end of line
 378 | ERROR   | There should be no white space after an opening "("
 378 | ERROR   | There should be no white space before a closing ")"
 382 | ERROR   | Whitespace found at end of line
 383 | ERROR   | There should be no white space after an opening "("
 383 | ERROR   | There should be no white space before a closing ")"
 386 | ERROR   | Whitespace found at end of line
 390 | WARNING | Line exceeds 80 characters; contains 103 characters
 390 | ERROR   | Inline comments must start with a capital letter
 390 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 390 | ERROR   | There must be no blank line following an inline comment
 390 | ERROR   | Comments may not appear after statements.
 394 | ERROR   | Whitespace found at end of line
 395 | ERROR   | There should be no white space after an opening "("
 395 | ERROR   | There should be no white space before a closing ")"
 398 | ERROR   | There should be no white space after an opening "("
 398 | ERROR   | There should be no white space before a closing ")"
 410 | ERROR   | Whitespace found at end of line
 410 | ERROR   | There must be an empty line before the parameter block
 410 | ERROR   | Missing parameter type at position 1
 410 | ERROR   | Missing comment for param "$str" at position 1
 412 | ERROR   | Data type of return value is missing
 413 | ERROR   | Return comment indentation must be 2 additional spaces
 417 | ERROR   | Variable "xmlClass" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 417 | ERROR   | Calling class constructors must always include parentheses
 418 | ERROR   | Whitespace found at end of line
 419 | ERROR   | Inline comments must start with a capital letter
 419 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 420 | ERROR   | Variable "xmlClass" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 421 | ERROR   | Variable "xmlArray" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 421 | ERROR   | Variable "xmlClass" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 422 | ERROR   | Whitespace found at end of line
 423 | ERROR   | Variable "xmlArray" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 428 | ERROR   | Whitespace found at end of line
 431 | ERROR   | Class name must use UpperCamel naming without underscores
 432 | ERROR   | The PHP 4-style "var" declaration must not be used.
 433 | ERROR   | The PHP 4-style "var" declaration must not be used.
 433 | ERROR   | Class property $arr_output should use lowerCamel naming
     |         | without underscores
 434 | ERROR   | The PHP 4-style "var" declaration must not be used.
 434 | ERROR   | Class property $null_token should use lowerCamel naming
     |         | without underscores
 436 | ERROR   | Missing function doc comment
 445 | WARNING | A comma should follow the last multiline array item. Found: ''
 446 | WARNING | A comma should follow the last multiline array item. Found: )
 466 | ERROR   | Missing function doc comment
 466 | ERROR   | Method name "XML_Unserializer::get_unserialized_data" is not
     |         | in lowerCamel format, it must not contain underscores
 470 | ERROR   | Missing function doc comment
 470 | ERROR   | Method name "XML_Unserializer::build_array" is not in
     |         | lowerCamel format, it must not contain underscores
 479 | ERROR   | No space before comment text; expected "//
     |         | krumo($stack['children']);" but found
     |         | "//krumo($stack['children']);"
 489 | ERROR   | Inline comments must start with a capital letter
 489 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 496 | ERROR   | Inline comments must start with a capital letter
 496 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 519 | ERROR   | You must use "/**" style comments for a function comment
 519 | ERROR   | Method name "XML_Unserializer::start_handler" is not in
     |         | lowerCamel format, it must not contain underscores
 528 | ERROR   | Missing function doc comment
 528 | ERROR   | Method name "XML_Unserializer::end_handler" is not in
     |         | lowerCamel format, it must not contain underscores
 533 | ERROR   | Missing function doc comment
 533 | ERROR   | Method name "XML_Unserializer::data_handler" is not in
     |         | lowerCamel format, it must not contain underscores
 538 | ERROR   | Missing function doc comment
--------------------------------------------------------------------------------


FILE: ...areview/sites/all/modules/pareview_temp/test_candidate/sap_hr.admin.inc
--------------------------------------------------------------------------------
FOUND 43 ERROR(S) AND 6 WARNING(S) AFFECTING 42 LINE(S)
--------------------------------------------------------------------------------
   6 | ERROR   | Additional blank line found at the end of doc comment
  14 | ERROR   | Data type of return value is missing
  21 | ERROR   | Use XHTML style <br /> tags instead of <br>
  26 | ERROR   | Inline comments must start with a capital letter
  34 | ERROR   | Inline comments must start with a capital letter
  50 | ERROR   | Additional blank line found at the end of doc comment
  64 | ERROR   | Missing function doc comment
  73 | ERROR   | Inline comments must start with a capital letter
  85 | ERROR   | Inline comments must start with a capital letter
  93 | ERROR   | Inline comments must start with a capital letter
 101 | ERROR   | Whitespace found at end of line
 101 | ERROR   | Inline comments must start with a capital letter
 114 | ERROR   | You must use "/**" style comments for a function comment
 123 | ERROR   | Inline comments must start with a capital letter
 135 | ERROR   | Inline comments must start with a capital letter
 143 | ERROR   | Inline comments must start with a capital letter
 151 | WARNING | Line exceeds 80 characters; contains 99 characters
 151 | ERROR   | Inline comments must start with a capital letter
 163 | ERROR   | You must use "/**" style comments for a function comment
 172 | ERROR   | Inline comments must start with a capital letter
 184 | ERROR   | Inline comments must start with a capital letter
 192 | ERROR   | Inline comments must start with a capital letter
 200 | WARNING | Line exceeds 80 characters; contains 99 characters
 200 | ERROR   | Inline comments must start with a capital letter
 212 | ERROR   | You must use "/**" style comments for a function comment
 221 | ERROR   | Inline comments must start with a capital letter
 233 | ERROR   | Inline comments must start with a capital letter
 241 | ERROR   | Inline comments must start with a capital letter
 249 | WARNING | Line exceeds 80 characters; contains 99 characters
 249 | ERROR   | Inline comments must start with a capital letter
 261 | ERROR   | You must use "/**" style comments for a function comment
 270 | ERROR   | Inline comments must start with a capital letter
 282 | ERROR   | Inline comments must start with a capital letter
 290 | ERROR   | Inline comments must start with a capital letter
 298 | WARNING | Line exceeds 80 characters; contains 99 characters
 298 | ERROR   | Inline comments must start with a capital letter
 310 | ERROR   | You must use "/**" style comments for a function comment
 319 | ERROR   | Inline comments must start with a capital letter
 331 | ERROR   | Inline comments must start with a capital letter
 339 | ERROR   | Inline comments must start with a capital letter
 347 | WARNING | Line exceeds 80 characters; contains 99 characters
 347 | ERROR   | Inline comments must start with a capital letter
 359 | ERROR   | You must use "/**" style comments for a function comment
 368 | ERROR   | Inline comments must start with a capital letter
 380 | ERROR   | Inline comments must start with a capital letter
 388 | ERROR   | Inline comments must start with a capital letter
 396 | WARNING | Line exceeds 80 characters; contains 99 characters
 396 | ERROR   | Inline comments must start with a capital letter
 406 | ERROR   | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...l-7-pareview/sites/all/modules/pareview_temp/test_candidate/sap_hr.info
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 10 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...-pareview/sites/all/modules/pareview_temp/test_candidate/sap_hr.install
--------------------------------------------------------------------------------
FOUND 8 ERROR(S) AND 2 WARNING(S) AFFECTING 10 LINE(S)
--------------------------------------------------------------------------------
   1 | ERROR   | End of line character is invalid; expected "\n" but found
     |         | "\r\n"
   6 | ERROR   | File doc comments must be followed by a blank line.
   8 | WARNING | Format should be "* Implements hook_foo()." or "Implements
     |         | hook_foo_BAR_ID_bar() for xyz_bar()."
  11 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
  16 | ERROR   | Whitespace found at end of line
  32 | ERROR   | Whitespace found at end of line
 100 | ERROR   | Whitespace found at end of line
 154 | WARNING | Format should be "* Implements hook_foo()." or "Implements
     |         | hook_foo_BAR_ID_bar() for xyz_bar()."
 161 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 199 | ERROR   | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...7-pareview/sites/all/modules/pareview_temp/test_candidate/sap_hr.module
--------------------------------------------------------------------------------
FOUND 81 ERROR(S) AND 11 WARNING(S) AFFECTING 73 LINE(S)
--------------------------------------------------------------------------------
   8 | ERROR   | Missing function doc comment
  16 | WARNING | Format should be "* Implements hook_foo()." or "Implements
     |         | hook_foo_BAR_ID_bar() for xyz_bar()."
 182 | ERROR   | Whitespace found at end of line
 186 | ERROR   | Inline control structures are not allowed
 187 | ERROR   | Use XHTML style <br /> tags instead of <br>
 187 | ERROR   | Whitespace found at end of line
 188 | ERROR   | Use XHTML style <br /> tags instead of <br>
 195 | ERROR   | Whitespace found at end of line
 199 | ERROR   | Inline control structures are not allowed
 200 | ERROR   | Use XHTML style <br /> tags instead of <br>
 200 | WARNING | Line exceeds 80 characters; contains 151 characters
 200 | ERROR   | No space before comment text; expected "//
     |         | .'<br>'.getManagerInformation($sap_employee_id);" but found
     |         | "//.'<br>'.getManagerInformation($sap_employee_id);"
 200 | ERROR   | Comments may not appear after statements.
 201 | ERROR   | No space before comment text; expected "// $emp_info =
     |         | $emp_info.'<br>'.getLeaveRequests($sap_employee_id);" but
     |         | found "//$emp_info =
     |         | $emp_info.'<br>'.getLeaveRequests($sap_employee_id);"
 205 | ERROR   | You must use "/**" style comments for a function comment
 206 | ERROR   | Inline control structures are not allowed
 211 | ERROR   | Missing function doc comment
 215 | ERROR   | Missing function doc comment
 219 | ERROR   | Missing function doc comment
 225 | ERROR   | Inline control structures are not allowed
 227 | ERROR   | Inline control structures are not allowed
 231 | ERROR   | Missing function doc comment
 242 | ERROR   | Whitespace found at end of line
 243 | ERROR   | Array indentation error, expected 6 spaces but found 32
 243 | ERROR   | Concat operator must be surrounded by spaces
 254 | ERROR   | Missing function doc comment
 268 | ERROR   | If the line declaring an array spans longer than 80
     |         | characters, each element should be broken into its own line
 276 | ERROR   | Missing function doc comment
 287 | ERROR   | If the line declaring an array spans longer than 80
     |         | characters, each element should be broken into its own line
 292 | ERROR   | Whitespace found at end of line
 293 | ERROR   | Array indentation error, expected 10 spaces but found 28
 294 | ERROR   | Array indentation error, expected 10 spaces but found 28
 295 | ERROR   | Array indentation error, expected 10 spaces but found 28
 296 | ERROR   | Array indentation error, expected 10 spaces but found 28
 297 | ERROR   | Array indentation error, expected 10 spaces but found 28
 298 | ERROR   | Array indentation error, expected 10 spaces but found 28
 299 | ERROR   | Array indentation error, expected 10 spaces but found 28
 300 | ERROR   | Array indentation error, expected 10 spaces but found 28
 301 | ERROR   | Array indentation error, expected 10 spaces but found 28
 302 | ERROR   | Array indentation error, expected 10 spaces but found 28
 311 | ERROR   | Missing function doc comment
 327 | ERROR   | Missing function doc comment
 336 | WARNING | Line exceeds 80 characters; contains 175 characters
 336 | ERROR   | No space before comment text; expected "// $header =
     |         | array('Processing Period', 'Deduction Period', 'Entitlement',
     |         | 'Current Used', 'Approved', 'Requested', 'Planned', 'Current
     |         | Remaining', 'Remaining', 'Available');" but found "//$header =
     |         | array('Processing Period', 'Deduction Period', 'Entitlement',
     |         | 'Current Used', 'Approved', 'Requested', 'Planned', 'Current
     |         | Remaining', 'Remaining', 'Available');"
 337 | ERROR   | If the line declaring an array spans longer than 80
     |         | characters, each element should be broken into its own line
 339 | ERROR   | Whitespace found at end of line
 341 | ERROR   | Whitespace found at end of line
 343 | ERROR   | Whitespace found at end of line
 344 | ERROR   | Whitespace found at end of line
 345 | ERROR   | Whitespace found at end of line
 346 | WARNING | Line exceeds 80 characters; contains 126 characters
 346 | ERROR   | Whitespace found at end of line
 346 | ERROR   | No space before comment text; expected "//
     |         | $vacation_balance_org_arr0['12']['quantity'],
     |         | $vacation_balance_org_arr0['13']['quantity']," but found
     |         | "//$vacation_balance_org_arr0['12']['quantity'],
     |         | $vacation_balance_org_arr0['13']['quantity'],"
 347 | WARNING | A comma should follow the last multiline array item. Found: ]
 347 | ERROR   | There should be no white space before a closing ")"
 349 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 4
 351 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 4
 351 | ERROR   | Whitespace found at end of line
 353 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 4
 353 | ERROR   | Whitespace found at end of line
 354 | ERROR   | Whitespace found at end of line
 355 | ERROR   | Whitespace found at end of line
 356 | WARNING | Line exceeds 80 characters; contains 126 characters
 356 | ERROR   | Whitespace found at end of line
 356 | ERROR   | No space before comment text; expected "//
     |         | $vacation_balance_org_arr1['12']['quantity'],
     |         | $vacation_balance_org_arr1['13']['quantity']," but found
     |         | "//$vacation_balance_org_arr1['12']['quantity'],
     |         | $vacation_balance_org_arr1['13']['quantity'],"
 357 | WARNING | A comma should follow the last multiline array item. Found: ]
 357 | ERROR   | There should be no white space before a closing ")"
 365 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 366 | ERROR   | You must use "/**" style comments for a function comment
 378 | WARNING | Line exceeds 80 characters; contains 93 characters
 379 | ERROR   | Inline comments must end in  full-stops, exclamation marks, or
     |         | question marks
 389 | ERROR   | Whitespace found at end of line
 393 | ERROR   | Whitespace found at end of line
 394 | ERROR   | Whitespace found at end of line
 396 | ERROR   | Whitespace found at end of line
 397 | ERROR   | There should be no white space after an opening "("
 397 | ERROR   | There should be no white space before a closing ")"
 404 | ERROR   | No space before comment text; expected "// $result =
     |         | $result['#return']->call($form['function']['#value'], $args);"
     |         | but found "//$result =
     |         | $result['#return']->call($form['function']['#value'], $args);"
 405 | WARNING | Line exceeds 80 characters; contains 106 characters
 405 | ERROR   | No space before comment text; expected "// $return_val =
     |         | sap_soapclient_parse_xml_result($client->responseData)['#return']['SOAP-ENV:ENVELOPE'];;"
     |         | but found "//$return_val =
     |         | sap_soapclient_parse_xml_result($client->responseData)['#return']['SOAP-ENV:ENVELOPE'];;"
 410 | ERROR   | You must use "/**" style comments for a function comment
 419 | WARNING | Line exceeds 80 characters; contains 92 characters
 419 | ERROR   | No space before comment text; expected "//
     |         | $replaced_request_xml = str_replace("1000",
     |         | strval($sap_employee_id), $org_request_xml);" but found
     |         | "//$replaced_request_xml = str_replace("1000",
     |         | strval($sap_employee_id), $org_request_xml);"
 429 | ERROR   | Whitespace found at end of line
 433 | ERROR   | Whitespace found at end of line
 434 | ERROR   | Whitespace found at end of line
 436 | ERROR   | Whitespace found at end of line
 437 | ERROR   | There should be no white space after an opening "("
 437 | ERROR   | There should be no white space before a closing ")"
 444 | ERROR   | No space before comment text; expected "// $result =
     |         | $result['#return']->call($form['function']['#value'], $args);"
     |         | but found "//$result =
     |         | $result['#return']->call($form['function']['#value'], $args);"
 445 | WARNING | Line exceeds 80 characters; contains 106 characters
 445 | ERROR   | No space before comment text; expected "// $return_val =
     |         | sap_soapclient_parse_xml_result($client->responseData)['#return']['SOAP-ENV:ENVELOPE'];;"
     |         | but found "//$return_val =
     |         | sap_soapclient_parse_xml_result($client->responseData)['#return']['SOAP-ENV:ENVELOPE'];;"
--------------------------------------------------------------------------------


FILE: ...pareview/sites/all/modules/pareview_temp/test_candidate/sap_hr.user.inc
--------------------------------------------------------------------------------
FOUND 17 ERROR(S) AND 3 WARNING(S) AFFECTING 15 LINE(S)
--------------------------------------------------------------------------------
  13 | ERROR   | Data type of return value is missing
  17 | WARNING | Line exceeds 80 characters; contains 93 characters
  17 | ERROR   | Whitespace found at end of line
  17 | ERROR   | Inline comments must start with a capital letter
  36 | ERROR   | Whitespace found at end of line
  59 | ERROR   | You must use "/**" style comments for a function comment
  70 | ERROR   | Inline control structures are not allowed
  72 | ERROR   | Whitespace found at end of line
  76 | ERROR   | Missing function doc comment
  88 | WARNING | Line exceeds 80 characters; contains 92 characters
  88 | ERROR   | No space before comment text; expected "//
     |         | $replaced_request_xml = str_replace("1000",
     |         | strval($sap_employee_id), $org_request_xml);" but found
     |         | "//$replaced_request_xml = str_replace("1000",
     |         | strval($sap_employee_id), $org_request_xml);"
 110 | ERROR   | Whitespace found at end of line
 114 | ERROR   | Whitespace found at end of line
 115 | ERROR   | Whitespace found at end of line
 117 | ERROR   | Whitespace found at end of line
 118 | ERROR   | There should be no white space after an opening "("
 118 | ERROR   | There should be no white space before a closing ")"
 125 | ERROR   | No space before comment text; expected "// $result =
     |         | $result['#return']->call($form['function']['#value'], $args);"
     |         | but found "//$result =
     |         | $result['#return']->call($form['function']['#value'], $args);"
 126 | WARNING | Line exceeds 80 characters; contains 106 characters
 126 | ERROR   | No space before comment text; expected "// $return_val =
     |         | sap_soapclient_parse_xml_result($client->responseData)['#return']['SOAP-ENV:ENVELOPE'];;"
     |         | but found "//$return_val =
     |         | sap_soapclient_parse_xml_result($client->responseData)['#return']['SOAP-ENV:ENVELOPE'];;"
--------------------------------------------------------------------------------

Source: http://ventral.org/pareview - PAReview.sh online service

novalnet’s picture

Hi,

README.TXT is missing .
1.Remove the ?> delimiter at end of file.
2.all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming

function sap_soapclient_init() {
function sap_soapclient_exit($destination = NULL) {
function sap_soapclient_menu() {
function sap_soapclient_admin_settings() {
function sap_soapclient_init_client($endpoint, $username = '', $password = '', $use_wsdl = TRUE, $options = array()) {
function sap_soapclient_encrypt($plain, $key, $iv = 'password') {
function sap_soapclient_decrypt($cipher, $key, $iv = 'password') {
function sap_xml_parser_string_to_array($str) {
function xml_serialize($tagname, $data) {

3. In sap_soapclient.install,
Format should be "* Implements hook_foo()." or "Implements hook_foo_BAR_ID_bar() for xyz_bar()."

4. You should PARREVIEW your script. You have many errors.
See http://ventral.org/pareview/httpgitdrupalorgsandboxbpadhu1333838git.

klausi’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

tassaf’s picture

use SAPRFC library,, it will give you the ability to integrate SAP with DRUPAL
http://tassaf.moriamedia.com/drupal-with-sap-integration/