Hi
This is a module to integrate Drupal and SAP Enterprise Services specifically SAP HR (HCM) services. The modules takes 2 scenario - 1) Get each employee information (including direct reports, vacation balance, manager, etc) from the backend SAP and the 2) Apply for vacation and the manager can approve the vacation request.
The module is available for Drupal 6, and going forward would also be available for Drupal 7. The code is installed and running at http://www.10jumps.com/demo/sap_drupal/, all the use cases available as links at the top.
The project page http://drupal.org/sandbox/bpadhu/1333838 explains in detail about the installation, what to expect and the roadmap for this module.
Module name: SAP HR Integration
Target Version: Drupal 6
Thanks and best regards
Padhu
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | bpadhu_errors.txt | 205.57 KB | novalnet |
Comments
Comment #1
patrickd commentedIf you want to get reviewed you have to set "needs review" status.
Comment #2
eugene.ilyin commentedHello. I spent manual review of your module.
No Leave Requests
'); - don't put tags in t() function. Use concat.
If you have functions with names sap_hr_create_leave_request_user and sap_hr_create_leave_request_user_submit, this line is not need. Form API call it automatically.
Comment #3
eugene.ilyin commentedComment #4
bpadhu commentedHi
I have fixed all the issues based on your review. Please continue the review and let me know if I need to do any more changes.
Thanks and best regards
Padhu
Comment #5
eugene.ilyin commentedReview by pareview script. You have many errors.
See http://ventral.org/pareview/httpgitdrupalorgsandboxbpadhu1333838git.
Comment #6
patrickd commented@ilyin.eugene
please use
<code>tags, and attach such large reports as txt file in futureComment #7
eugene.ilyin commentedSorry. Fixed.
Comment #8
novalnet commentedIt appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.
Source: http://ventral.org/pareview - PAReview.sh online service
Comment #9
novalnet commentedHi,
README.TXT is missing .
1.Remove the ?> delimiter at end of file.
2.all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
function sap_soapclient_init() {
function sap_soapclient_exit($destination = NULL) {
function sap_soapclient_menu() {
function sap_soapclient_admin_settings() {
function sap_soapclient_init_client($endpoint, $username = '', $password = '', $use_wsdl = TRUE, $options = array()) {
function sap_soapclient_encrypt($plain, $key, $iv = 'password') {
function sap_soapclient_decrypt($cipher, $key, $iv = 'password') {
function sap_xml_parser_string_to_array($str) {
function xml_serialize($tagname, $data) {
3. In sap_soapclient.install,
Format should be "* Implements hook_foo()." or "Implements hook_foo_BAR_ID_bar() for xyz_bar()."
4. You should PARREVIEW your script. You have many errors.
See http://ventral.org/pareview/httpgitdrupalorgsandboxbpadhu1333838git.
Comment #10
klausiClosing due to lack of activity. Feel free to reopen if you are still working on this application.
Comment #11
tassaf commenteduse SAPRFC library,, it will give you the ability to integrate SAP with DRUPAL
http://tassaf.moriamedia.com/drupal-with-sap-integration/