Link module code have some collission with Drupal coding standards. We have to review the code with coder module and resolve found problems.

CommentFileSizeAuthor
#1 coder-review-1418464-1.patch64.6 KBrvilar

Comments

rvilar’s picture

rvilar
Primary language Catalan
Location Montcada i Reixac, Catalonia
commented
StatusFileSize
new coder-review-1418464-1.patch64.6 KB

I attach a patch with coder review.

rvilar’s picture

rvilar
Primary language Catalan
Location Montcada i Reixac, Catalonia
commented
Status: Active » Needs review

Changing state for code review

rvilar’s picture

rvilar
Primary language Catalan
Location Montcada i Reixac, Catalonia
commented
Assigned: rvilar » Unassigned

Unassigning me this issue

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented

thanks rvilar.

sadly the patch doesn't apply no more, because some of it was already done by other patches.

Since I like rather like you did it (splitting coding standarts from other issues) sadly also other patches already have changed some of it already. Please be so kind and reroll the patch for left overs.

Thanks in advance.
rvilar++

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Status: Needs review » Fixed

hm ... was looking thru' it but most of it is already done
... so I mark the issue as fixed.

Feel free to re-open if you still found some bits you think are worth opening it again ;-)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.