There is a problem with the string:

t('The link title is limited to '.$settings['title_maxlength'].' characters maximum.')

It don't use variable replacement in t() function and makes not possible to translate this string.

CommentFileSizeAuthor
#1 variable-t-1418674-1.patch928 bytesrvilar

Comments

rvilar’s picture

rvilar
Primary language Catalan
Location Montcada i Reixac, Catalonia
commented
Assigned: rvilar » Unassigned
Status: Active » Needs review
StatusFileSize
new variable-t-1418674-1.patch928 bytes

I attach a patch that solves this problem

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Priority: Major » Normal
Status: Needs review » Reviewed & tested by the community

rerolled and fitted to latest --dev from 13. Feb. 2012
(why waiting for such a simple task ... ) reviewed, tested, committed and pushed to HEAD

thanks rvilar for report and patch!
rvilar++

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Status: Reviewed & tested by the community » Fixed
rvilar’s picture

rvilar
Primary language Catalan
Location Montcada i Reixac, Catalonia
commented

@Digidog: Thanks to patch your module. Please consider authoring the patch to the real author like the code conduit suggest

http://drupal.org/node/1146430

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented

I know the standarts, but thanks for informing me, rvilar. Since I am a very cherishing/valueing person, it really hurts me that I missed the chance to give another credit to you (and also to somebody else in the last days), especially when they obviously are hit by that and take care about that so much.

But sadly, I had to catch up with the link issue queue over the last nights and had to go thru' 3-4 critical and major issues, while I'd rather have a lot of work to do here with my REAL job. I am not a developer but try to contribute to the Drupal community by co-maintaining and helping out on the link module as much as I can. There is nothing here on d.o. I can promote myself from for my real work, so what I do here has no other purpose than helping. Maybe that's why (and maybe also because of that it was only half a line changed) I was a little brushing over that here in the rush of other issues to take care of.

But please allow me another note: Just to inform back: this module isn't MY module, it is a community module, and many -including me - are contributing to this module without any credit. Especially the module author, who isn't me (but jcfiala) and who has done and is still doing an awesome job without taking care about his promotion on this.

But as I sad in the beginning. I am heartfelt sorry for this.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.