When specifying link title as optional, I think that is an improvement that we can specify a default title using the Static title field in the settings page.

Comments

rvilar’s picture

Assigned: rvilar » Unassigned
Status: Active » Needs review
StatusFileSize
new1.6 KB

Attaching a patch that solves this feature request.

randyhook’s picture

Status: Needs review » Reviewed & tested by the community

The patch works great for me.

I was a little confused with the patch's wording beneath the Static text field:

This title will always be used if "Static Title" is selected above or like a default title if "Optional title" is selected above.

And wonder if it should be changed to:

This title will 1) always be used if "Static Title" is selected above or 2) used if "Optional title" is selected above and no title is entered when creating content.

jcfiala’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Needs work

I'm willing to apply this ticket, but it no longer applies cleanly to the link module. Any chance you can do a quick fixup for me?

num37’s picture

StatusFileSize
new2.65 KB

I came across this issue when looking for exactly this behavior. I've re-rolled the patch, applied randyhook's suggestion in #2, and added some text of my own to the title field's description as seen on a node add/edit form. The new description text shows up if the title is set to optional and a static/default title has been defined, like so:
The link title is limited to @maxlength characters maximum. If blank, "%default" will be used by default.
This is my first patch contribution, so fingers crossed...

num37’s picture

Status: Needs work » Needs review

The last submitted patch, 1: link-default-title-1418762-1.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 4: link-default-title-1418762-4.patch, failed testing.

num37’s picture

Status: Needs work » Needs review

As far as I can tell, none of the failed tests had anything to do with the patch I uploaded, so I think the patch itself is still worth reviewing. If I've done something wrong, let me know!

renatog’s picture

Assigned: Unassigned » renatog
Issue tags: +ciandt-contrib
StatusFileSize
new1.38 KB

Hi people. Thank you very much.

I applied the new patch and works good for me.

@num37, your patch is ok. It was only necessary to re-roll your patch. (In attachment)

Thank you very much for contribution.

Good Work and Good Week.

Regards.

renatog’s picture

Status: Needs review » Reviewed & tested by the community

  • RenatoG committed 1830a00 on 7.x-1.x
    Issue #1418762 by num37, RenatoG, rvilar, jcfiala, randyhook: Provide...
renatog’s picture

Status: Reviewed & tested by the community » Fixed

Fixed.

Commited in dev branch.

Thanks people.

Regards.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.