Two designs attached for inclusion in Commons. I've tried to keep this as redesign as simple as possible, knowing that we can always do more later.

The primary page is the Content page. This shows the group's content in reverse chronological order. Exposed filters allow people to filter content by keyword, author and content type. I've decided against calling out any particular content type, but I am assuming that admins can configure the View to show tabs filtered to a particular content type, should they wish.

This approach eliminates the 'hunt and peck' where currently, you click on a tab on a group page to see not only what it contains, but if it contains anything at all! I suppose the 'By term' 'Edit' and 'Feeds' tabs will also be represented in this same area.

The second page is the activity stream.

Note that

  • Leave group should be themed as a link and positioned lower right (otherwise, it looks like it's a primary CTA on the group page!)
  • avatars are larger than they are currently.
  • All avatars should have a 1px border in #EEEEEE throughout the site (this is in case their avatar has a white background, it doesn't look like a weird disembodied head)
  • Would love it if group description could be limited to xxx characters, with a read more link. This description pushes dynamic content really far down. Alternatively (or additionally), would love if the group description appears as an About tab (so we'd have Content, Group Activity, and About), but I suspect that is beyond the scope of this redesign.
  • Bookmarked Content is just the content you've bookmarked within the group
  • The group member s block layout / spacing is currently kinda odd; but low priority

PS The background on these screens are missing part of the image. Pay no attention to the background :)

Comments

ezra-g’s picture

One thing occurred to me about the design here: It looks like the content is sorted by post-date descending, but this wont make sense for event nodes since people typically want to sort by event date.

Any recommendations for a light weight ux friendly solution here that fits with the current design :)?

stargazer1sd’s picture

If we're going to include events, we probably want to exclude events in the past.

lightsurge’s picture

It looks from the screenshots that this will close issue #1305168: Make Group Menu Display on all Nodes belonging to a group (edit: actually on second thoughts, won't make any difference really, there'll still be little besides the breadcrumbs that remind us we're reading content within a group when viewing a node)

On #2 http://drupal.org/project/views_or would solve this problem, I'm using it exactly for that type of scenario. Problem is, some people might want to see old events.

lisarex’s picture

I've got upcoming events as a sidebar block, since they have additional, more important dates compared to the average node.

Does it make sense to move the Events block up higher on the page? (And if there are no events upcoming, the block could either be hidden or show empty text; I guess empty text is better. I'll be sure to do more research around this for D7...

This content list is meant to be an inventory of all the posted content within a group, since there's been a lot of feedback on "I can't find content in my group" so I wouldn't want to exclude any published content, but as a separate issue, events that have passed could include additional information that makes it clear the event is in the past.

lisarex’s picture

To clarify, the event nodes should also display the event dates so there is no question when the event is happening

ezra-g’s picture

Status: Needs review » Needs work

Marking as "needs work" based on the in-progress patch at #1426616: Group home page improvement, which, is marked as a dupe.

ezra-g’s picture

StatusFileSize
new45 KB

Here's a patch that continues from laurentc's earlier patch.

Changes:

- Set the 'content' tab name via the existing commons_core_set_node_tab_title() callback
- Intercept node/%node/nid via Views argument and 404 if the argument doesn't validate as a group content type
- Related context changes to get consistent blocks on these pages.

Based on discussions with lisarex today, it's ok to leave the Q & A and Events tabs in place.

Laurentc pointed out that the group description in the comp is currently in a part of the page (between the node title and tabs) that we can't target. We probably need to define a new variable via preprocess for inclusion in page.tpl.php to print the group description there, or ay13 suggested that we could define a new page region and place the group description eg via context.

lisarex’s picture

As for the group description, can we truncate them and provide a read more link? (I'm guessing that's more work than we ant to do, but thought I'd ask) Groups with really long descriptions are just going to push everything useful too far down the page.

ezra-g’s picture

StatusFileSize
new54.32 KB

Here's a revised approach that uses context to place the main group content listing View. In my testing this also sets the correct FBSS context for the group activity stream.

The main view here still needs some text improvements (remove blog from title and empty text).

laurentc’s picture

There is still the "Page not found" when viewing content with this patch.

lightsurge’s picture

Don't know what we have going on with the hashes in here, is that really normal?

-        'commons_core-group_members' => array(
-          'module' => 'commons_core',
-          'delta' => 'group_members',
+        'views-24dcb59a56254e5a470ee2f23590eed2' => array(
+          'module' => 'views',
+          'delta' => '24dcb59a56254e5a470ee2f23590eed2',
           'region' => 'sidebar_last',
           'weight' => 1,
ezra-g’s picture

laurentc resolved the comment in #10 as an artifact in his local environment from previous versions of the patch.

@lightsurge: Those appear to be uuids - I'm not as familiar with Context exports as other exportables, but those block deltas appear to be accepted on fresh installs in our testing.

This patch removes themes/commons_roots/views-exposed-form.tpl.php , which hard-coded a collapsed fieldset around exposed Views filter blocks, making the fieldset impossible to expand by default through the Form API.

Some next steps in addition to those in #9 about empty text:

- Make the exposed filter elements display on the same line
- Display the group description above the tabs (unless lisarex feels that it looks good below the tabs)
- Provide an upgrade path and default for new Commons installs for our altered FBSS Context configuration. Note: FBSS implements its own context system that is separate from the Context module and is not exportable. To export the settings necessary for proper placement of the group activity stream per the comp, we need to export the FBSS-specific OG context, via something similar to:

  $data = facebook_status_all_contexts();
  $fbss_og_context = $data['og'];
  $fbss_og_context['context'] = 'group-home-status-box';
  $fbss_og_context['visibility'] = 3;
  drupal_write_record('facebook_status_contexts', $fbss_og_context, 'type');
ezra-g’s picture

StatusFileSize
new57.36 KB
laurentc’s picture

StatusFileSize
new64.02 KB

Patch update. Improvement of group content filter and group sidebar blocs

ezra-g’s picture

StatusFileSize
new98.64 KB

Thanks for the improvements here.

To help me with context switching between this and #1411684: New homepage for authenticated users, I'm posting a screenshot a group homepage with the patch from #14.

It seems like the To Dos from #12 remain.

in progress group homepage

laurentc’s picture

There was a missing file in patch. I've added the theme file to 6.x-2.x. The patch will work for filters but there are the following todos:
- Display the group description above the tabs (unless lisarex feels that it looks good below the tabs)
- Provide an upgrade path and default for new Commons installs for our altered FBSS Context configuration.

ezra-g’s picture

StatusFileSize
new59.53 KB

I reverted the commit referenced in #16 (http://drupalcode.org/project/commons.git/commit/ee9059e) and added the new file to the attached patch.

ezra-g’s picture

We've been working on this at http://drupal.org/sandbox/ezrag/1432998.

I think the remaining tasks are:

- Verify the upgrade process

- Preprocess:
--Update the preprocess code to check the $node->body and if it's not set, use $node->og_mission instead.
-- Make sure to properly sanitize the output (currently is suceptible to cross-site scripting)
-- Ideally move to commons_origins template.php since this is specific to that theme, rather than commons_core.module.

- Change "Group activity" tab menu title to match group title per the comp
- Set the breadcrumb for the group pages to Home=> Community => Group directory
-Theme the "Recent content" block - For me it looks like https://skitch.com/ezra-g/g963x/our-community-c2
- Visual highlighting of the group description per the comp

lisarex’s picture

Looking good! So glad the filters will be visible! A lot of people missed them, since they were collapsed by default.

I'm assuming the tabs will also be themed to match the comp?

As for Breadcrumbs on Group pages, I think they should be Home => Community, but on subpages e.g. a wiki page would be Home=> Community => [group name]

ezra-g’s picture

Status: Needs work » Needs review
StatusFileSize
new110.98 KB

Here's the latest patch from the sandbox group-homepage branch. Doing a test deployment shortly to verify for upgrading sites.

ezra-g’s picture

StatusFileSize
new125.18 KB

Here's the latest from our sandbox dev branch. I plan to commit this shortly.

ezra-g’s picture

StatusFileSize
new125.93 KB

Re-rolled with the --binary flag.

ezra-g’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

fix grammar