Posted by oc on December 10, 2004 at 7:45pm
6 followers
Jump to:
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | user interface text |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (duplicate) |
Issue Summary
The attachments block at the bottom of a page I am editing says:
Note: changes made to the attachments are not permanent until you save this post.
This is ambiguous and confusing. Sounds like it is talking about changes to my attachments (images) themselves. And saving the post-- many users will think that the preview button saves the post.
A much better wording would be:
Note: if adding or deleting an attachment you must click on the "submit" button rather than the "preview" button to commit your change.
I can probably make this change if others can confirm that the new wording would be accurate.
Comments
#1
there isn't any preview or submit button in simple.module
#2
I can't agree more. Moving to Drupal issue queue.
#3
This isn't a bug.
#4
I don't know if this sentence is even necessary- I think that 'Saving' is an expected user action after making any change to a node.
If anything is needed, it would be modeled after the asterisk and notification that comes up on the blocks page when a change is made to a block.
#5
6.x and prior versions are string-frozen.
#6
I agree that it's almost unnecessary, but not quite self-evident, and I like the idea of a dynamic warning appearing when changes are made in the attachment panel.
The text on the Blocks page is: "The changes to these blocks will not be saved until the Save blocks button is clicked." (Which in same manner, then, might also be considered vague: it's not "changes to the blocks," themselves, but rather to their order in and assignment to a region.)
For the text in question, how about:
"Attachments will not be added or deleted until the Save button is clicked."
?
Calling the content being published a "post" (as in, "until you save this post") might be avoided, as that might not make sense for certain custom content types.
A couple alternatives: "Attachments will only be added or deleted when the Save button is clicked."
or "Attachment additions/deletions will only take effect when the Save button is clicked."
#7
Fixed in #391330: File Field for Core which removed Upload module to replace it with File Field for core.