When $conditions is empty, search_data() results in "The Apache Solr search engine is not available" (but results are returned)

Hi Nick, thanks for the response. I didn't offer a suggestion or patch because I don't know enough about the architecture of this module, or search in general, to know the proper way to address this.

Either of the options you suggest seems reasonable to me. For a default set of conditions, it looks like there is a function on line 819, apachesolr_search_conditions_default(), that could fit the bill.

function apachesolr_search_search_results($keys = NULL, $conditions = NULL, $search_page = NULL) {
  if (empty($search_page)) {
    $search_page = apachesolr_search_page_load('core_search');
  }
  if (empty($conditions)) {
    $conditions = apachesolr_search_conditions_default($search_page);
  }
  // Check our parameters
  if (empty($conditions) || empty($search_page)) {
    apachesolr_failure(t('Solr search'), $keys);
  }

Do you think this would work and not break anything else?

If you'd like me to roll a patch with this change, I'll be glad to do so. Let me know.

Thanks,
Paul

Thank you, Nick. Patch attached.

Nick, thank you! This patch applies cleanly for me, the code makes sense, and it works fine. I don't know why the testbot is choking on it. I can only assume there's something wrong with the testbot.

I'll click the re-test link and see if it passes this time.

#7: 1419290-7.patch queued for re-testing.