Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
28 Jan 2012 at 04:43 UTC
Updated:
18 Mar 2013 at 09:43 UTC
Jump to comment: Most recent file
Comments
Comment #1
klausiGet a review bonus and we will come back to your application sooner.
Comment #2
morgothz commentedIt appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.
Comment #3
auworks commentedI have made changes to my code as per documentation. Can you please grant me a full GIT access so I can publish my project.
Comment #4
auworks commentedComment #5
auworks commentedComment #6
klausiNot critical as defined in the application priorities on http://drupal.org/node/894256
Comment #7
auworks commentedThanks mate.
Comment #8
Mithrandir commentedWhere is the logic of this module defined?
I am not very familiar with Ubercart and I think you could explain a little more thorough in e.g. README.txt that this module is a payment method for that module - it may be apparent for some that "uc_" means ubercart, but it wasn't for me.
Additionally, what does this module actually do? It adds a payment method that completes a checkout on submit... Am I missing some Ubercart magic in that I cannot really see where the actual payment is done?
Comment #9
luxpaparazzi commentedBased on the project page, I have no idea what this project is for, it's critical you read the following:
'title' => t('Phone: ') . '<img style="position:relative; top:5px;" src="/' . drupal_get_path('module', 'uc_phone') . '/phone.gif" />',Consider putting this into a theme-function or into a theme file.
You should also add the git-url to the application page (http://git.drupal.org/sandbox/ashishupadhayay/1419366.git)!
The response time for a review is now approaching 4 weeks.
Get a review bonus and we will come back to your application sooner.
See: http://drupal.org/node/1410826
You could for example start by evaluatating my own project:
http://drupal.org/node/1302786
It's a good advice not insulting project reviewers as with "Thanks mate." when someone changes the priority to what it ought to be.
Comment #10
luxpaparazzi commentedforgot status change
Comment #11
klausiClosing due to lack of activity. Feel free to reopen if you are still working on this application.
Comment #12
auworks commentedHi luxpaparazzi,
It wasn't an insult but I was trying to thank you for pointing me in the right direction. I am really sorry if I offended you.
Cheers,
Ashish