This module allows users to checkout without supplying credit card details.

http://drupal.org/sandbox/ashishupadhayay/1419366

Drupal 6.x

CommentFileSizeAuthor
#2 drupalcs-result-1419502.txt1.9 KBmorgothz

Comments

klausi’s picture

Category: feature » task
Status: Active » Needs review

Get a review bonus and we will come back to your application sooner.

morgothz’s picture

Status: Needs review » Needs work
StatusFileSize
new1.9 KB

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

auworks’s picture

Assigned: Unassigned » auworks

I have made changes to my code as per documentation. Can you please grant me a full GIT access so I can publish my project.

auworks’s picture

Status: Needs work » Needs review
auworks’s picture

Assigned: auworks » Unassigned
Priority: Normal » Critical
klausi’s picture

Priority: Critical » Normal

Not critical as defined in the application priorities on http://drupal.org/node/894256

auworks’s picture

Thanks mate.

Mithrandir’s picture

Where is the logic of this module defined?

I am not very familiar with Ubercart and I think you could explain a little more thorough in e.g. README.txt that this module is a payment method for that module - it may be apparent for some that "uc_" means ubercart, but it wasn't for me.
Additionally, what does this module actually do? It adds a payment method that completes a checkout on submit... Am I missing some Ubercart magic in that I cannot really see where the actual payment is done?

luxpaparazzi’s picture

Based on the project page, I have no idea what this project is for, it's critical you read the following:

project page
Please take a moment to make your project page follow tips for a great project page.

'title' => t('Phone: ') . '<img style="position:relative; top:5px;" src="/' . drupal_get_path('module', 'uc_phone') . '/phone.gif" />',
Consider putting this into a theme-function or into a theme file.

You should also add the git-url to the application page (http://git.drupal.org/sandbox/ashishupadhayay/1419366.git)!

The response time for a review is now approaching 4 weeks.
Get a review bonus and we will come back to your application sooner.
See: http://drupal.org/node/1410826

You could for example start by evaluatating my own project:
http://drupal.org/node/1302786

Code too short
This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project.

It's a good advice not insulting project reviewers as with "Thanks mate." when someone changes the priority to what it ought to be.

luxpaparazzi’s picture

Status: Needs review » Needs work

forgot status change

klausi’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

auworks’s picture

Hi luxpaparazzi,

It wasn't an insult but I was trying to thank you for pointing me in the right direction. I am really sorry if I offended you.

Cheers,
Ashish