Add a hook to inject variables into js file [#1419562]

Currently, it seems like the module does not allow us to embed our own variables as implied in the Javascript configuration variabledocs. I was wondering if it would be viable to incorporate a hook to, in the meantime, provide us with this capability on the code level (simply by overwriting the initial array).

Usage:

/**
 * Implements hook_change_disqus_thread
 */
function foo_change_disqus_thread($disqus) {
  return array(
    'url' => 'http://www.example.com,
    'identifier' => 123,
    'title' => 'Hello World,
    'domain' => $disqus['domain'],
  );
}

Comment	File	Size	Author
#5	disqus-n1419562-5.patch	1.19 KB	damienmckenna
#5	disqus-n1419562-5.interdiff.txt	1.19 KB	damienmckenna
#2	disqus-add_alter_hook_js_variables-1419562-2.patch	479 bytes	skruf
#1	disqus_javascript_variable_hook.patch	560 bytes	pcho
	disqus_javascript_variable_hook.patch	494 bytes	pcho

Comments

Comment #1

pcho commented 28 January 2012 at 09:19

Status	File	Size
new	disqus_javascript_variable_hook.patch	560 bytes

Corrected patch

Comment #2

skruf commented 14 August 2013 at 14:48

Status	File	Size
new	disqus-add_alter_hook_js_variables-1419562-2.patch	479 bytes

This fails if more than one module implements the hook as module_invoke_all merges all the results recursively into one array. The array structure then changes and is incompatible with the rest of the code eg. $disqus['url'] is now an array rather than a string.

An alter hook would be more appropriate. Here is a patch for this.

Comment #3

slashrsm commented 16 August 2013 at 13:41

Is there anything that can be achieved with this hook and cannot be achieved with hook_js_alter()?

Comment #4

hugronaphor commented 20 March 2015 at 18:39

Issue summary:

View changes

@slashrsm Your last question probably blocked everyone and they silently are using this patch.
Yes you can achieve the same things by hook_js_alter(), but it's easier, cleaner and better to do some Disqus variable re-write in a hook like this.

This is my choice: https://www.drupal.org/files/disqus-add_alter_hook_js_variables-1419562-...