Recommend module [#1419670]

This module enables user to Recommend nodes or comments.
The best part about this module is that it uses AJAX for recommend counts and actual recommend process. As a result of this, we can use this module with external caching enabled (like varnish) and it will still work fine.

The project can be found here: http://drupal.org/sandbox/gargsuchi/1419636

Comment	File	Size	Author
#1	drupalcs-result.txt	12.44 KB	michaelmol

Comments

Comment #1

michaelmol commented 28 January 2012 at 15:25

Status:

Needs review

» Needs work

Status	File	Size
new	drupalcs-result.txt	12.44 KB

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

./mnn_recommend.install: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
```
function mnn_recommend_schema() {
function mnn_recommend_install() {
function mnn_recommend_uninstall() {
```

./mnn_recommend.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming

function mnn_recommend_init() {
function mnn_recommend_perm() {
function mnn_recommend_menu() {
function get_recommend() {
function calculate_recommend_total($content_type, $content_id) {
function get_recommend_total($content_type, $content_id) {
function mnn_recommend_add($recommend) {
function mnn_recommend_link($type = "comment", $content = NULL, $teaser = FALSE) {

Remove all old CVS $Id tags, they are not needed anymore.

mnn_recommend.info:1:; $Id: recommend.info,v 1.0 2012/01/15 gargsuchi Exp $
mnn_recommend.info~:1:; $Id: mnn_recommend.info,v 1.0 2012/01/15 gargsuchi Exp $

Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

You can repeat this automated review at: http://ventral.org/pareview/httpgitdrupalorgsandboxgargsuchi1419636git

Besides that please take a good look at Tips for ensuring a smooth review