Hi

I've noticed that the date widget still shows label when displayed in a row. It's displayed within a fieldset, as a legend; so perhaps this is the reason it's not stripped out in the same way labels are for other widget types.

Cheers

Luke

CommentFileSizeAuthor
#8 field-collection-table.png12.43 KBmpisano
#6 example_components.png20.77 KBlukus
#3 example_firebug.png94.25 KBlukus
#2 example_current.png26.59 KBlukus
#2 example_intended.png20.18 KBlukus

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Postponed (maintainer needs more info)

Can you attach a screenshot?
Also, if you can manipulate it with firebug or something to show how you would expect it to look, a screenshot of that would be great.

lukus’s picture

lukus
he/him
commented
StatusFileSize
new example_intended.png20.18 KB
new example_current.png26.59 KB

Hi Tim

Two screenshots attached.. the first is what it looks like currently, the second is what I'm hoping to achieve.

Current
Intended

lukus’s picture

lukus
he/him
commented
StatusFileSize
new example_firebug.png94.25 KB

Here's the markup for example_current via firebug:

Firebug

lukus’s picture

lukus
he/him
commented

Actually, thinking about this - I think we just need to add an 'element-invisible' class to the legend.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

Well, if the date is split into date parts (year/month/day), I think that's where they'll display. So I'm not sure the best way to hide that.

lukus’s picture

lukus
he/him
commented
StatusFileSize
new example_components.png20.77 KB

Ah, I see what you mean - there might be situations where the legend is required. I suppose in those situations, ideally each date component would be given an individual column.

EDIT: Just tried this with my form and individual headings aren't displayed by default when the date's split by component.

Component Date

Roulion’s picture

Roulion commented

It's the same case with node_reference field type

mpisano’s picture

mpisano commented
Version: 7.x-1.x-dev » 7.x-1.0-beta1
StatusFileSize
new field-collection-table.png12.43 KB

I have the same error, the date field label appears two times plus the DATA label.
And I have others issues:
- I don't want to show the 1º column
- The labels of the checkboxes don't appears.

Edit: I fixed the last 2 errors with http://drupal.org/node/1396056 and http://drupal.org/node/1484136
But I still have labels appearing twice, please see:
http://drupal.org/files/field-collection%20table_labels.jpg

KristineC’s picture

KristineC commented

I'm curious to know if there was a solution for this? I have the same issue with the labels appearing twice on the date module.

kristofferwiklund’s picture

kristofferwiklund commented
Issue summary: View changes
Status: Postponed (maintainer needs more info) » Closed (won't fix)

The problem is the date module.

It is displaying its input as

-- Label --
- Date - - Time -
[ ] [ ]

I don't think its up to field collection table to have special code for date-module. So the work around is to hide it using CSS.

Or hook into the form as this answer (and more)
http://www.mohitsharma.net/how-remove-labels-drupal-datepopup-fields-cus...

And the other solution is to file a issue in date-module to have the option to hide it.