Recoverable fatal error: Argument 2 passed to db_query() must be an array, string given, called in \drupal7\sites\all\modules\httprl\httprl.nonblocktest.inc on line 43 and defined in db_query() (line 2309 of \drupal7\includes\database\database.inc).

CommentFileSizeAuthor
#8 1420092_WSOD_because_of_suppressed_D6_leftover_error.patch803 byteshass
#4 httprl-1420092-4-fix-d7-db_query-syntax-issue.patch529 bytesmikeytown2
#2 1420092 httprl_lock_release() not upgraded to D7.patch589 byteshass
#1 1420092 httprl_lock_release() not upgraded to D7.patch577 byteshass

Comments

hass’s picture

hass commented
Title: Argument 2 passed to db_query() must be an array, string given » httprl_lock_release() not upgraded to D7
Status: Active » Needs review
StatusFileSize
new 1420092 httprl_lock_release() not upgraded to D7.patch577 bytes
hass’s picture

hass commented
StatusFileSize
new 1420092 httprl_lock_release() not upgraded to D7.patch589 bytes

Let's use this one, it's better readable.

hass’s picture

hass commented

I don't know why, but fixing this bug *may* cause a WSOD on report status page and config page after all caches have been cleared. Strange... i cannot find the source of the WSOD.

mikeytown2’s picture

mikeytown2 commented
Status: Needs review » Fixed
StatusFileSize
new httprl-1420092-4-fix-d7-db_query-syntax-issue.patch529 bytes

This patch has been applied to 6.x & 7.x

hass’s picture

hass commented
Status: Fixed » Needs work

As noted above, I see only a WSOD on admin/reports/status. Nothing logged in watchdog and apache error logs, but I get a white page... :-(

mikeytown2’s picture

mikeytown2 commented
Status: Needs work » Postponed (maintainer needs more info)

I can't repo your report on my D7 site. Try running with this at the bottom of your settings.php file.

  // Report all php errors.
  error_reporting(-1);
  // Show Errors in output
  ini_set('display_errors', '1');
  // Display all errors using drupal_set_message().
  $conf['error_level'] = 2;
hass’s picture

hass commented
Priority: Normal » Critical

For release. My site is broken...

hass’s picture

hass commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new 1420092_WSOD_because_of_suppressed_D6_leftover_error.patch803 bytes

Heck... by suppressing errors with @ you made it really hard to track down...

Fatal error: Call to undefined function db_result() in \drupal7\sites\all\modules\httprl\httprl.install on line 124

It would be a good idea to enable automated testing on the project... :-)

hass’s picture

hass commented
Version: 7.x-1.x-dev » 7.x-1.4
hass’s picture

hass commented

$result = db_query('SELECT value FROM {variable} WHERE name = :name', array(':name' => 'httprl_server_addr'))->fetchAssoc(); may be a candidate to get changed to ->fetchField()

hass’s picture

hass commented
Status: Needs review » Fixed

Followup with #8 in #1429264: WSOD because of suppressed D6 leftover error.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.