This should be optional not a requirement.

CommentFileSizeAuthor
#12 recruiter_features-overlay-module-fix-1420368-d7.patch792 byteslikewhoa

Comments

bendruapal’s picture

bendruapal commented
Category: feature » support

how do you get rid of the overlay for resume edit? anybody has an idea for a newbie?

likewhoa’s picture

likewhoa commented
Category: support » feature

don't hijack the thread. kthx

to answer your question, you need to edit the recruiter_features.info and delete the line with overlay module under dependencies. then just disable it in drupal UI or using drush.

mh86’s picture

mh86 commented
Status: Active » Fixed

This is fixed now. The Overlay module is optional, but will be enabled by default.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

likewhoa’s picture

likewhoa commented
Category: feature » bug
Status: Closed (fixed) » Active

looks like overlay requirement is still being forced in recruiter_common.module at line 34. A workaround for me was to add an if statement to check for the overlay_regions function, at least until we can remove dependency on overlay_regions function.

iRex’s picture

iRex commented

@mh86 it does not seem like the dependence on the overlay module has been completely removed . I get the followinf error after disabling the module - "
Fatal error: Call to undefined function overlay_regions() in profiles\recruiter\modules\recruiter_features\recruiter_common\recruiter_common.module on line 34"

iRex’s picture

iRex commented

@likewhoa, please help me out here (non-programmer), just what was the code you used?

iRex’s picture

iRex commented

My bad.... I was a bit hasty. After disabling the overlay module, I had to clear the cache a couple of times before the error went away.

vrMarc’s picture

vrMarc commented
Issue summary: View changes

@iRex, did you do anything else besides disable the overlay module and clear the cache to get the error to go away?

iRex’s picture

iRex commented

@vrMarc ... i also had to modify the front page view by remove reference to overlay class. My memory is a bit hazy about the steps I took to solve this. If you hover your cursor over the job title links on the front page you will see "overlay" appended to the url; that can be removed by going into this view and disabling the rewrite results in the Job Title field - or removing the overlay class.

I also did the same with the job_search view.

pranjitbaruah’s picture

pranjitbaruah commented

As mentioned in the comment no #2 recruiter_features.info is not available under recruiter_features module in the latest version 7.x-1.2. Also overlay class in rewrite results section is not available. Is there is any way to get rid of this irritating overlay. On disable overlay the following error shows
Fatal error: Call to undefined function overlay_regions() in /profiles/recruiter/modules/recruiter_features/recruiter_common/recruiter_common.module on line 34

likewhoa’s picture

likewhoa commented
Status: Active » Needs review
StatusFileSize
new recruiter_features-overlay-module-fix-1420368-d7.patch792 bytes

Attached is a patch that should be applied to the recruiter_features module -dev branch which will get rid of the overlay region call if overlay module is not installed. Keep in mind that an overlay style popup occurs either way but it's in no way connected to the overlay module since this implementation is more tied into recruiter itself.

Do test.

user654’s picture

user654 commented

.

biarr’s picture

biarr commented

The patch from #12 is working as expected. Thanks