Needs review
Project:
PHP Error Report
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
29 Jan 2012 at 20:52 UTC
Updated:
28 Feb 2012 at 16:25 UTC
Jump to comment: Most recent file
Comments
Comment #1
NROTC_Webmaster commentedHere is a patch for the module file and the install file
Comment #2
NROTC_Webmaster commentedComment #3
wojtha commentedAdditionally fixed:
if/else/while/foreachstatemets.t()or with faulty formatted strings (e.g. in the hook_help)_php_errors_get_roles_emails(), now it usesdb_placeholders()to properly cleanup the user roles in thedb_query().splitandjoinreplaced byimplodeandexplode.count()replaced by!empty()where possible (its more safe and less CPU intensive).Plus fixed the following bug which will cause undesired behavior:
(Break will do nothing since we are not inside the loop so the code will continue to execute.)
Comment #4
wojtha commentedThe INFO file needs cleanup as well.
PS: Just noticed that my patches in the previous comment has wrong encoding and line endings, sorry for that.
Comment #5
wojtha commentedAdditionally fixed:
Interdiff is against #1.