Use OAuth by July 31 cutover

Hi Hugh,

thanks for posting this. Did you happen to be working on this? If not, I'll have a look.
I've just rolled a new 7.x-1.2 release; please work on the current dev as I've implemented the 3.1 version of the Flickr API as well.

Thanks a lot!

May I suggest to not re-invent the wheel but use the OAuth module as dependency and only write integration with that module? If anyone knows how to implement it; please do.

Because FlickrAPI 3.1 (the latest version) has no implementation with OAuth authentication, I think we need to override the current class to change the auth() function. Like this:

<?php
/**
 * Implementation of our own class flickrapiPhpFlickr to override the default phpFlickr class.
 * We need to do this because phpFlickr has no implementation of OAuth authentication.
 */
class flickrapiPhpFlickr extends phpFlickr {
  function auth ($perms = "read", $remember_uri = true) {
    // Redirects to Flickr's authentication piece if there is no valid token.
    // If remember_uri is set to false, the callback script (included) will
    // redirect to its default page.

    if (empty($_SESSION['phpFlickr_auth_token']) && empty($this->token)) {
      if ( $remember_uri === true ) {
        $_SESSION['phpFlickr_auth_redirect'] = $_SERVER['REQUEST_URI'];
      } elseif ( $remember_uri !== false ) {
        $_SESSION['phpFlickr_auth_redirect'] = $remember_uri;
      }
      
      // Add OAuth integration here.

      exit;
    } else {
      $tmp = $this->die_on_error;
      $this->die_on_error = false;
      $rsp = $this->auth_checkToken();
      if ($this->error_code !== false) {
        unset($_SESSION['phpFlickr_auth_token']);
        $this->auth($perms, $remember_uri);
      }
      $this->die_on_error = $tmp;
      return $rsp['perms'];
    }
  }
}
?>

As you can see, the hardest part (<?php // Add OAuth integration here. ?>) still has to be taken care of.

I managed to integrate the OAuth module and implement the authorization flow in the FlickAPI admin settings page. The only thing left now is to change the way Flickr is called (http://www.flickr.com/services/api/auth.oauth.html#call_api).

Will be continued.

Committed.

I even added some nice icons ;)