When viewing the checkout review page of an order that doesn't have any coupons applied only the title is shown and the pane's data is empty. Would it be better to give the user some feedback or hide the pane altogether if there isn't anything to show?

CommentFileSizeAuthor
#4 commerce_coupon_hide_checkout_pane.patch1.26 KBfreakalis
#3 commerce_coupon_hide_checkout_pane.patch1.04 KBfreakalis
#2 hide_coupon_review-1421280-3.patch1.13 KBmsmithcti

Comments

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Active » Closed (duplicate)

I think this is a duplicate of #1307420: Hide coupon pane in checkout if no coupons are active

msmithcti’s picture

msmithcti commented
Status: Closed (duplicate) » Needs review
StatusFileSize
new hide_coupon_review-1421280-3.patch1.13 KB

I'm not sure #1307420: Hide coupon pane in checkout if no coupons are active is a direct duplicate. If I'm understanding that issue's description correctly, it's talking about hiding the pane if there aren't any coupons active on the whole site. This feature request is about hiding just the review pane if no coupons were applied to the order on a previous page. I've attached a patch that does what I'm describing.

freakalis’s picture

freakalis commented
Version: 7.x-1.0-beta4 » 7.x-1.0-beta6
StatusFileSize
new commerce_coupon_hide_checkout_pane.patch1.04 KB

Patch in #2 does not work because function commerce_coupon_get_coupons_by_order does not exist anymore.

This patch work in beta6

freakalis’s picture

freakalis commented
StatusFileSize
new commerce_coupon_hide_checkout_pane.patch1.26 KB

Attached wrong patch in #3, here is the correct one

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Needs review » Fixed

Thanks both, I've just committed this, had to rebase the patch to be applied from the module folder and not from the drupal root folder, also fixed an extra space.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.