Posted by splatio on January 30, 2012 at 1:05pm
4 followers
| Project: | Commerce Coupon |
| Version: | 7.x-1.0-beta6 |
| Component: | User interface |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
When viewing the checkout review page of an order that doesn't have any coupons applied only the title is shown and the pane's data is empty. Would it be better to give the user some feedback or hide the pane altogether if there isn't anything to show?
Comments
#1
I think this is a duplicate of #1307420: Hide coupon pane in checkout if no coupons are active
#2
I'm not sure #1307420: Hide coupon pane in checkout if no coupons are active is a direct duplicate. If I'm understanding that issue's description correctly, it's talking about hiding the pane if there aren't any coupons active on the whole site. This feature request is about hiding just the review pane if no coupons were applied to the order on a previous page. I've attached a patch that does what I'm describing.
#3
Patch in #2 does not work because function commerce_coupon_get_coupons_by_order does not exist anymore.
This patch work in beta6
#4
Attached wrong patch in #3, here is the correct one
#5
Thanks both, I've just committed this, had to rebase the patch to be applied from the module folder and not from the drupal root folder, also fixed an extra space.
#6
Automatically closed -- issue fixed for 2 weeks with no activity.