Inline Comments [#1421568]

Inspired by the djangohandbook.com this module allows you to place comments in-line within a piece of content.

To add an in-line comment block to a peice of content simply wrap the content as follows:

<div id="inline-comments-{integer}">
  <!-- Content -->
</div>

Where {integer} is replaced with a positive integer that is unique to that section within that node. Simples!

Project Page: http://drupal.org/sandbox/edb/1420684
Git Repo: git clone --branch 7.x-1.x http://git.drupal.org/sandbox/edb/1420684.git
Drupal Version: 7.x

Comments

Comment #1

rudiedirkx commented 30 January 2012 at 18:11

The README is a little short. "Inspired by the djangohandbook.com" is not enough for a reader to know what this module does.

Does it create HTML comments?
Does it replace HTML divs/elements?
What happens with the unique positive integer?
There's something happening with JS and CSS too...
Etc

Don't tell me. Put it in the README (and on you project page).

Comment #2

rudiedirkx commented 30 January 2012 at 18:18

print drupal_render($variables['comment_form']);

You should be able to call $comment_form directly. No $variables. A list of available variables would be very helpful, not just the file doc. Like page.tpl.php.

Comment #3

edb commented 30 January 2012 at 20:29

Thanks for the feedback, I have updated the README, project page and the tpl file. The changes have been committed.

Comment #4

chrisroane commented 13 February 2012 at 22:57

Status:

Needs review

» Needs work

MANUAL REVIEW
--------------
1. I enabled the module and verified that it works. However, the hover of the content doesn't match the height of content that it is wrapped around? This is in Chrome.

2. The previous button just closed the comment popup and nothing happened (Chrome).

3. When I got to a page with these comments when I am not logged in....it still does the on hover (gray), but when I click on it, it opens a blank popup.

4. Correct me if I'm wrong, but I think people would like options such as: Allow anonymous comments and the format of the comments that they allow (or just allow plain text).

5. With a large page that has many of these comments, it seems like human error could easily miss number the "id" values of the blocks. Why couldn't you just use one class around these divs? I'm not sure exactly how you would determine exactly which comments belong to which div, but this doesn't seem like a very user friendly way of doing this. One option that came to mind is still use id values, but generate a db value and do a search and replace when they save.

AUTO REVIEW
------------
Nothing came up via Coder or the online PAReview tool.