When you create at least one book, and then click its "outline" link in the admin panel, you receive the error:

Fatal error: Unsupported operand types in /Applications/MAMP/htdocs/head/includes/common.inc on line 1318

CommentFileSizeAuthor
#8 142157-book.module.patch888 bytesxqus
#5 book-admin.patch858 byteswebchick
#2 142157-common.inc_.patch791 bytesxqus

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Same error applies to orphan pages, as well. To reproduce, create a book page under a parent book page and delete the parent book page.

xqus’s picture

xqus commented
StatusFileSize
new 142157-common.inc_.patch791 bytes

This happens when the l function is called with NULL as options paramater.

xqus’s picture

xqus commented
Status: Active » Needs review

Don't mind the filename of the patch. The patch is for the book.module file.

robeano’s picture

robeano commented

I tested the patch on 6.x. checked both clicking the outline link and viewing orphan pages. Works great!

Robin

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
StatusFileSize
new book-admin.patch858 bytes

Yep, works for me! Thanks, xqus!

This is just a re-roll from the root. Please do not give me credit in the commit message. :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Reviewed & tested by the community
chx’s picture

chx commented
Status: Reviewed & tested by the community » Needs work

Not having errors does not mean this is a correct patch. The signature of l is function l($text, $path, $options = array()) and you are trying to pass in four arguments. You want to move the fourth argument to the query key of the options array which is hardcoded to be empty ATM.

xqus’s picture

xqus commented
Status: Needs work » Needs review
StatusFileSize
new 142157-book.module.patch888 bytes

Ah, I missed that one.
Should be fixed now. Works fine here, and you are returned to the page you came from after deleting.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Reviewed & tested by the community

Yep, this works! (apart from deleting is broken, but that's not because of this patch. :))

killes@www.drop.org’s picture

killes@www.drop.org commented

Still applies (use -p0) and works as advertized. SImple bugfix.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks! :)

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)