Hi MegaChriz,

I'll be installing your 7.x module (today), and fixing as needed the rest of this week.

To keep us from overlapping effort, what are the items you aren't working on, preferably in order of most useful to least useful, so I can work on those?

(I'll use the normal issue queue to report problems, but wanted to touch base with you, so you'd know I wasn't just spam reporting problems.)

Best,

Sam

Comments

megachriz’s picture

Thanks for your offer to help me! :)

The item where I'm surely will not working on for the next two months is Views integration:
#1391216: Views integration for the 6.x-2.x and 7.x-1.x version

Due to other demands of my time, I've not yet started with one of the issues noted on the release notes of 7.x-1.x. I have some time this week though, and I think I'll start with "Registering with address information" today. You can pick up any of the other issues noted there. If you don't prefer one, I'd like you to work on the order administration issues first.

Below some thoughts about the issues and how to tackle them.

1. Order administration
While checkout in Ubercart has been improved on selecting and copying addresses, the order administration uses the same javascript as in Ubercart 6.x-2.x. This makes the order administration less flexible, as I have plans to add support for extra address fields in the future. If the order administration operates the way it does now, the support of extra address fields will be limited to only a few address fields.
The delivery and billing address form on the checkout page makes use of the #ajax property, with which a Drupal form can be updated by a javascript event. The nice thing about it, is that Drupal updates the form by using the same form API, so issues like "An illegal choice has been detected" can be avoided. The order administration form doesn't use this strategy: it just replaces form elements with javascript without going through the Drupal Form API.
I'd like to have the order administration form work in a similar way as the checkout form.

2. Delivery information does not display in checkout
You posted this issue. I will try to reproduce the problem on a fresh install today and find out what is causing this. If I'm unable to find the cause of the problem within 6 hours from now, you may tackle this one.
#1421720: [$150 Bounty] Delivery information does not display in checkout

3. Automated tests
I've not yet updated all of the automated tests for Drupal 7. Also, the automated tests do not cover everything. Only the "Main flow" is tested, so just with the default settings. The tests for checkout are very limited: the only thing that's tested is that checkout can be completed without problems. Selecting a different address on the checkout page is not tested; that's mainly because I couldn't figure out how to test javascript events in the automated tests. Maybe that's not even possible right now.
If you are experienced with writing automated tests, I'd be happy if you want to work on this one. There is an issue about it:
#1382088: Automated tests

4. Upgrade from Ubercart Addresses 6.x-2.x
The Ubercart Addresses address formats should be updated for the 7.x-1.x version, because the token names differ. Ubercart Addresses address formats are build by using address tokens. The address formats are saved in the variable table by using this pattern:
'uc_addresses_address_format_' . $country_id
$country_id is the ID of the country as known in the uc_countries table. The upgrade script should check which countries are installed in the uc_countries table and update the address formats for each of them (only the address formats that exists, of course). Should not be too hard to implement, but most of the other issues have more priority.

5. Ubercart Addresses user tokens
The address tokens from default addresses should be available in user context. This should be an easy one to implement. Do you have integrated modules with the Token module before? If so, you could pick up this issue. If not, then you'd better leave this one and pick up one of the other issues. This issue has less priority than the others.
This feature was originally requested in #660376: profile tokens against default addresses and has already been implemented for the 6.x-2.x and the 6.x-1.x versions. However, the way it is implemented there will not work equally for 7.x-1.x as the token system has been changed in Drupal 7.

6. Views integration
See #1391216: Views integration for the 6.x-2.x and 7.x-1.x version.

Tell me which one you would like to work on. I will offer assistance where possible.

Edit: ordered the issues from most priority to least priority.

megachriz’s picture

I have fixed the zone issues with "Registering with address information".
See commit.

megachriz’s picture

For the issues mentioned in #1 I've created separate issues that are tagged with 7.x-1.0-alpha1

7.x-1.0-alpha1

Issues to be fixed prior the release of 7.x-1.0-alpha1:

  1. #1424038: Order administration: "copy address" feature
  2. #1421720: [$150 Bounty] Delivery information does not display in checkout
  3. #1382088: Automated tests
  4. #1424022: Upgrade from Ubercart Addresses 6.x-2.x
  5. #1424032: Ubercart Addresses user tokens

7.x-1.0-alpha2

Issues to be fixed after the release of 7.x-1.0-alpha1:

megachriz’s picture

Status: Active » Closed (fixed)

I've opened a new issue with an overview of issues that will be fixed and issues that are in consideration: #1910860: Ubercart Addresses roadmap
As I think it supersedes the information in this issue and the information here is also a bit outdated, I'm closing this issue now.