Problem/Motivation

The reason(s) behind the message "This version is not compatible with Drupal 7.x and should be replaced." are not clear when trying to apply a theme. See:
http://drupal.org/node/785714

Proposed resolution

More precisely record the reason an error occurred, and feed that back to the user.

Remaining tasks

A test for this is probably wise.

User interface changes

Message will be changed slightly depending on the situation.

API changes

None.

CommentFileSizeAuthor
#12 system-compatibility_message-1422108-5.patch87.96 KBMiguel.kode
#4 system-compatibility_message-1422108-4.patch2.81 KBdaniel.nitsche
#3 system-compatibility_message-1422108-3.patch2.81 KBdaniel.nitsche
#1 system-compatibility_message-1422108-2.patch2.74 KBdaniel.nitsche

Comments

daniel.nitsche’s picture

daniel.nitsche commented
Status: Active » Needs review
StatusFileSize
new system-compatibility_message-1422108-2.patch2.74 KB

Attempt number 1 at a patch.

Status: Needs review » Needs work

The last submitted patch, system-compatibility_message-1422108-2.patch, failed testing.

daniel.nitsche’s picture

daniel.nitsche commented
StatusFileSize
new system-compatibility_message-1422108-3.patch2.81 KB

Resubmitting with (hopefully) correct paths for simpletest.

daniel.nitsche’s picture

daniel.nitsche commented
Status: Needs work » Needs review
StatusFileSize
new system-compatibility_message-1422108-4.patch2.81 KB

Same patch with status changed to force simpletest.

edvanleeuwen’s picture

edvanleeuwen
Primary language Dutch
Location Waalwijk
commented

I have noticed that this has the side-effect of giving an error on the standard themes Bartik and Stark.

dcrocks’s picture

dcrocks commented

I tried improving these error messages a while back #619542: Malformed theme .info files break menu_router generation. Maybe you will have better luck.

vase_bac’s picture

vase_bac commented

#3: system-compatibility_message-1422108-3.patch queued for re-testing.

alansaviolobo queued 4: system-compatibility_message-1422108-4.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 4: system-compatibility_message-1422108-4.patch, failed testing.

alansaviolobo’s picture

alansaviolobo commented
Issue summary: View changes
Issue tags: +Needs reroll
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Version: 8.0.x-dev » 8.1.x-dev

Likely need to bump this to 8.1.x but this seems nice to have more clarified UI errors.

Miguel.kode’s picture

Miguel.kode commented
StatusFileSize
new system-compatibility_message-1422108-5.patch87.96 KB

This is the re-roll for this patch, I changed core/modules/system/system.admin.inc

madhavvyas’s picture

madhavvyas commented
Status: Needs work » Needs review
Issue tags: -Needs reroll

Status: Needs review » Needs work

The last submitted patch, 12: system-compatibility_message-1422108-5.patch, failed testing.

dcrocks’s picture

dcrocks commented

This patch no longer applies. 'system.admin.inc' has received a major rewrite with a lot code moved to other files. File length in drupal 8 is 389 lines while it was 3229 lines in drupal 7. Also the messages have been enhanced in drupal 8 and it may no longer be necessary to change them. If this change is still wanted, maybe it should be restricted to drupal 7.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs work » Postponed (maintainer needs more info)
Issue tags: +stale-issue-cleanup

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

D7 is no longer supported and know the version checking that happens now has been pretty reliable so believe this can be closed. If anyone disagrees feel free to re-open

Thanks all

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.