Hi there, thanks for this very well-thought-out ticker module!

Attached is a simple patch for setting BBC ticker's speed and delay options; we've been using it in field without much issues, so we thought it'd be good to contribute back. :-)

Cheers,
Audrey

CommentFileSizeAuthor
bbc_speed_and_delay.diff3.2 KBaudreyt

Comments

doxigo’s picture

doxigo commented
Issue summary: View changes

Thanks for the patch, I used it but end up having these notices:

Notice: Undefined variable: bbcOpts in template_preprocess_views_ticker_view() (line 48 of /sites/all/modules/views_ticker/includes/views_ticker.views.inc).

Notice: Undefined variable: align in include() (line 27 of /sites/all/modules/views_ticker/includes/views-ticker-view.tpl.php).
sgdev’s picture

sgdev commented
Related issues: +#2704723: Refactor module

Audrey and doxigo, we created a patch that includes an upgraded version of the BBC ticker (now called Ticker Tape), includes the speed and delay options, and also added some new options not previous available. If you could review our patch we would appreciate it.

https://www.drupal.org/node/2704723

Thanks.