I have the same problems as stated in http://drupal.org/node/1040172. Emails with subjects show up like this (with and without javascript):

<span class="h"> (subject: Support%20Request%3A%20, amp%3Bbody: Please%20add%20your%20name%2C%20address%20and%20phone%20number%20to%20the%20request%20e-mail%20for%20reply.) </span>
<span class="t">(e-mail)</span>

I tried the solution in the issue for the d6 version adding this on line 95 |(?:\&amp;) but it did not solve the problem.
grossmann-mcs

Comments

escoles’s picture

Seeing this also. As far as I can tell, this happens only if there is BOTH a subject and body argument -- omitting either will allow the code to work.

So you can have subject OR body, but not both.

vali hutchison’s picture

I've just tried the solution in http://drupal.org/node/1040172#comment-5282018 and it works. One thing I noticed I had to do to see the changes was to clear the caches after modifying the spamspan.module file.

So to clarify - i changed line 95 of spamspan.module to:

"(?:\?[A-Za-z0-9_= %\.\-\~\_\&|(?:\&amp;)]*)?)" . # an optional ? followed

I also noticed that if you have an exclamation mark in the subject then this throws a similar error. So to avoid this use:

"(?:\?[A-Za-z0-9_= %\.\-\~\_\&|(?:\&amp;:\!)]*)?)" . # an optional ? followed

vitalie’s picture

Version: 7.x-1.1-beta1 » 7.x-1.2
Assigned: Unassigned » vitalie
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new1.36 KB

Thanks @Desert Dog. I have put the changes into a patch. (I've just added ; and ! to regexp since 'amp' is already being matched, however had to take care about splitting the headers correctly).

  • vitalie committed 23f74a1 on 8.x-1.x
    ported patches for issues #1422462, #1167084, and #1012088
    

  • vitalie committed a8644a4 on 7.x-1.x
    Issue #1422462 by vitalie, Desert Dog: Broken output if mailto: address...
vitalie’s picture

Version: 7.x-1.2 » 7.x-1.x-dev
Status: Needs review » Closed (fixed)
jennypanighetti’s picture

I need this fix, but I don't see a February 2015 7.x-1.x-dev release available!! I only see 6.x and 8.x in the dev box, and the previous 7.x dev was in November 2014.

vitalie’s picture

Sorry @jenstechs, it should be available now.

nerdoc’s picture

We have a year later now, how are chances to get this into D7 as stable release?
Suffering from that bug a over year now...
Is there a new release planned in near future?
Thanks.

vitalie’s picture

@nerdoc, thx. There's a new release now.