Hi,
I've created a small patch for supporting different domains for each language.
It allows the module to index the links as it should according to the node language domain or prefix.

The patch is attached.

Thanks,
ranm

CommentFileSizeAuthor
#3 linkchecker-linkchecker_locale_support-1422464-1.patch1.86 KBranm
#1 linkchecker-linkchecker_locale_support-1422464-1.patch1.94 KBranm

Comments

ranm’s picture

ranm commented
StatusFileSize
new linkchecker-linkchecker_locale_support-1422464-1.patch1.94 KB

Forgot to attach the patch (-:

Status: Needs review » Needs work

The last submitted patch, linkchecker-linkchecker_locale_support-1422464-1.patch, failed testing.

ranm’s picture

ranm commented
Status: Needs work » Needs review
StatusFileSize
new linkchecker-linkchecker_locale_support-1422464-1.patch1.86 KB

Sorry bad patch! This the good one

Status: Needs review » Needs work

The last submitted patch, linkchecker-linkchecker_locale_support-1422464-1.patch, failed testing.

hass’s picture

hass commented

This patch does not only fail because of path issues, it is also completly wrong place for path detection. Code style is also wrong. The extract function is used for every content, it's not for nodes only! I've not tested it with domain detection, but it should work in general. Additional we need a repro case.

ranm’s picture

ranm commented

OK, so it's something I can add, The module has not worked for me under different domains before this patch (not tested on other entities than nodes as you've seen), It created the internal links as default language links only..

hass’s picture

hass commented
Category: feature » bug
Status: Needs work » Postponed (maintainer needs more info)

It should work. If not it's a bug and we need to investigate why... Difficult to test in dev... But url() should do the trick for us. You need to create a repro case, step by step... And what you think is wrong. It can only be the local path stuff... What modules are sou using, too. Best you start with blank install, explain what modules and post one node content to repro.

Prefixed should work as i'm running them at least on D6.

hass’s picture

hass commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)

No feedback for about 11 months, closing case.