WebID Authentication is a module that enables a user to log in a Drupal 7.x site using a client certificate (per the WebID specification).

http://drupal.org/sandbox/larjohn/1381022

http://drupalcode.org/sandbox/larjohn/1381022.git

Drupal 7.x

Comments

alex dicianu’s picture

Hi,
It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

  • Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
  • Remove "version" from the info file, it will be added by drupal.org packaging automatically.
  • The "?>" PHP delimiter at the end of files is discouraged, see http://drupal.org/node/318#phptags
    ./webidauth.parser.inc
    
  • ./webidauth.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
    function _webid_auth_access($uid_arg) {
    
  • Run coder to check your style, some issues were found (please check the Drupal coding standards). See attachment.
  • Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Source: http://ventral.org/pareview - PAReview.sh online service

I've attached the report. Also, the coder module detected some issues.
After I enabled your module, I got some notices that I didn't had before. See below:

    Notice: Trying to get property of non-object in user_access() (line 790 of /Users/dicix/work/www/proiecte/drupal7/modules/user/user.module).
    Notice: Trying to get property of non-object in user_access() (line 802 of /Users/dicix/work/www/proiecte/drupal7/modules/user/user.module).
    Notice: Trying to get property of non-object in user_access() (line 803 of /Users/dicix/work/www/proiecte/drupal7/modules/user/user.module).
    Notice: Trying to get property of non-object in user_access() (line 809 of /Users/dicix/work/www/proiecte/drupal7/modules/user/user.module).
    Notice: Trying to get property of non-object in user_access() (line 812 of /Users/dicix/work/www/proiecte/drupal7/modules/user/user.module).

I also seem to have some access problems, even though I am user/1. I've attached the screenshots.

alex dicianu’s picture

Status: Needs review » Needs work
larjohn’s picture

Status: Needs work » Closed (won't fix)

Project merged with the WebID module.

Any issues will be fixed there, before the module gets a stable release.

Thanks!