I noticed Tao uses too little of these functions. According to http://drupal.org/node/254940#html-class-variable and http://drupal.org/node/254940#html-attributes-variable, we should ensure that these variables are printed correctly within all overridden template files.

They are always defined, since they get at least an empty string from template_process, so no need to check if variable exists. They should be printed directly next to what precedes it in the template, with no leading space.

As a bonus, I tried to set keep any coding styles within template.php and the tpl.php files. This means html will always output " (doublequotes) around attributes and have as little ; (semicolon) in php snippets as possible.

CommentFileSizeAuthor
#10 tao-fix-block-ideas.patch1.17 KBhaydeniv
#5 1422958-05-tao-use-chasses-and-attributes-flattening.patch12.33 KBhaydeniv
#4 1422958-04-tao-use-chasses-and-attributes-flattening.patch12.27 KBhaydeniv
#1 1422958-tao-use-classes-and-attributes-flattening.patch13.17 KBbarraponto

Comments

barraponto’s picture

barraponto
he / him
commented
StatusFileSize
new 1422958-tao-use-classes-and-attributes-flattening.patch13.17 KB
barraponto’s picture

barraponto
he / him
commented
Issue tags: +Tao D7CX
haydeniv’s picture

haydeniv commented

Hi barraponto, this does not apply anymore. Can you re-roll. I'd really like to get a stable release of Tao out soon.

Thanks!

haydeniv’s picture

haydeniv commented
Issue summary: View changes
Issue tags: +D7 stable release blocker
Parent issue: » #1422968: Complete the update path from Tao 6 to Tao 7
StatusFileSize
new 1422958-04-tao-use-chasses-and-attributes-flattening.patch12.27 KB

Here is a re-roll with a couple extra double quotes that were missed and leaving in the end of line semi-colons.

haydeniv’s picture

haydeniv commented
StatusFileSize
new 1422958-05-tao-use-chasses-and-attributes-flattening.patch12.33 KB

Small fix for undefined variable in fieldset template.

haydeniv’s picture

haydeniv commented
Status: Needs review » Fixed

Committed: 13581aa

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rolando.alevelbeyond’s picture

rolando.alevelbeyond commented

this just messed up the whole block naming system.. after this change (i think it was this change) blocks no longer have individual IDs, so there's no way to target them with CSS which is probably a must have for any coder out there..

i reverted the object.tpl to a old version i had of tao and it worked perfectly..

rolando.alevelbeyond’s picture

rolando.alevelbeyond commented

i reviewed the patch.. the issue with my installation (drupal 7.26 and no other modules except admin menu) is that "$vars['hook']" is coming out empty.. so all my blocks are set as "-title" so obviously can't do anything with that.. not sure why $vars['hook'] is coming out empty..

haydeniv’s picture

haydeniv commented
Status: Closed (fixed) » Needs review
StatusFileSize
new tao-fix-block-ideas.patch1.17 KB

Try this patch and see if it fixes your problem.

haydeniv’s picture

haydeniv commented

I just committed this (8e9ddbb) to the -dev version in case you have problems with applying patches.

Please test the latest -dev version and let me know if it resolves the problem. Thanks!

haydeniv’s picture

haydeniv commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

  • Commit 13581aa on 7.x-3.x, 8.x-3.x authored by haydeniv: 
    Issue #1422958 by haydeniv, barraponto: Properly use classes_array,...
  • Commit 8e9ddbb on 7.x-3.x, 8.x-3.x authored by haydeniv:
    Issue #1422958 by haydeniv, barraponto: Properly use classes_array,...