This took (way too long) to track down but I found the cause of why I was having my forms redirect without creating the nodes included in a group. I downloaded the latest dev and was able to cause this, this is the only fix that I found:

The problem:

-Space_og has a submit handler that is added into the group node form called spaces_og_form_group_submit
-For context see http://api.acquia.com/api/open_atrium/profiles--openatrium--modules--con...
-Effectively, allowing this to fire will cause issues with any module who's nodeapi sets the frontpage paths for the associated space because the submit handler looks for those values being set and then firing a purl_goto which breaks the submission flow.

This was a similar issue that was originally identified in workflow_purl that I'd resolved to block the redirect from happening prematurely.
Resolution:
Reordering the keys doesn't work, you simply need to kill off spaces_og_form_group_submit when cloning. I accomplished this in elms in a hook_form_alter in the following commit: https://github.com/btopro/elms/commit/e2b1fe61b377fbf8f951559e44e417f072...
Not saying this should be part of spaces_og_clone because it's an issue with things setting the frontpage value but it probably wouldn't hurt as the function doesn't really do anything.

CommentFileSizeAuthor
#4 spaces_og_clone-killbadsubmithandler-1423000-2.patch1.17 KBbtopro
#3 spaces_og_clone-killbadsubmithandler-1423000-1.patch1.38 KBbtopro
#2 spaces_og_clone-killbadsubmithandler-1423000.patch1.38 KBbtopro

Comments

hefox’s picture

hefox commented

Since that submit is only going to cause trouble, I say might as well purge it on spaces_og_clon

btopro’s picture

btopro commented
Status: Active » Needs review
StatusFileSize
new spaces_og_clone-killbadsubmithandler-1423000.patch1.38 KB

patch to fix issue. I tested this in my dev setup after moving this code from the elms function into the spaces_og_clone equivalent

btopro’s picture

btopro commented
StatusFileSize
new spaces_og_clone-killbadsubmithandler-1423000-1.patch1.38 KB

i'm dumb, rerolling without tabs

btopro’s picture

btopro commented
StatusFileSize
new spaces_og_clone-killbadsubmithandler-1423000-2.patch1.17 KB

ultra-embarrassing... wrong file

hefox’s picture

hefox commented

Seems like it'd work, but:

That could be simplified with a simple array_search

$pos = array_search('spaces_og_form_group_submit', $form['buttons']['submit']['#submit']);
if ($pos !== FALSE) {
  unset($form['buttons']['submit']['#submit'][$pos]);
}

array_values is probably a bad idea and isn't needed; some modules add their submit handles with a non-numeric key so others can do ^ above with just an unset (automodal is one I know of).

btopro’s picture

btopro commented
Status: Needs review » Fixed

changed patch to the method you provided, that's a much easier way of doing what I had in the patch. committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.