Closed (fixed)
Project:
Apache Solr Search
Version:
6.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
31 Jan 2012 at 17:26 UTC
Updated:
5 Mar 2012 at 22:10 UTC
Jump to comment: Most recent file
Comments
Comment #1
nick_vhGreat find. We should probaby unit test this functionality to make sure we prevent this from ever happening again.
Comment #2
nick_vhComment #3
pwolanin commentedComment #5
pwolanin commentedComment #6
rickmanelius commentedAwesome! I'll put in my queue to test if someone doesn't beat me to it (I'll get a reply by later tonight).
Comment #7
rickmanelius commentedThe patch fixes the second error, but I still get the first:
Notice: Undefined property: stdClass::$original in apachesolr_user_update() (line 529 of /sites/all/modules/apachesolr/apachesolr.module).
Is there a way to test and/or add $original in earlier or change the order of the testing?
(isset($account->name) && is_object($account->original) && $account->name != $account->original->name)
is_object($account->original) tests if it's an object, but it's also trying to access $account->original->name in the same line. It seems like we'd have to run a nested if statement.
Comment #8
pwolanin commentedadds 2 issets
Comment #9
rickmanelius commentedWorks! Thanks :)
Comment #10
nick_vhCommitted to 7.x
Comment #11
nick_vhCommitted to 6.x-3.x (only the comment line fix). The rest was not relevant
Comment #12
nick_vh