Commerce Suomen Verkkomaksut (http://drupal.org/sandbox/Risse/1423110) provides integration for Suomen Verkkomaksut -payment method in Drupal Commerce.

There has not been a Suomen Verkkomaksut -payment method integration in either Drupal Commerce or Ubercart.

The module is for Drupal 7, since it uses Commerce.

The git repository can be found at git.drupal.org:sandbox/Risse/1423110.git

CommentFileSizeAuthor
#1 review.txt17.27 KBalex dicianu

Comments

alex dicianu’s picture

alex dicianu commented
StatusFileSize
new review.txt17.27 KB

Hola,
It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Source: http://ventral.org/pareview - PAReview.sh online service

I've attached the report.
In the .module file, line 77 you should remove the debug line:

//drupal_set_message("<pre>".print_r($order,true)."</pre>");
drupaledmonk’s picture

drupaledmonk commented
Status: Needs review » Needs work

Change the status to needs work, if there are any numerous corrections to be made.

risse’s picture

risse commented

Thanks all!

Alright, I cleaned the master repository and made a new branch 7.x-1.x.

I ran it through Drupal Code Sniffer and got no errors anymore! Could you check it again now?

risse’s picture

risse commented
Status: Needs work » Needs review
bfr’s picture

bfr commented
Status: Needs review » Closed (won't fix)

Hi Risse! Thanks for the contribution, but this is clear duplicate of Commerce Suomen Verkkomaksut module. The functionality is similar and the existing module also supports E1 type of payment, in addition of S1.

I did not look your module that close, so if you have some cool ideas that Commerce Suomen Verkkomaksut does not have, consider joining forces with that module, maybe even apply as co-maintainer.

If you disagree with me, feel free to explain and change the status back to "needs review".