The region names have already been ported to sidebar_first and sidebar_right, but the css ids haven't been changed yet. This is minor, but important to support Drupal standards and make it easier to move to D8 in the future.
I do worry that Rubik (Tao most popular child theme) relies on Tao's page.tpl.php but it can copy an old version of page.tpl.php (bad) or upgrade its css selectors (good). It's up to Rubik's mantainers, nonetheless.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 1423552-tao-left-and-region-are-now-sidebar-first-and-sidebar-second.patch | 1.18 KB | barraponto |
Comments
Comment #1
barrapontoComment #2
coffeymachine commentedThere was a small issue with the patch getting 'sidebar_first' mixed up with 'sidebar-first'. I fixed that and went ahead and committed to 7.x-3.x.
This shouldn't affect Rubik as it does not make use of the sidebar_first or sidebar_second regions. Also there are no references to #left or #right in the Tao or Rubik CSS that need to be changed, so I don't see this causing any issues for Rubik or Tao.
Anyone else out there, however, that has built subthemes on Tao may need to update their CSS if they have any selectors on #left or #right. They would need to change them to #sidebar-first or #sidebar-second respectively.