The moderation callback throws the following error when attempting to programmatically submit a delete form:

Illegal choice 0 in Report as inappropriate element.

Despite my previous claims, this needs to be forward-ported to D7.

CommentFileSizeAuthor
#12 mollom.moderate.11.patch20.73 KBsun
#10 mollom.moderate.10.patch20.48 KBsun
#8 mollom.moderate.7.test.patch19.93 KBsun
#8 mollom.moderate.7.patch20.18 KBsun
#6 mollom.moderate.5.test.patch22.81 KBsun
#6 mollom.moderate.5.patch23.06 KBsun
#3 mollom.moderate.2.patch11.1 KBsun
#1 mollom.moderate.1.test.patch10.91 KBsun
#1 mollom.moderate.1.patch11.16 KBsun
mollom.moderate.0.patch11.5 KBsun
mollom.moderate.0.test.patch11.25 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new mollom.moderate.1.patch11.16 KB
new mollom.moderate.1.test.patch10.91 KB

And once again without the additional debugging tweak in the test.

Status: Needs review » Needs work

The last submitted patch, mollom.moderate.1.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new mollom.moderate.2.patch11.1 KB 
+++ b/tests/mollom_test.module
@@ -47,6 +53,13 @@ function mollom_test_mollom_form_list() {
   $forms['mollom_basic_elements_test_form'] = array(
     'title' => 'Mollom basic elements test form',
+    'entity delete multiple callback' => 'mollom_test_delete_multiple',
+  );

That wasn't supposed to be contained either - removed in attached patch. Doesn't have an impact on test results.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, mollom.moderate.2.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new mollom.moderate.5.patch23.06 KB
new mollom.moderate.5.test.patch22.81 KB

Believe me or not, but this kept me busy for the past couple of hours. :(

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 6.x-2.x-dev » 7.x-2.x-dev
Issue tags: +Needs backport to D6
StatusFileSize
new mollom.moderate.7.patch20.18 KB
new mollom.moderate.7.test.patch19.93 KB

More or less the same for D7.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, mollom.moderate.7.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new mollom.moderate.10.patch20.48 KB

Test failure caused by a Drupal core bug: #1429442: Access denied page shown after submitting form that creates a unpublished node

Status: Reviewed & tested by the community » Needs work

The last submitted patch, mollom.moderate.10.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new mollom.moderate.11.patch20.73 KB

#10 was a "test-only patch".

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 7.x-2.x and 6.x-2.x.

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 34e7ad7 on 7.x-2.x, 8.x-2.x, fbajs, actions by sun: 
    - #1423788 by sun: Fixed fatal error on PHP 5.2.
  • Commit be6a3c4 on 7.x-2.x, 8.x-2.x, fbajs, actions by sun:
    - #1423788 by sun: Fixed Content cannot be moderated from Mollom.

  • Commit 34e7ad7 on 7.x-2.x, 8.x-2.x, fbajs, actions by sun: 
    - #1423788 by sun: Fixed fatal error on PHP 5.2.
  • Commit be6a3c4 on 7.x-2.x, 8.x-2.x, fbajs, actions by sun:
    - #1423788 by sun: Fixed Content cannot be moderated from Mollom.