Setting autosubmit (media_vimeo.module line 106) results in not getting to choose the format of the media you want to embed. For media_vimeo this means that all the settings you get to choose on the Manage File Display page (height, width, autoplay) are redundant as you cannot choose which one you are using. The same is true of any other display type you may have (e.g. jw_player), and also the core functionality of media of being able to have different display modes, as you never get to choose.

My guess is it was done to simplify things, but in this case I think it causes more problems than it solves.

A patch is attached.

CommentFileSizeAuthor
media_vimeo-fix-autosubmit.patch499 bytesandrewbelcher

Comments

drewish’s picture

drewish commented
Status: Active » Needs review

Could you give me a couple of quick steps in how to test this and compare the before and after?

andrewbelcher’s picture

andrewbelcher commented

Well, if you have two different display modes on the file, and say small and large (and you'll also have preview for the media browser selection) and you have different sizes for the video on each, when you insert a video into a WYSIWYG via the add media button, you don't get a choice of the size you want to insert as the display mode form where the choice would happen gets auto submitted.

After applying the patch, you should see a page after choosing your media where you can pick your display mode.

RobW’s picture

RobW commented
Status: Needs review » Closed (duplicate)

Referencing this and combining in #1823426: Allow users to select a view mode when embedding videos using WYSIWYG.