Closed (fixed)
Project:
Scripture Filter
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
1 Feb 2012 at 14:05 UTC
Updated:
20 Feb 2012 at 10:40 UTC
Jump to comment: Most recent file
I've noticed that, although the links look properly formed, clicking through to Bible Gateway only seems to bring up the correct translation some of the time. It does for some translations; for others, the BG site serves up what it thinks is my preferred translation based on the cookie it's stored from my last visit.
Trying to change the version using the drop-down box, one can then see that the URLs Bible Gateway use for searching have changed.
Instead of
/cgi-bin/bible?language=X&version=Y&passage=Z
we now have
/passage/?search=Z&version=Y
The module needs changing so as to serve up the correctly formed URLs.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | BibleGateway_URLs-1424420-1.patch | 1.02 KB | jamesoakley |
Comments
Comment #1
jamesoakleyI think this patch solves that problem - Bible Gateway now seems to pull in the correct translation every time.
Can someone check it for me?
Comment #2
jamesoakleyI'm committing this, as further testing confirms to me that it works. If anyone has problems with this, please post below.
The old URLs for Bible Gateway, as served up by this module, were broken, insofar as they did not reliably link to the correct Bible version. The URLs served by the module after this patch has been applied do work, and they now conform to the Bible Gateway specification as found at https://support.biblegateway.com/entries/20885746-bible-gateway-url-stru....