Active
Project:
Vote Up/Down
Version:
7.x-2.x-dev
Component:
vud_field
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
1 Feb 2012 at 14:15 UTC
Updated:
29 May 2017 at 16:54 UTC
Jump to comment: Most recent
When you configuring the field, you can set both 'VOTE UP/DOWN WIDGET' and 'VOTING API TAG'.
But if you will enter your custom tag (not declared by other module with votingapi hook), different than default 'vote', you will partly loose ingeration with votingapi by this tag, because vud_field.module will not declare your custom tag for votingapi (there is hook_votingapi_metadata_alter for that). For example, you will not able to create relationship in views filtered by your new voting tag.
I suggest to add hook_votingapi_metadata_alter() to vud_field.module, that will declare the tag, if user enter new tag, not declared before by other module.
Comments
Comment #1
marvil07 commentedYou are right.
I will say it would be great to have that hook implemented, but instead of doing it while saving field settings, we could also iterate through current vud_field fields settings on the hook and find out which tags we have(with an static cache to avoid rebuilding it every time).
Patches welcome.
PS: BTW "needs review" means a patch ;-)
Comment #2
marvil07 commented