Tagging nodes results in error message - warning: Cannot modify header information

Hi.

I think this is a common problem.
We are working now, on our GSM content website for polish market, and Drupal is realy great.
Everything works perfectly, except this issue.

We have:
Drupal 5.1
Apache/2.2.3 (Debian) PHP/5.2.0-8+etch3
PHP 5.2.0-8+etch3
MySQL 5.0.32

After adding tag (it works, no problems), and clicking any link, we have this warning message:

warning: Cannot modify header information - headers already sent by (output started at
/modules/community_tags/community_tags.module:424) in
/includes/common.inc on line 141.

If anyone can help, please do it.

Exact same error for me on php4 and mysql 4.0. The error goes away after a refresh, using the latest dev tarball...

i can confirm this is not fixed and happens on every install of this module... I wonder why was this passed to fixed state without an explanation or some advice??

Patchak

The problem is caused by some code beginning on line 424 (as the error indicates). The call to set headers is occurring after the actual content is printed. But, headers go before content. Just reverse the two lines. I'll post a patch later today, but for now:

Starting on line 424, change

// Output JSON
  print drupal_to_js(array('status' => TRUE, 'tags' => $tags, 'sequence' => $_POST['sequence']));
  drupal_set_header('Content-Type: text/javascript; charset=utf-8');

To

  // Output JSON
  drupal_set_header('Content-Type: text/javascript; charset=utf-8');
  print drupal_to_js(array('status' => TRUE, 'tags' => $tags, 'sequence' => $_POST['sequence']));

Here is the patch.

Thanks, that patch solved the problem.

I can not reproduce the issue in the current development version. If you guys still have the problem reported, please re-open it.