Closed (fixed)
Project:
Commerce Checkout Login
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
1 Feb 2012 at 22:54 UTC
Updated:
19 Oct 2015 at 11:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Amarjit commentedHello,
I also needed this functionality. I disabled the rule for auto-assigning orders to existing user accounts.
This patch makes it a requirement for users to login before their order can be linked against their e-mail address; if an account exists with that e-mail address.
After installing the module, you can enable the setting via the shop config.
Hope this helps.
Amarjit
Comment #2
kevin.klika commentedApplied [#12] above. Applied cleanly. Hard to find the admin settings page, however.
it is admin/commerce/config/commerce_checkout_login
Works very well, tested.
One more feature would make it worthy of committing:
If the user enters a user that exists, and the correct password, and clicks 'checkout' instead of 'login' (the commerce checkout button vs this module's login button), the form wont validate.
Comment #3
voskuh commented[#1] Thank you very much for your work! Tested, works great besides one thing.
In a situation where a customers fills in the email addres and continues shopping, the email address is filled in by the browser when the customers goes back to the checkout page (at least with Firefox 10) . Unfortunately, the ajax call for checking the email address and showing the password is not triggered. Therefore, the whole commerce checkout login module is ignored. I think this a big problem because the order isn't associated with the user.
[edit]Maybe #1414608: Existing email addresses sometimes escapes the AJAX call can help to solve this problem (unfortunately, I can't test it at this moment)[/edit]
I think [#2] is more a minor issue. By changing the message after clicking the checkout button and instruct the customer to fill in the password and click the login button first, you can bypass this issue.
Comment #4
voskuh commentedOkay, an update. I combined the patch from this issue and #1414608: Existing email addresses sometimes escapes the AJAX call. Now #3 (the bug with browser caching) isn't a problem anymore.
Comment #5
marcoka commentedwhat exactly did you combine?
Comment #6
legolasboThis is fixed in the 2.x branch, where the login button was removed and the login form is submitted as part of the checkout flow.