No contextual links in node lists after a node without contextual links

Nice find, could reproduce this as well. It's menu_contextual_links() which is responsible which keeps a static registry of parent_paths which didn't generate links and returns an empty array the third time, although you have permissions for the node.
Patch attached makes an exception on the node parent_path. Now, this will make the patch at least work, but I'm not sure if this the right way to fix this, however, we know at least where it goes wrong.

@Swentel: I don't think this check is the way to go. I was looking into this as well, it happens with wildcard links, such as 'whatever/%'. The wildcard will be replaced by anything, yet the caching stores the wildcard, not what it is replaced with.

The following works for me:

if (isset($path_empty[$parent_path]) && strpos($parent_path, '%') !== FALSE) {
  return $links;
}

(sorry for not creating a patch, I am unable to right now)

(edit: formatting fixed)

Yeah, I really didn't like that solution as well :)
Trying your solution (untested, but we'll let the testbot decide). If it turns green, we'll need to get Sun in here.

Thank you!

This edge-case was/is known already, as I wasn't sure how to reasonably support it without breaking performance badly. However, this tweak looks acceptable to me.

+++ b/core/modules/contextual/contextual.test
@@ -0,0 +1,45 @@
+class ContextualNodeListTest extends DrupalWebTestCase {

Should end in TestCase, not Test.

+++ b/core/modules/contextual/contextual.test
@@ -0,0 +1,45 @@
+  function setUp() {
+    parent::setUp(array('contextual'));

Let's add

  protected $profile = 'testing';

at the very top of this test case, and afterwards, add 'node' to the list of modules to install.

Lastly, add this before creating the user:

    $this->drupalCreateContentType(array('type' => 'page', 'name' => 'Basic page'));
    $this->drupalCreateContentType(array('type' => 'article', 'name' => 'Article'));

new patch

Thanks guys! Any chance this will be back-ported to 7.x?

+++ b/core/modules/contextual/contextual.test
@@ -0,0 +1,48 @@
+/**
+ * Tests contextual links on node lists with different permissions.
+ */
+class ContextualNodeListTestCase extends DrupalWebTestCase {

ContextualDynamicContextTestCase would actually sound more appropriate.

+++ b/core/modules/contextual/contextual.test
@@ -0,0 +1,48 @@
+    $web_user = $this->drupalCreateUser(array('access contextual links', 'edit any article content'));

You likely need to add 'access content' here to fix the test failures.

+++ b/core/modules/contextual/contextual.test
@@ -0,0 +1,48 @@
+   * Creates an article node, a page node and another article node promoted to
+   * the front page and ensures the contextual links are displaying.

Just:

"Tests accessible links after inaccessible links on dynamic context."

(possibly also adjust the test method name)

+++ b/core/modules/contextual/contextual.test
@@ -0,0 +1,47 @@
+/**
+ * Tests contextual links on node lists with different permissions.
+ */
+class ContextualDynamicContextTestCase extends DrupalWebTestCase {
...
+  /**
+   * Tests accessible links after inaccessible links on dynamic context.
+   */
+  function testNodeLinks() {

The phpDoc on the class and the test method looks somewhat reversed to me :)

Aside from that, this looks good to me.

(Note that another test-only patch wouldn't hurt.)

Thank you!

Extra points and huge credits for introducing the first test for Contextual module! :)

Committed to 8.x. Thanks. Moving to 7.x.

Backport looks good. (Tagging for posterity.) One comment is a little weird, but not important enough since it went into 8.x already. I smell a novice issue. :)

Oooh. Yay for contextual.module tests!

Committed and pushed to 7.x. Thanks!

Opened followup issue: #1462062: Clarify comment and use gender-neutral language in contextual.test.