Attached patch:

  • Removes, from what I can tell, a bunch of redundant functions.
  • Fixes Drupal style issues + removes tabs.
  • Adds a variables parameter to allow for Flash vars support.
  • Adds support for express install.
  • Adds support for the version parameter.
  • Adds a settings page to set up default values.
  • ... and other general clean-up tasks.

-K

CommentFileSizeAuthor
swfobject_1.patch11.3 KBZen

Comments

arthurf’s picture

arthurf commented
Status: Needs review » Fixed

Thanks for the patch. I did not implement it exactly as you suggested- for example, I choose to implement the admin functions the more "traditional" drupal way, rather than doing a separate submit function for the configuration.

Anyway, thanks again for the patch, it's always great to get people helping out with improving the code.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)