Posted by gansbrest on February 2, 2012 at 3:00am
3 followers
| Project: | Google Analytics |
| Version: | 7.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
Hi
I use highslide library on my site to display images in the overlay and internally they use links in the following format to allow user to zoom in into the image:
<a class="highslide-full-expand" href="javascript:hs.expanders[0].doFullExpand();" title="Zoom In" style="display: block;"></a>By looking at the googleanalytics.js file I figured that this link will be treated as external link, even though it's not and will screw reports on google analytics side by storing javascript:hs.expanders[0].doFullExpand(); as the name of the link.
I will attach the patch with additional check before firing _trackEvent for external links. I hope you will consider it or provide better approach.
Thanks a lot!
Comments
#1
Patch is attached.
#2
I've seen this myself to with colorbox... But https? Is not ok as it could also be ftp and others.
#3
What about this one? It should match most common protocols, but skip those like javascript:bla
#4
#5
The last submitted patch, external_links_1425358_3.patch, failed testing.
#6
Ok, here is the patch for D7 and previous one from #3 was for D6, that's why it failed last time.
#7
You always need to change the issue status
#8
Required for next release