pwolanin noted in IRC that notices like the following are triggered when the module is uninstalled:

Notice: Use of undefined constant TAXONOMY_ACCESS_VOCABULARY_DEFAULT - assumed 'TAXONOMY_ACCESS_VOCABULARY_DEFAULT' in taxonomy_access_schema() (line 64 of /Users/Shared/www/modules/taxonomy_access/taxonomy_access.install).

The best option seems to be just using a literal and indicating which constant is in a comment.

CommentFileSizeAuthor
#5 constants-schema.patch4.75 KBxjm
#3 constants.patch4.76 KBxjm
#1 constants.patch6.74 KBxjm

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new constants.patch6.74 KB

Attached is totally untested.

Status: Needs review » Needs work

The last submitted patch, constants.patch, failed testing.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new constants.patch4.76 KB

Just in hook_schema().

Status: Needs review » Needs work

The last submitted patch, constants.patch, failed testing.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new constants-schema.patch4.75 KB

Testbot's mom is unable to apply the patch!

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Needs tests, +Novice

Let's add an automated test that just installs and uninstalls the module. It should fail without the patch here, and pass with it. Tagging novice to add the test.

Seijun’s picture

Seijun commented

When I uninstalled TAC (using drupal), I received a string of "Use of undefined constant" errors, although drupal still said that TAC uninstalled successfully. Is there anything further I need to do, or do these errors not effect the efficiency of the uninstall?

Seijun’s picture

Seijun commented
Issue summary: View changes

.