I'm guessing this is a bug, but I'm not entirely sure about intended functionality.

I have Facebook, Twitter, and a few other sharethis links, but only the "Share this with your friends" link is opening in a pop up (on hover or click). The others open as a new tab on click.

Any ideas how I can get all to popup on the page?

Many thanks...

CommentFileSizeAuthor
#19 Screen Shot 2016-05-18 at 4.17.57 PM.png31.24 KByogeshmpawar
#15 pop_not_working_for_all-1425744-15.patch2.27 KBnavneet0693
#9 1425744-sharethis-popup-9.patch2.61 KBgrndlvl
#7 1425744-sharethis-popup-7.patch3.01 KBcashwilliams

Comments

djh007’s picture

djh007 commented

Anyone? Any clues? Is a new tab usual for Facebook / Twitter links?

If not, how can I fix this?

webroru’s picture

webroru commented

I have same error..
Drupal core 7.15
ShareThis 7.x-2.4

drupalove’s picture

drupalove commented
Version: 7.x-2.2 » 7.x-2.x-dev

Did you find a solution?
The extra services which are not supported have the usual popup window.
The normal services and other links open in a new window!!! No, it's not normal behaviour to take people to another tab. They should be able to tweet while on page.

libbyy’s picture

libbyy commented

I am also having this problem - all links open in a new tab

RockSoup’s picture

RockSoup commented

I am also wondering if there is a way to change the default behavior of links opening in a new tab to opening in a new window.

Thanks!

gaurav.goyal’s picture

gaurav.goyal commented

I am also having this problem, did you find a solution..?

cashwilliams’s picture

cashwilliams commented
Issue summary: View changes
StatusFileSize
new 1425744-sharethis-popup-7.patch3.01 KB

Here is a patch that enables the servicePopup option which will render a popup rather then a new tab. This is against the latest dev version.

cashwilliams’s picture

cashwilliams commented
Category: Bug report » Feature request
Status: Active » Needs review

Updating status

grndlvl’s picture

grndlvl commented
StatusFileSize
new 1425744-sharethis-popup-9.patch2.61 KB

Removing extranous content added to the info file from downloading -dev release in info file.

Works as described

meecect’s picture

meecect commented

The patch worked for me. Is there a way to make this display in a modal lightbox/colorbox though instead of a popup or new tab?

Real_gambi queued 9: 1425744-sharethis-popup-9.patch for re-testing.

grndlvl’s picture

grndlvl commented

@meecect that sounds like yet another feature to me. You may want to create another ticket for that.

sumitmadan’s picture

sumitmadan commented
Status: Needs review » Reviewed & tested by the community

This works pretty well. Tested and using it on live site. Thank you so much.

purushotam.rai’s picture

purushotam.rai commented
Status: Reviewed & tested by the community » Needs work

Patch is outdated, needs work.

navneet0693’s picture

navneet0693 commented
StatusFileSize
new pop_not_working_for_all-1425744-15.patch2.27 KB
navneet0693’s picture

navneet0693 commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 15: pop_not_working_for_all-1425744-15.patch, failed testing.

navneet0693’s picture

navneet0693 commented
Status: Needs work » Needs review
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2016-05-18 at 4.17.57 PM.png31.24 KB

Popup is working now, clear to go.

purushotam.rai’s picture

purushotam.rai commented
Status: Reviewed & tested by the community » Patch (to be ported)

purushotam.rai’s picture

purushotam.rai commented
Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.