Hello,

I'm trying to use OpenPublic in Jenkins.
Some tests are done on JS files and CSS.

The CSS tests are failing on themes/openomega/css/global.css because of the:
@charset "UTF-8"

According to W3C, it must not be preceded by any characters, not even comments.

Comments

DSheffler’s picture

DSheffler commented
Category: bug » support

We do not support Jenkins at this time. However, I am leaving this open to see if someone from the community is able to help answer your question.

pol’s picture

pol
Location Brussels
commented

Hi @DSheffler,

It's not a matter of supporting Jenkins, it's a matter of coding standard.

To reproduce the problem, copy-paste the content of that file (http://drupalcode.org/project/openpublic.git/blob_plain/refs/heads/7.x-1...) into CSSlint.
CSSlint will report one error, it's because @charset "UTF-8" must be at the first line.

You can fix it just by doing:

@charset "UTF-8";
/* This file will hold the main styles for your website. */

Instead of:

/* This file will hold the main styles for your website. */
@charset "UTF-8";

Thanks for fixing it...

pol’s picture

pol
Location Brussels
commented
Category: support » bug

Forgot to change the category...

hefox’s picture

hefox commented
Project: OpenPublic » Open Omega
Version: 7.x-1.0-beta4 » 7.x-1.x-dev
Issue summary: View changes

  • hefox committed bf30a71 on 7.x-1.x 
    Issue #1426958: Move/reword top comment
hefox’s picture

hefox commented
Status: Active » Fixed

huh, brings up a code style conflict -- drupal standards is to have a @file at top https://www.drupal.org/node/1887862

Moved, but should be likely should be testing your site with css aggegration on. Not sure if that'd make it worse though (e.g. if it'd manage to be the top in the aggegrated css it's in)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.