There is a minor flaw in the commerce product form.

CommentFileSizeAuthor
#5 1427144-2.patch499 bytesgoogletorp
#3 1427144-3.patch941 bytesamateescu

Comments

googletorp’s picture

googletorp commented

I've added a fix to my sandbox, it was a pretty simple fix 8b6925e:

googletorp’s picture

googletorp commented
Status: Active » Needs review

Forgot status as usual :)

amateescu’s picture

amateescu commented
StatusFileSize
new 1427144-3.patch941 bytes

Hmm.. I'd prefer doing something like the patch attached.

rszrama’s picture

rszrama commented
Status: Needs review » Fixed

Ahh, good call. Yeah, let's go with the second patch to just have that default available all the time.

googletorp’s picture

googletorp commented
Status: Fixed » Needs review
StatusFileSize
new 1427144-2.patch499 bytes

I thought about the other approach seems fine by me.

However, creating new revisions by default (on every product save) doesn't sound like a good default. This should be changed.

Created a patch for it: Commit diff

rszrama’s picture

rszrama commented
Status: Needs review » Fixed

Revisions are enabled by default in the Product UI module as is (see commerce_product_ui_product_type_new()), so I think it's a separate issue that at this point would require an upgrade path. That said, I prefer to retain more data by default - hence orders always creating new revisions on save.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.