SSL detection is faulty

hass - May 9, 2007 - 21:18
Project:Google Analytics
Version:5.x-1.2
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

The current SSL detection isn't working on IIS, while IIS have $_SERVER['HTTPS'] = "off" set if traffic is non-SSL. This small change fixes the bug:

    // Are we on a secure page?
    if($_SERVER['HTTPS'] == "on") {
      $prefix = 's://ssl';
    }

#1

hass - May 12, 2007 - 23:58
Status:active» needs review

#2

budda - May 13, 2007 - 17:06
Status:needs review» fixed

Committed recommended SSL detection routine to CVS. Let me know how this goes for IIS, and Apache, i've not got a 5.x HTTPS site to test on.

#3

Anonymous - May 27, 2007 - 17:31
Status:fixed» closed
 
 

Drupal is a registered trademark of Dries Buytaert.