OG 6.x-2.2 Causes OG Forum to 'White Screen'

@MiniMax, I have verified that your fix works. For my own education, how did you get the call trace and also how did you find what needed to be changed in og.module?

I inserted trace code into og_forum.module. Prior to the OG upgrade:

• the function og_forum_access_forum_page was called with the tid of the private forum container (232)
• the function og_forum_set_og_group_context_from_tid was called and identified the gid of the associated group node (119)
• the function og_forum_access_forum_page was called with the tid of the group node (119) and returned the value TRUE
• the function og_forum_topic_redirect was called with the tid of the private forum container (232)

After the OG upgrade:

• the function og_forum_access_forum_page was called with the tid of the private forum container (232)
• the function og_forum_set_og_group_context_from_tid was called and identified the gid of the associated group node (119)
• the function og_forum_access_forum_page was called with the tid of the private forum container (232)
• we end up in a recursive loop

Further tracing indicated that control never returns from og_forum_set_og_group_context_from_tid back to og_forum_access_forum_page, suggesting that the function og_set_group_context is causing the recursive loop. This is consistent with the fix you posted.

I assume that og_forum has a hook somewhere that is causing the recursive loop. Any ideas on how to cleanly fix this problem?
Thanks, Norbert

@Grayside, at the risk of revealing my paltry knowledge of Drupal, are you suggesting that OG Forum should set the group context earlier via a hook_init() call, rather than from the og_forum_access_forum_page function? As I read the OG Forum code, the group context depends on the specific forum container being displayed.

The culprit appears to be the call to og_set_group_context from og_forum_access_forum_page, which is defined here:

function og_forum_menu_alter(&$callbacks) {
  $callbacks['forum']['access callback'] = 'og_forum_access_forum_page';
  $callbacks['forum']['access arguments'] = array(1);
  $callbacks['forum']['page callback'] = 'og_forum_topic_redirect';

A little knowledge is a very dangerous thing, but it did not seem that og_forum_access_forum_page referenced any group context information. I removed the call to og_forum_set_og_group_context_from_tid and restored the original 6.x-2.2 og.module - so far, everything seems to be working. I have only done very minimal testing:

• visitor
• logged in user who is not a member of any group with private forums
• logged in user who is a member of a group with private forums

A review by someone who actually knows what they are doing would be advisable (:-).

@jvieille, the change is in og_forum_access_forum_page:

function og_forum_access_forum_page($tid = 0) {
  if (!user_access('access content')) {
    return FALSE;
  }
  global $user;

  if ($tid != 0) {
// resolve recursive loop after upgrade to og-6.x-2.2
//  og_forum_set_og_group_context_from_tid($tid);
    $gid = og_forum_gid_from_tid($tid);
    if ($gid) {

@MiniMax, thanks for the tip on xdebug! I got it installed this morning and now have a massive trace of a 'forum' call.

@Media Crumb, I am not seeing these symptoms but there does seem to be a problem. If I go to <domain>/og/my, I see a list of groups of which I am a member. Clicking on a group brings up the OG document for that group with View, By Term and Forums tabs at the top. View shows me recent activity, By Term shows me forum topics by taxonomy tags, but Forums only shows the forum topics within one of several forums.

I have not explored this path in the past so cannot tell if or when it last worked. I go directly to <domain>/forum.

Do you have the resources to revert back to OG 6.x-2.1 to see if the problem is introduced by the the OG upgrade or the patch to OG Forum? I am tied up trying to learn how Drupal hooks, OG Forum and xdebug work (:-).

@Media Crumb, I just tested on my production site (OG 6.x-2.2, OG Forum 6.x-2.2 with patch) - a visitor or registered user cannot view a private forum even if they know the URL. I recall OG Forum exposed the names of private forums through the taxonomy structure, something thePanz+Lirantal patch were supposed to fix. There is a thread starting around http://drupal.org/node/1055424#comment-4326762 that suggests the node_access table can get corrupted. I was never able to reproduce this problem but suspect it has something to do with multiple contributed modules trying to set node permissions for a forum topic.

In terms of the group block used to manage group membership, I have

• title of the group
• a bunch of Create content links
• 'Group forums' (only shows forum topics associated with one of my forums)
• 'Manage group forums' (shows a list of forums associated with the group)
• 'Invite friend'
• 'nn members'
• 'Manager:' (group manager)
• 'My membership'

When I clicked on 'Manage group forums', I noticed one orphan forum (I recall having problems with it in the past). Two of the forums associated with the group had 'Make private' links, which is a bit disconcerting. The rest had 'Make public' links. On further checking, it looks like the two 'public' forums were actually private but contained forum topics that had been marked as public. A visitor or a registered user who is not part of the group can see the forum and the public forum topics, but nothing else. All other forums and forum topics result in 'Access Denied'.

I am not sure what to suggest - my suspicion is either an incompatibility with another contributed modules or issues with the OG Forum/OG configuration.