NOTE: Using Views 7.x-3.1

Not sure what's happening here, but I have attempted to use the In Cart block view to provide a block across the store I am working to indicate the number of items the user has in their cart (a pretty normal implementation of this feature I believe).

I've added screenshots below depicting the scenario.

The Items in Cart is placed as a block at the top of the content and is available on all pages.

Prior to placing any items in the cart the block doesn't show or indicate any items in the cart.

After placing any item in the cart, the total reflected in the block doesn't change.
After removing items from the cart, the total reflected in the block doesn't change.
Emptying the cart still shows the same number of items in the cart.

I'm baffled... could this be a bug in the commerce and/or views modules?

CommentFileSizeAuthor
#10 Region capture 10.png99.15 KBtimodwhit
#10 view_block_header_links.txt62.19 KBtimodwhit
#5 Testing Orders including abandoned or emptied carts162.4 KBcraigkendall
#4 Here it is in a .txt file as well5.5 KBcraigkendall
Image showing home page after removing 1 item still shows 5 items in cart644.67 KBcraigkendall
Image showing 1 item removed from cart leaving only 1 item43.56 KBcraigkendall
Image of cart showing only 2 items59.03 KBcraigkendall
Image of home page with block enabled and positioned and 2 items in cart showing 5 items271.18 KBcraigkendall
Image of overall settings for In Cart view110.04 KBcraigkendall
Image of settings in Views for Footer > Line Item Summary enabled in Footer 71.44 KBcraigkendall

Comments

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented

Just to rule something out: are you sure the page or block is not served from cache?

craigkendall’s picture

craigkendall commented

Great question. I have tried clearing the cache and refreshing and no change.

I have also disabled any custom pricing and shipping rules I have set up (for tax and flat rate shipping) and the result, even clearing the cache manually is still the same.

The one thing I have thought of, but not yet tried (thought I would see if anyone had a "Oh, I had that and solved it by..." suggestion first) is creating a from-scratch Drupal Commerce Kickstart installation and seeing if the behavior is similar to rule out any of the modules, etc. I've implemented from causing the errant behavior.

rszrama’s picture

rszrama commented

Hmm, definitely a common use case, and I was under the impression it should work. In fact, a test on a clean Kickstart shows it does - there's nothing special about that area handler, really. It just tallies up the total quantity of all line items in a Views result set and prints out a number. This tells me there's a problem in your customization some where (since you've ruled out caching issues). I do appreciate the screenshot approach to documenting the problem, though. : )

Perhaps you can post an export of the View so we can check it out? Perhaps there's something about the way you've customized it that's causing it to always count 5 line items or something strange like that.

craigkendall’s picture

craigkendall commented
StatusFileSize
new Here it is in a .txt file as well5.5 KB

I was afraid you were going to say that... (part of why I had not already done the Kickstart default install to test it... hoping it was not so).

Glad to post the view export! Essentially I cloned the Shopping Cart one so I had something to work with. Then disabled the display of the main fields and used the line item summary in a footer and in order to have the styling I needed around it placed global text items with opening and closing div tags above and below the feed of the line item summary.

Thanks so much for the feedback and attempt to help.

$view = new view;
$view->name = 'in_shopping_bag';
$view->description = '';
$view->tag = 'default';
$view->base_table = 'commerce_line_item';
$view->human_name = 'In Shopping Bag';
$view->core = 7;
$view->api_version = '3.0';
$view->disabled = FALSE; /* Edit this to true to make a default view disabled initially */

/* Display: Master */
$handler = $view->new_display('default', 'Master', 'default');
$handler->display->display_options['title'] = 'In Shopping Bag';
$handler->display->display_options['access']['type'] = 'none';
$handler->display->display_options['cache']['type'] = 'none';
$handler->display->display_options['query']['type'] = 'views_query';
$handler->display->display_options['query']['options']['query_comment'] = FALSE;
$handler->display->display_options['exposed_form']['type'] = 'basic';
$handler->display->display_options['pager']['type'] = 'some';
$handler->display->display_options['pager']['options']['items_per_page'] = '5';
$handler->display->display_options['style_plugin'] = 'default';
$handler->display->display_options['row_plugin'] = 'fields';
$handler->display->display_options['row_options']['hide_empty'] = 0;
$handler->display->display_options['row_options']['default_field_elements'] = 1;
/* Footer: Global: Text area */
$handler->display->display_options['footer']['area']['id'] = 'area';
$handler->display->display_options['footer']['area']['table'] = 'views';
$handler->display->display_options['footer']['area']['field'] = 'area';
$handler->display->display_options['footer']['area']['label'] = 'Top of Cart Link';
$handler->display->display_options['footer']['area']['empty'] = FALSE;
$handler->display->display_options['footer']['area']['content'] = '<div id="shopping-bag-icon"><a href="/cart">';
$handler->display->display_options['footer']['area']['format'] = 'php_code';
$handler->display->display_options['footer']['area']['tokenize'] = 0;
/* Footer: Item Quantity in Shopping Bag */
$handler->display->display_options['footer']['line_item_summary']['id'] = 'line_item_summary';
$handler->display->display_options['footer']['line_item_summary']['table'] = 'commerce_line_item';
$handler->display->display_options['footer']['line_item_summary']['field'] = 'line_item_summary';
$handler->display->display_options['footer']['line_item_summary']['ui_name'] = 'Item Quantity in Shopping Bag';
$handler->display->display_options['footer']['line_item_summary']['info'] = array(
  'quantity' => 'quantity',
  'total' => 0,
);
/* Footer: Global: Text area */
$handler->display->display_options['footer']['area_1']['id'] = 'area_1';
$handler->display->display_options['footer']['area_1']['table'] = 'views';
$handler->display->display_options['footer']['area_1']['field'] = 'area';
$handler->display->display_options['footer']['area_1']['label'] = 'Bottom of Shopping Bag Link';
$handler->display->display_options['footer']['area_1']['empty'] = FALSE;
$handler->display->display_options['footer']['area_1']['content'] = '</a></div>';
$handler->display->display_options['footer']['area_1']['format'] = 'php_code';
$handler->display->display_options['footer']['area_1']['tokenize'] = 0;
/* Field: Commerce Line Item: Line item ID */
$handler->display->display_options['fields']['line_item_id']['id'] = 'line_item_id';
$handler->display->display_options['fields']['line_item_id']['table'] = 'commerce_line_item';
$handler->display->display_options['fields']['line_item_id']['field'] = 'line_item_id';
$handler->display->display_options['fields']['line_item_id']['label'] = '';
$handler->display->display_options['fields']['line_item_id']['alter']['alter_text'] = 1;
$handler->display->display_options['fields']['line_item_id']['alter']['text'] = '&nbsp;';
$handler->display->display_options['fields']['line_item_id']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['line_item_id']['alter']['absolute'] = 0;
$handler->display->display_options['fields']['line_item_id']['alter']['external'] = 0;
$handler->display->display_options['fields']['line_item_id']['alter']['replace_spaces'] = 0;
$handler->display->display_options['fields']['line_item_id']['alter']['trim_whitespace'] = 0;
$handler->display->display_options['fields']['line_item_id']['alter']['nl2br'] = 0;
$handler->display->display_options['fields']['line_item_id']['alter']['word_boundary'] = 1;
$handler->display->display_options['fields']['line_item_id']['alter']['ellipsis'] = 1;
$handler->display->display_options['fields']['line_item_id']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['line_item_id']['alter']['trim'] = 0;
$handler->display->display_options['fields']['line_item_id']['alter']['html'] = 0;
$handler->display->display_options['fields']['line_item_id']['element_label_colon'] = FALSE;
$handler->display->display_options['fields']['line_item_id']['element_default_classes'] = 1;
$handler->display->display_options['fields']['line_item_id']['hide_empty'] = 0;
$handler->display->display_options['fields']['line_item_id']['empty_zero'] = 0;
$handler->display->display_options['fields']['line_item_id']['hide_alter_empty'] = 1;
/* Filter criterion: Commerce Line Item: Type */
$handler->display->display_options['filters']['type']['id'] = 'type';
$handler->display->display_options['filters']['type']['table'] = 'commerce_line_item';
$handler->display->display_options['filters']['type']['field'] = 'type';
$handler->display->display_options['filters']['type']['value'] = array(
  'product' => 'product',
);

/* Display: Block */
$handler = $view->new_display('block', 'Block', 'block');
$handler->display->display_options['block_description'] = 'In Shopping Bag';
craigkendall’s picture

craigkendall commented
StatusFileSize
new Testing Orders including abandoned or emptied carts162.4 KB

Here's an interesting added piece of information.

I noticed there was a limit of 5 items on the max amount in the Pager section so I set it to 0 and discovered there were actually 20 items showing as in the cart.

It appears that even though I have emptied the cart when testing different things in the store, it appears there is some record of those carts (see attached image) and deleting each one will decrease the number of items showing in the cart.

So that prompts a question... how long will those emptied or abandoned cart records stay in the View Orders listing and is there a way to delete from the list any "ghost" listings when someone deletes all the items in their cart?

craigkendall’s picture

craigkendall commented

Just trying to bump this in case rszrama or others have not seen the added #5 or #4 info.

timodwhit’s picture

timodwhit commented

I don't know if this is relevant but it seems very similar to what is happening and I think it could be associated with the Order ID.

Here is my user case: I come to a site login add something to the cart. Decide "I don't have money for that" log-off, but keep the item in my cart. I return to the site, forget to login but add something to the cart. The item now added to the cart creates a new order ID because I am anonymous (this is what we want) but then what ends up happening is I go, "Oh man, I need to login" and when I login, the cart only has the most recent order id loaded. And ignores my previous orders and does not display them to me.

If this is correct, my guess is that we could do a couple things: 1) figure a way to combine orders (this is not a good idea, because it means that a user would not have control over which order to choose and/or there could be a possibility that the user ends up dissatisfied.) 2) I think it would be good to have the option of being able to take an order and "Add to current order". Otherwise, just keep the orders separate and show the user "Item's recently added to the cart."

Sorry if this isn't relevant. But I was struggling with the views and managing them appropriately because my cart looked so goofy.

timodwhit’s picture

timodwhit commented

Digging deeper: Looks like like the problem is coming in around line 600 of commerce_cart.module, 

 // Create an array of valid shopping cart order statuses.
  $status_ids = array_keys(commerce_order_statuses(array('cart' => TRUE)));

  // If a customer uid was specified...
  if ($uid) {
    // Look for the user's most recent shopping cart order, although they
    // should never really have more than one.
    return db_query('SELECT order_id FROM {commerce_order} WHERE uid = :uid AND status IN (:status_ids) ORDER BY order_id DESC', array(':uid' => $uid, ':status_ids' => $status_ids))->fetchField();
  }

So in the best case scenarios they should not have more order than one but what can end up happening is that if you start as anonymous and then log-in, your previous orders are lost... This would then create the error of dups/challenges in the creation of a blocks associated with the cart.

Also, I'm not a php programmer, so I'm solely basing the above code based on the commenting.

rszrama’s picture

rszrama commented

Hmm... Realistically, most people will only have 1 cart as commented, but there are no technical problems with someone having multiples. I actually demonstrate that functionality in all our trainings and never get any errors.

timodwhit’s picture

timodwhit commented
StatusFileSize
new view_block_header_links.txt62.19 KB
new Region capture 10.png99.15 KB

Hey Ryan,

I don't know if I would call it an error on the issue, the problem that is vexing is the aggregation of orders in views and I think there might be some interesting things happening with how views is handling the "views_form_commerce_cart_default" form.

Here is where I am getting an issue: If you notice the customer ("me") has two orders that are appearing in the cart. The header links are generated using aggregation in views and aggregation with the the filter "Commerce status = in shopping cart." The cart form is currently only pulling the most recent order ID (ex: order ID:48). So if a customer leaves an item in the cart, logs-off. Adds something anonymously, logs-on. A new order is present and only the new item is present in the cart. It makes sense why this is necessary, but the problem that I have encountered is trying to make the previous "in shopping cart" items a) no longer present in the view, b) edit-able by the customer. Allowing the customer to come back to those items that may be on the wish list.

Would there be a way to append the form to have it pull all orders/ allow customers to move items from one order to another order while the order is in certain state? Or is there a better way to do aggregation than aggregating all commerce line items?

Attached are a screen shot and my view.

Thanks for the help

rszrama’s picture

rszrama commented

Right, I understand how to make multiple shopping carts as a single user. We've had that functionality for quite some time, but what I don't understand is why your Views are including line items from multiple orders. That technically isn't possible given the way the default Views work. I see that you've added a custom display to the Cart block View (on the to-do list for core, but needs an upgrade path), so you are also responsible for adding the argument (contextual filter they're called now) to limit the View to only use the customer's current shopping cart order. The tools are there for you to use, you just need to choose the right default value for the order ID argument.

I don't think that is the original issue here, though, right?

timodwhit’s picture

timodwhit commented

sorry for the confusion.

The contextual filters aren't quite working for me, will give it more tries. Sorry if this diverted the original issue, thought the two were related. oops.

craigkendall’s picture

craigkendall commented

Contextual Filter solved my issue. THANKS! I added a contextual filter for the COMMERCE LINE ITEM: ORDER ID selected the PROVIDE DEFAULT VALUE option and set it to CURRENT USER'S CART ORDER ID. Viola!

Thanks for the pointer rszrama!

craigkendall’s picture

craigkendall commented
Status: Active » Closed (fixed)

Oh, fixed.

timodwhit’s picture

timodwhit commented

What great success!!!! Thank you so much, craigkendall and rszrama!

I added a pager to the links to only display the recent order, pulled in aggregation, as well, and no longer the dups of orders or the problems associated with multiple "in-shopping cart" displays. Thanks.

rszrama’s picture

rszrama commented

Excellent, glad we got a solution. : )